hugohuetzel hugo.huet...@noid-project.de added the comment:
rle_picture_len: length of rle data needed for decoding the
subpicture (over all packets)
rle_data_len: length of rle data received
Any suggestions for an other variable name?
_
hugohuetzel hugo.huet...@noid-project.de added the comment:
sounds like a seperate bugfix belonging to a seperate patch
It is not possible to append data to a too big buffer. So the 2
patches belongs together.
these names are poor, its quite unlcear what they represent
I have choosen a name
Michael Niedermayer michae...@gmx.at added the comment:
On Mon, Feb 01, 2010 at 09:16:34AM +, hugohuetzel wrote:
hugohuetzel hugo.huet...@noid-project.de added the comment:
sounds like a seperate bugfix belonging to a seperate patch
It is not possible to append data to a too big
Michael Niedermayer michae...@gmx.at added the comment:
On Mon, Feb 01, 2010 at 01:39:12PM +, Michael Niedermayer wrote:
Michael Niedermayer michae...@gmx.at added the comment:
On Mon, Feb 01, 2010 at 09:16:34AM +, hugohuetzel wrote:
hugohuetzel hugo.huet...@noid-project.de
New submission from hugohuetzel hugo.huet...@noid-project.de:
Patch for pgssubdec to support RLE data over multiple packets
--
files: pgs_multipck.patch
messages: 9092
priority: normal
status: new
substatus: new
title: Patch for pgssubdec to support RLE data over multiple packets
type:
Carl Eugen Hoyos ceho...@rainbow.studorg.tuwien.ac.at added the comment:
Is there a sample available?
--
status: new - open
substatus: new - needs_more_info
_
FFmpeg issue tracker iss...@roundup.ffmpeg.org
Carl Eugen Hoyos ceho...@rainbow.studorg.tuwien.ac.at added the comment:
Relevant sample uploaded to incoming/issue1717/pgs_multipck_2.m2ts
@hugohuetzel: Your patch contains a mix of functional and cosmetic changes,
which makes reviewing harder and is therefore not accepted here (=please resend
hugohuetzel hugo.huet...@noid-project.de added the comment:
Sorry, but there are no cosmetic changes.
I have moved rle_bitmap_len =, width = etc. to a else-
multi-packet (if-block) or a single/first-packet (else-
But i agree with you, the patch looks very ugly. So here is a
new patch (with
hugohuetzel hugo.huet...@noid-project.de added the comment:
Ok, something went wrong with the text. Next try :-)
Sorry, but there are no cosmetic changes.
I have moved rle_bitmap_len =, width = etc. to a else-
single/first-packet (else-block)
But i agree with you, the patch looks very ugly.
hugohuetzel hugo.huet...@noid-project.de added the comment:
Sorry, but there are no cosmetic changes.
I have moved rle_bitmap_len =, width = etc. to a
else-block. So there is either a multi-packet (if-block)
or a single/first-packet (else-block)
hugohuetzel hugo.huet...@noid-project.de added the comment:
But i agree with you, the patch looks very ugly. So here is a
new patch (with removed/changed else-block for easier
reading)
_
FFmpeg issue tracker iss...@roundup.ffmpeg.org
Michael Niedermayer michae...@gmx.at added the comment:
On Thu, Jan 28, 2010 at 07:40:43PM +, hugohuetzel wrote:
[...]
@@ -166,21 +165,35 @@
sequence_desc = bytestream_get_byte(buf);
if (!(sequence_desc 0x80)) {
-av_log(avctx, AV_LOG_ERROR, Decoder does not support
12 matches
Mail list logo
