Re: [Firebird-devel] classes\InternalMessageBuffer.h

2014-04-08 Thread Dmitry Yemanov
09.04.2014 09:56, Alex wrote: > On 04/09/2014 10:14 AM, Claudio Valderrama C. wrote: >> Folks, sorry for nitpicking, but I don't like this alias in >> classes\InternalMessageBuffer.h: >> >> typedef Array Buffer; // May be it will become a class in the future, >> but now it is just a plain array >>

Re: [Firebird-devel] classes\InternalMessageBuffer.h

2014-04-08 Thread Alex
On 04/09/2014 10:14 AM, Claudio Valderrama C. wrote: > Folks, sorry for nitpicking, but I don't like this alias in > classes\InternalMessageBuffer.h: > > typedef Array Buffer; // May be it will become a class in the future, > but now it is just a plain array > > because "Buffer" is a name too gener

Re: [Firebird-devel] Implemented STEP for generators / sequences

2014-04-08 Thread Claudio Valderrama C.
> -Original Message- > From: Simonov Denis [mailto:sim-m...@list.ru] > Sent: Miércoles, 09 de Abril de 2014 1:27 > > Ability to specify the step for generators / sequences is > very good. But I > think the syntax would be much closer to the standard. So in > Oracle / MS > SQL / Post

[Firebird-devel] Implemented STEP for generators / sequences

2014-04-08 Thread Simonov Denis
Ability to specify the step for generators / sequences is very good. But I think the syntax would be much closer to the standard. So in Oracle / MS SQL / Postgresql step instructions for using the keyword INCREMENT BY instead STEP CREATE SEQUENCE name [INCREMENT [BY] increment] [MINVAL

[Firebird-devel] classes\InternalMessageBuffer.h

2014-04-08 Thread Claudio Valderrama C.
Folks, sorry for nitpicking, but I don't like this alias in classes\InternalMessageBuffer.h: typedef Array Buffer; // May be it will become a class in the future, but now it is just a plain array because "Buffer" is a name too general. It's not in a cpp, it's in a header included in other places.

Re: [Firebird-devel] User mapping changes

2014-04-08 Thread Alex
On 04/08/2014 11:41 PM, Leyne, Sean wrote: > >> Alex et al, >> >> May I ask to rethink namings, please? Things like RDB$MAP or >> /jrd/Mapping.cpp sound very confusing. What is mapped to what? Maybe >> Mapping.cpp is about memory mapped files? >> >> I'd suggest at least RDB$USER_MAP and UserMapping

Re: [Firebird-devel] User mapping changes

2014-04-08 Thread Leyne, Sean
> Alex et al, > > May I ask to rethink namings, please? Things like RDB$MAP or > /jrd/Mapping.cpp sound very confusing. What is mapped to what? Maybe > Mapping.cpp is about memory mapped files? > > I'd suggest at least RDB$USER_MAP and UserMapping.cpp instead. Maybe > someone else will have a b

[Firebird-devel] User mapping changes

2014-04-08 Thread Dmitry Yemanov
Alex et al, May I ask to rethink namings, please? Things like RDB$MAP or /jrd/Mapping.cpp sound very confusing. What is mapped to what? Maybe Mapping.cpp is about memory mapped files? I'd suggest at least RDB$USER_MAP and UserMapping.cpp instead. Maybe someone else will have a better suggestio

[Firebird-devel] [FB-Tracker] Created: (CORE-4387) IStatement::execute() and IAttachment::execute() functions should return on error pointer to old transaction interface

2014-04-08 Thread Alexander Peshkov (JIRA)
IStatement::execute() and IAttachment::execute() functions should return on error pointer to old transaction interface -- Key: CORE-4387 URL: http:

Re: [Firebird-devel] The problem when restoring from backup after the implementation of CORE-3370

2014-04-08 Thread Alex Peshkoff
On 04/05/14 16:44, Simonov Denis wrote: > The final assembly firebird 3.0.0.31021-0 found the following problems . > After the implementation of CORE- 3370 it became impossible to connect to > the database already created . Well here it is clear changed ODS, decided > to recreate the database from

Re: [Firebird-devel] Regression: system generator RDB$BACKUP_HISTORYcannot be modified

2014-04-08 Thread Alex Peshkoff
On 04/08/14 11:30, Claudio Valderrama C. wrote: >> -Original Message- >> From: Alex Peshkoff [mailto:peshk...@mail.ru] >> Sent: Lunes, 07 de Abril de 2014 11:53 >> >> Hi all! >> >> nbackup in trunk is broken: >> >> fbs bin # ./nbackup -b 0 employee l0.nbk >> [ >> PROBLEM ON "execute history

Re: [Firebird-devel] Regression: system generator RDB$BACKUP_HISTORY cannot be modified

2014-04-08 Thread Dmitry Yemanov
08.04.2014 11:54, Vlad Khorsun wrote: > Personally, i not consider it as important, > if nbackup v3 will not work with Firebird before v3... Me neither. But if it can be easily done, why not. Dmitry -- Put Bad Develop

Re: [Firebird-devel] Regression: system generator RDB$BACKUP_HISTORY cannot be modified

2014-04-08 Thread Vlad Khorsun
>> >> > Unfortunately, rdb$backup_history is the only sys gen >> >> that's not modified >> >> > from an internal request. >> >> >> >> Time to use triggers and INSERT RETURNING ? :) >> > >> > Or let VIO_store() handle rel_backup_history and do the >> generator increment >> > from set_metadat

Re: [Firebird-devel] Regression: systemgeneratorRDB$BACKUP_HISTORYcannot be modified

2014-04-08 Thread Claudio Valderrama C.
> -Original Message- > From: Vlad Khorsun [mailto:hv...@users.sourceforge.net] > Sent: Martes, 08 de Abril de 2014 3:06 > > >> > Unfortunately, rdb$backup_history is the only sys gen > >> that's not modified > >> > from an internal request. > >> > >> Time to use triggers and INSERT

Re: [Firebird-devel] Regression: system generatorRDB$BACKUP_HISTORYcannot be modified

2014-04-08 Thread Vlad Khorsun
>> > Unfortunately, rdb$backup_history is the only sys gen >> that's not modified >> > from an internal request. >> >> Time to use triggers and INSERT RETURNING ? :) > > Or let VIO_store() handle rel_backup_history and do the generator increment > from set_metadata_id(). Agree. Regard