Re: [Firebird-devel] YHelper and exceptions in constructor

2015-12-02 Thread Геннадий Забула
I think addRef should not be called using this->addRef. Only external owners can add refs. One more place where this->addRef exists it is /src/remote/remote.h#L1008. In all other places, addRef is called on private objects that the object owns. On 2 December 2015 at 19:19, Dimitry Sibiryakov wro

[Firebird-devel] YHelper and exceptions in constructor

2015-12-02 Thread Dimitry Sibiryakov
Hello, All. YHelper calls this->addRef() in constructor. But if the rest of the constructor throw anything, destructor is called automatically and die on assertion fb_assert(refCounter.value() == 0). Is it a design flaw? -- WBR, SD. ---

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Dimitry Sibiryakov
02.12.2015 17:18, Alex Peshkoff wrote: > Not sure what do you mean under > Firebird::exception - Firebird::status_exception or Firebird::Exception Firebird::Exception, of course which whole codebase is used to. -- WBR, SD. --

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Alex Peshkoff
On 12/02/2015 07:09 PM, Dimitry Sibiryakov wrote: > 02.12.2015 15:39, Alex Peshkoff wrote: >> For internal use in firebird another wrapper (working with >> status_exception) will be used, but it's not v.3 task. > Why you need another wrapper? Wouldn't be enough to typedef > Firebird::exception

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Dimitry Sibiryakov
02.12.2015 15:39, Alex Peshkoff wrote: > For internal use in firebird another wrapper (working with > status_exception) will be used, but it's not v.3 task. Why you need another wrapper? Wouldn't be enough to typedef Firebird::exception as FbException? -- WBR, SD. --

Re: [Firebird-devel] MasterImplementation::registerAttachment()

2015-12-02 Thread Adriano dos Santos Fernandes
On 02/12/2015 10:51, Dimitry Sibiryakov wrote: >Hello, All. > >What's the purpose of the subj? I don't see it to be called from anywhere > and IDL file > also has no comment about it. > $ grep -r registerAttachment src/ ... src/jrd/ExtEngineManager.cpp:externalAttachment = MasterInte

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Alex Peshkoff
On 12/02/2015 05:10 PM, Dimitry Sibiryakov wrote: > 02.12.2015 14:37, Alex Peshkoff wrote: >> Let me not describe trivial class here. > Ok, I got it: for end-user applications only and (to be precise) plugins > , cannot be used in any part of Firebird > itself. > For internal use in firebird

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Dimitry Sibiryakov
02.12.2015 14:37, Alex Peshkoff wrote: > Let me not describe trivial class here. Ok, I got it: for end-user applications only, cannot be used in any part of Firebird itself. -- WBR, SD. -- Go from Idea to Many A

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Alex Peshkoff
On 12/02/2015 04:22 PM, Dimitry Sibiryakov wrote: > 02.12.2015 14:17, Alex Peshkoff wrote: >> Internally we do not use ThrowStatusWrapper (except UDR plugin). > I know. That's why the question: what is it for and how/where can be used? > Sample of it's use is in examples/interfaces/*.cpp. Let

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Dimitry Sibiryakov
02.12.2015 14:17, Alex Peshkoff wrote: > Internally we do not use ThrowStatusWrapper (except UDR plugin). I know. That's why the question: what is it for and how/where can be used? -- WBR, SD. -- Go from Idea to M

Re: [Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Alex Peshkoff
On 12/02/2015 04:09 PM, Dimitry Sibiryakov wrote: > Hello, All. > > Subj throws FbException, but everywhere in code Firebird::exception is > being caught. > How it is supposed to work? > Internally we do not use ThrowStatusWrapper (except UDR plugin). ---

[Firebird-devel] ThrowStatusWrapper

2015-12-02 Thread Dimitry Sibiryakov
Hello, All. Subj throws FbException, but everywhere in code Firebird::exception is being caught. How it is supposed to work? -- WBR, SD. -- Go from Idea to Many App Stores Faster with Intel(R) XDK Give your u

[Firebird-devel] MasterImplementation::registerAttachment()

2015-12-02 Thread Dimitry Sibiryakov
Hello, All. What's the purpose of the subj? I don't see it to be called from anywhere and IDL file also has no comment about it. -- WBR, SD. -- Go from Idea to Many App Stores Faster with Intel(R) XDK Give yo