Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Dmitry Yemanov
01.02.2018 20:24, Mark Rotteveel wrote: Point taken, but my suggestion was more that we now don't utilize the Decimal128 to its fullest for decimal, and users of the direct API now need to handle decfloat and decimal(19+, x) in a very different manner even though the underlying datatype is the

[Firebird-devel] [FB-Tracker] Created: (CORE-5736) Trace: add hash value for text of every executed statement

2018-02-01 Thread Pavel Zotov (JIRA)
Trace: add hash value for text of every executed statement -- Key: CORE-5736 URL: http://tracker.firebirdsql.org/browse/CORE-5736 Project: Firebird Core Issue Type: Improvement

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Mark Rotteveel
On 2018-02-01 17:43, Dimitry Sibiryakov wrote: 01.02.2018 16:30, Alex Peshkoff via Firebird-devel wrote: Point taken, but my suggestion was more that we now don't utilize the Decimal128 to its fullest for decimal, and users of the direct API now need to handle decfloat and decimal(19+, x) in a

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Dimitry Sibiryakov
01.02.2018 17:04, Mark Rotteveel wrote: Let me try to rephrase: for DECFLOAT we use Decimal128 which includes the correct scale, and for DECIMAL(19+) we use Decimal128 with a scale of zero, and the correct scale communicated externally, which then needs to be applied separately. That to me as

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Dimitry Sibiryakov
01.02.2018 16:30, Alex Peshkoff via Firebird-devel wrote: Point taken, but my suggestion was more that we now don't utilize the Decimal128 to its fullest for decimal, and users of the direct API now need to handle decfloat and decimal(19+, x) in a very different manner even though the underlying

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Adriano dos Santos Fernandes
On 01/02/2018 14:04, Mark Rotteveel wrote: > On 1-2-2018 16:30, Alex Peshkoff via Firebird-devel wrote: >>> Point taken, but my suggestion was more that we now don't utilize >>> the Decimal128 to its fullest for decimal, and users of the direct >>> API now need to handle decfloat and decimal(19+, x

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Mark Rotteveel
On 1-2-2018 16:30, Alex Peshkoff via Firebird-devel wrote: Point taken, but my suggestion was more that we now don't utilize the Decimal128 to its fullest for decimal, and users of the direct API now need to handle decfloat and decimal(19+, x) in a very different manner even though the underlyi

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Alex Peshkoff via Firebird-devel
On 02/01/18 15:31, Mark Rotteveel wrote: On 29-1-2018 10:45, Alex Peshkoff via Firebird-devel wrote: May be taken standalone your suggestion is simpler but in conjunction with existing logic for numerics based on bigint and smaller integer values and need to cast between them use of existing im

[Firebird-devel] FLOAT(p) documented feature?

2018-02-01 Thread Mark Rotteveel
Firebird allows you to specify a precision with FLOAT(p), where 0-7 gives you a 32 bit single precision (aka REAL), and 8 and higher gives you a double precision. In other words, the precision is interpreted as (approximate) decimal digits. Is this documented and 'supported' behavior? It isn't

[Firebird-devel] [FB-Tracker] Created: (CORE-5735) Additional keyholder opens unauthorized connections to encrypted database

2018-02-01 Thread Alexander Peshkov (JIRA)
Additional keyholder opens unauthorized connections to encrypted database - Key: CORE-5735 URL: http://tracker.firebirdsql.org/browse/CORE-5735 Project: Firebird Core Is

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Mark Rotteveel
On 1-2-2018 12:49, Dimitry Sibiryakov wrote: 01.02.2018 12:44, Mark Rotteveel wrote: On 27-1-2018 19:30, Dmitry Yemanov wrote: 27.01.2018 20:18, Mark Rotteveel wrote: I'm implementing the new precision 34 decimal/numeric support in Jaybird, and I notice that the underlying Decimal128 is used

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Mark Rotteveel
On 29-1-2018 10:45, Alex Peshkoff via Firebird-devel wrote: May be taken standalone your suggestion is simpler but in conjunction with existing logic for numerics based on bigint and smaller integer values and need to cast between them use of existing impelmentation appeared to me simpler. I

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Dimitry Sibiryakov
01.02.2018 12:44, Mark Rotteveel wrote: On 27-1-2018 19:30, Dmitry Yemanov wrote: 27.01.2018 20:18, Mark Rotteveel wrote: I'm implementing the new precision 34 decimal/numeric support in Jaybird, and I notice that the underlying Decimal128 is used as just an integer container, instead of alrea

Re: [Firebird-devel] DEC_FIXED implementation, Decimal128 is unscaled?

2018-02-01 Thread Mark Rotteveel
On 27-1-2018 19:30, Dmitry Yemanov wrote: 27.01.2018 20:18, Mark Rotteveel wrote: I'm implementing the new precision 34 decimal/numeric support in Jaybird, and I notice that the underlying Decimal128 is used as just an integer container, instead of already applying an appropriate exponent for

[Firebird-devel] [FB-Tracker] Created: (CORE-5734) Enforce maximum precision on float

2018-02-01 Thread Mark Rotteveel (JIRA)
Enforce maximum precision on float -- Key: CORE-5734 URL: http://tracker.firebirdsql.org/browse/CORE-5734 Project: Firebird Core Issue Type: Bug Components: Engine Affects Versions: 2.5.8, 4.0 Al

[Firebird-devel] [FB-Tracker] Created: (CORE-5733) Disallow precision 0 on FLOAT

2018-02-01 Thread Mark Rotteveel (JIRA)
Disallow precision 0 on FLOAT - Key: CORE-5733 URL: http://tracker.firebirdsql.org/browse/CORE-5733 Project: Firebird Core Issue Type: Bug Components: Engine Affects Versions: 2.5.8, 4.0 Alpha 1, 3.0