Re: [Firebird-devel] [PATCH] Cobol interface

19.12.2014 10:05, Alexpux wrote: > > Next patch works for me. Applied. Dmitry -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboard

Re: [Firebird-devel] [PATCH] Cobol interface

> 19 дек. 2014 г., в 11:41, Dmitry Yemanov написал(а): > > 19.12.2014 11:34, Alexpux wrote: >> >> Looking into Cobol module I see there are lot of this such things. Also >> maybe need there replace deprecated procedures like «isc_interprete». > > IIRC, Cobol support exists for 32-bits only, s

Re: [Firebird-devel] [PATCH] Cobol interface

19.12.2014 11:34, Alexpux wrote: > > Looking into Cobol module I see there are lot of this such things. Also maybe > need there replace deprecated procedures like «isc_interprete». IIRC, Cobol support exists for 32-bits only, so all these issues are just annoying warnings that never appear in pr

Re: [Firebird-devel] [PATCH] Cobol interface

> 19 дек. 2014 г., в 11:14, Dmitry Yemanov написал(а): > > 19.12.2014 10:05, Alexpux wrote: >> >> Next patch works for me. > > Doesn't this routine also need fixing: > > EXPORT RM_ENTRY(rmc_baddress) > { > U_IPTR retval = isc_baddress((char *)arg_vector[0].a_address); > *(ISC_ULON

Re: [Firebird-devel] [PATCH] Cobol interface

19.12.2014 10:05, Alexpux wrote: > > Next patch works for me. Doesn't this routine also need fixing: EXPORT RM_ENTRY(rmc_baddress) { U_IPTR retval = isc_baddress((char *)arg_vector[0].a_address); *(ISC_ULONG *)arg_vector[-1].a_address = retval; return (0); } to become:

Re: [Firebird-devel] [PATCH] Cobol interface

> 18 дек. 2014 г., в 11:18, Dmitry Yemanov написал(а): > > 18.12.2014 11:04, Alexey Pavlov wrote: >> >> 2014-12-18 10:53 GMT+03:00 Dmitry Yemanov > >: >> >>18.12.2014 10:47, Alexey Pavlov wrote: >> >>> -*(ISC_ULONG *)arg_vector[-1].a_address = (ISC_ULONG)p; >>>

Re: [Firebird-devel] [PATCH] Cobol interface

18.12.2014 11:04, Alexey Pavlov wrote: > > 2014-12-18 10:53 GMT+03:00 Dmitry Yemanov >: > > 18.12.2014 10:47, Alexey Pavlov wrote: > > > -*(ISC_ULONG *)arg_vector[-1].a_address = (ISC_ULONG)p; > > - > > +*(uintptr_t *)arg_vector[-1].a_address = (uintp

Re: [Firebird-devel] [PATCH] Cobol interface

2014-12-18 11:04 GMT+03:00 Alexey Pavlov : > > > > 2014-12-18 10:53 GMT+03:00 Dmitry Yemanov : >> >> 18.12.2014 10:47, Alexey Pavlov wrote: >> >> > -*(ISC_ULONG *)arg_vector[-1].a_address = (ISC_ULONG)p; >> > - >> > +*(uintptr_t *)arg_vector[-1].a_address = (uintptr_t)p; >> >> So far our practice i

Re: [Firebird-devel] [PATCH] Cobol interface

2014-12-18 10:53 GMT+03:00 Dmitry Yemanov : > > 18.12.2014 10:47, Alexey Pavlov wrote: > > > -*(ISC_ULONG *)arg_vector[-1].a_address = (ISC_ULONG)p; > > - > > +*(uintptr_t *)arg_vector[-1].a_address = (uintptr_t)p; > > So far our practice is to favor FB-specific typedefs instead of system > ones. U

Re: [Firebird-devel] [PATCH] Cobol interface

18.12.2014 10:47, Alexey Pavlov wrote: > -*(ISC_ULONG *)arg_vector[-1].a_address = (ISC_ULONG)p; > - > +*(uintptr_t *)arg_vector[-1].a_address = (uintptr_t)p; So far our practice is to favor FB-specific typedefs instead of system ones. U_IPTR should be used here instead of uintptr_t. Dmitry

[Firebird-devel] [PATCH] Cobol interface

>From 04e29d51b1067a6c532eba160bb675515006ab47 Mon Sep 17 00:00:00 2001 From: Alexpux Date: Thu, 18 Dec 2014 10:23:11 +0300 Subject: [PATCH] Cobol interface: fix warnings and cast error. --- src/gpre/languages/fbrmclib.cpp | 19 + 1 file changed, 9 insertions(+), 10 deletions