Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Roman Simakov
2018-02-20 15:43 GMT+03:00 Alex Peshkoff via Firebird-devel : > On 02/20/18 15:39, Roman Simakov wrote: >> In this case it's a bug right? >> > > yes http://tracker.firebirdsql.org/browse/CORE-5755 -- Roman Simakov -- C

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Alex Peshkoff via Firebird-devel
On 02/20/18 15:39, Roman Simakov wrote: 2018-02-20 15:27 GMT+03:00 Alex Peshkoff via Firebird-devel : Always requiring object type is best of possible solutions but I'm afraid that's unreal. I've supposed missing keyword, i.e. real failing statement is: grant select on t to FUNCTION wrong_func

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Roman Simakov
2018-02-20 15:27 GMT+03:00 Alex Peshkoff via Firebird-devel : > Always requiring object type is best of possible solutions but I'm afraid > that's unreal. > > I've supposed missing keyword, i.e. real failing statement is: > > grant select on t to FUNCTION wrong_func; > > Roman - am I wrong? Right.

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Alex Peshkoff via Firebird-devel
On 02/20/18 15:19, Dimitry Sibiryakov wrote: 20.02.2018 13:14, Alex Peshkoff via Firebird-devel wrote: 2) We have no check of existance a subjects of privileges. I.e. SQL> create table t(i integer); SQL> grant select on t to wrong_func; SQL> show function wrong_func; There is no user-defined fun

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Dimitry Sibiryakov
20.02.2018 13:14, Alex Peshkoff via Firebird-devel wrote: 2) We have no check of existance a subjects of privileges. I.e. SQL> create table t(i integer); SQL> grant select on t to wrong_func; SQL> show function wrong_func; There is no user-defined function WRONG_FUNC in this database I tend to c

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Alex Peshkoff via Firebird-devel
On 02/20/18 14:55, Roman Simakov wrote: Hello! I fixed several bugs related to GRANT operator and investigated a couple of issues I'd like to discuss: 1) Replace RDB$TRIGGER_9 (trigger1 in trig.h) by code in DdlNodes.epp with the same functions. I already did it in CORE-5747 to check grant optio

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Alex Peshkoff via Firebird-devel
  I don't know if in currently user's existence can be checked via SEC$USERS. Sooner of all no. SEC$USERS shows only users in security database, we can't check for win_sspi. And even if we learn all plugins to list users that check does not make big sense - we can't ensure that user grante

Re: [Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Dimitry Sibiryakov
20.02.2018 12:55, Roman Simakov wrote: 2) We have no check of existance a subjects of privileges. I.e. SQL> create table t(i integer); SQL> grant select on t to wrong_func; SQL> show function wrong_func; There is no user-defined function WRONG_FUNC in this database I tend to consider it as a bug

[Firebird-devel] Existing a subject of privileges and refactoring

2018-02-20 Thread Roman Simakov
Hello! I fixed several bugs related to GRANT operator and investigated a couple of issues I'd like to discuss: 1) Replace RDB$TRIGGER_9 (trigger1 in trig.h) by code in DdlNodes.epp with the same functions. I already did it in CORE-5747 to check grant option. We can do it since we remove direct mod