Re: [Firebird-devel] exception handling in firebird.pas

2018-05-03 Thread Adriano dos Santos Fernandes
On 03/05/2018 07:35, Adriano dos Santos Fernandes wrote: > The problem is here: > > I mean, status could be checked for being nil, but in the end, this routine probably is never called in this situation. Adriano -- Chec

Re: [Firebird-devel] exception handling in firebird.pas

2018-05-03 Thread Adriano dos Santos Fernandes
On 30/04/2018 05:20, Mark Rotteveel wrote: > On 30-4-2018 09:52, fbbt wrote: >> 3. Maybe we need to put a sample of firebird.pas at github. It will >> allow other developers to patch it in more productive way than now. > > As I understand it, firebird.pas is generated by Cloop, so allowing > people

Re: [Firebird-devel] exception handling in firebird.pas

2018-05-03 Thread Tony Whyman
Perhaps worth noting that the version of Firebird.pas distributed with IBX for Lazarus is patched with many changes. See https://svn.mwasoftware.co.uk/viewvc/public/ibx/trunk/fbintf/client/3.0/firebird/Firebird.pas?revision=209&view=markup This is: 1. To comment out all exception handling. Thi

Re: [Firebird-devel] exception handling in firebird.pas

2018-05-03 Thread Alex Peshkoff via Firebird-devel
On 04/30/18 11:20, Mark Rotteveel wrote: On 30-4-2018 09:52, fbbt wrote: 3. Maybe we need to put a sample of firebird.pas at github. It will allow other developers to patch it in more productive way than now. As I understand it, firebird.pas is generated by Cloop, so allowing people to patch

Re: [Firebird-devel] exception handling in firebird.pas

2018-05-02 Thread fbbt
1. Place firebird.pas (for all FB releases) to official repository at GitHub. This is a one of the first places where it is expected to be found. 2. - firebird.pas for 3.0.0 is not the same as firebird.pas for 3.0.1 - firebird.pas for 3.0.1 is not the same as firebird.pas for 3.0.2 - firebird.pas

Re: [Firebird-devel] exception handling in firebird.pas

2018-05-02 Thread Mark Rotteveel
On 30-4-2018 09:52, fbbt wrote: 3. Maybe we need to put a sample of firebird.pas at github. It will allow other developers to patch it in more productive way than now. As I understand it, firebird.pas is generated by Cloop, so allowing people to patch it would be against the intent. The probl

[Firebird-devel] exception handling in firebird.pas

2018-04-30 Thread fbbt
1. Any call to FbException.catchException(nil, e) will raise Access Violation in catchException procedure. function IUdrPluginImpl_getMasterDispatcher(this: IUdrPlugin): IMaster; cdecl; begin try Result := IUdrPluginImpl(this).getMaster(); except on e: Exception do FbException.catchEx