Re: [Firebird-net-provider] FbCommand sql parser

2009-04-12 Thread Jiri Cincura
On Wed, Apr 8, 2009 at 19:13, Gareth wrote: > Thanks for the response, I have been away for a while. > > Bug fixed, here is fixed procedure. This looks better. I'll put it into sources after 2.5 final will be released. -- Jiri {x2} Cincura (CTO x2develop.com) http://blog.vyvojar.cz/jirka/ | htt

Re: [Firebird-net-provider] FbCommand sql parser

2009-04-08 Thread Gareth
Thanks for the response, I have been away for a while. Bug fixed, here is fixed procedure. public string ParseNamedParameters(string sql) { // Clear old parameters. this.namedParameters.Clear(); // We do not need to parse if there are no parameters.

Re: [Firebird-net-provider] FbCommand sql parser

2009-03-21 Thread Jiri Cincura
On Tue, Mar 3, 2009 at 23:43, Gareth wrote: > This method runs faster than the current one, it does not strip > anything except "@PARAMETER" text to "?" and there are not alot of > booleans. > > If you think this is ok, I will add a patch to DNET-176. Hi, sorry for taking long time to respond.

Re: [Firebird-net-provider] FbCommand sql parser

2009-03-03 Thread Gareth
This parse method seems ok, I have run all of the client unit tests with it and some of my own. p.s. DNET-217 patch caused unit test errors in Version10\GdsStatement, I used the prior version to run the tests. This method runs faster than the current one, it does not strip anything except "@PARAME

Re: [Firebird-net-provider] FbCommand sql parser

2009-02-26 Thread Jiri Cincura
On Wed, Feb 25, 2009 at 23:10, Gareth wrote: > It removes single line comments "-- " and block comments "/* */". You shouldn't remove anything from command text. Maybe somebody is logging it etc. > It replaces tabs, newlines, carriage returns and multiple spaces with > a single space. Same as a

[Firebird-net-provider] FbCommand sql parser

2009-02-25 Thread Gareth
I have created a new sql parser method for the FbCommand. It removes single line comments "-- " and block comments "/* */". It replaces tabs, newlines, carriage returns and multiple spaces with a single space. It also extracts the parameter names. Has anyone got any comments ? -- Gareth