Re: [flac-dev] [PATCH] Fix make distcheck

2012-04-06 Thread Erik de Castro Lopo
Cristian Rodríguez wrote: > Otherwise will fail like: > https://mf4.xiph.org/jenkins/job/flac/lastUnsuccessfulBuild/console Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ _

Re: [flac-dev] [PATCH] Fix buffer overflow in metaflac

2012-04-06 Thread Erik de Castro Lopo
Earl Chew wrote: > It would really be better to compare against sizeof(application_id) > rather than coupling to all these instances of 4 all over the place. Agreed. Fix commited. Erik -- -- Erik de Castro Lopo http://www.mega-

Re: [flac-dev] [PATCH] Fix buffer overflow in metaflac

2012-04-06 Thread Earl Chew
It would really be better to compare against sizeof(application_id) rather than coupling to all these instances of 4 all over the place. From: Erik de Castro Lopo To: flac-dev@xiph.org Sent: Thursday, April 5, 2012 4:02:10 AM Subject: Re: [flac-dev] [PATCH] F

[flac-dev] [PATCH] Fix make distcheck

2012-04-06 Thread Cristian Rodríguez
Otherwise will fail like: https://mf4.xiph.org/jenkins/job/flac/lastUnsuccessfulBuild/console --- src/libFLAC/include/private/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/src/libFLAC/include/private/Makefile.am b/src/libFLAC/include/private/Makefile.am index 62d8a18..2e33dc7

Re: [flac-dev] Anyone using Makefile.lite?

2012-04-06 Thread Cristian Rodríguez
El 05/04/12 23:58, Erik de Castro Lopo escribió: > Erik de Castro Lopo wrote: > >> Hi all, >> >> I hadn't really noticed the Makefile.lites scattered throughout >> the sources. Is anyone using these? I'm really tempted to just >> remove them all. > > These Makefile.lite makefiles are currently brok