Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-03 Thread Ralph Giles
On 13-03-02 3:22 PM, Erik de Castro Lopo wrote: > http://downloads.xiph.org/releases/flac/beta/ On Mac 10.7.5 Apple clang 4.2, 'make check' fails because BSD and GNU coreutils have incompatible format options for 'stat'. If I change test/test_compression.sh to use: size=`stat -f "%z" ${fn

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Erik de Castro Lopo
Ben Allison wrote: > >> * change instances of uint32_t in bitwriter.c to FLAC__uint32 > > > > Can we include to fix this instead? > > Sadly there is no inttypes.h on MSVC. At least versions to Visual Studio > 2010. I presume this is why ordinal.h was created in the first place. I'm not sure h

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Ben Allison
>> * change instances of uint32_t in bitwriter.c to FLAC__uint32 > > Can we include to fix this instead? Sadly there is no inttypes.h on MSVC. At least versions to Visual Studio 2010. I presume this is why ordinal.h was created in the first place. I'll use the compat.h header for the __inline

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Erik de Castro Lopo
Ben Allison wrote: > There's a more few issues for compiling on MSVC. I put together a patch. > > Here's a quick rundown: > * must use __inline keyword with static inline functions (bitmath.h) If you include "share/compath.h" you will get a inline #defined as __inline when _MSC_VER is defined.

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Ben Allison
There's a more few issues for compiling on MSVC. I put together a patch. Here's a quick rundown: * must use __inline keyword with static inline functions (bitmath.h) * change instances of uint32_t in bitwriter.c to FLAC__uint32 * functions marked inline cannot be used within another C file (e.g.

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Erik de Castro Lopo
Ben Allison wrote: > Visual Studio files (which don't use config.h, but define various things > in the project settings) are compiling with the wrong FLAC version string > (1.2.0 or 1.2.1) Is there really no other way to set the version string? > I've attached the patch. Thanks. I'm wondering i

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Ben Allison
Visual Studio files (which don't use config.h, but define various things in the project settings) are compiling with the wrong FLAC version string (1.2.0 or 1.2.1) I've attached the patch. Maintaining Visual Studio project files in a cross-platform open-source project tends to be a pain unless on

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Erik de Castro Lopo
Johnny Rosenberg wrote: > Maybe a stupid question, but I was born stupid and I have walked that > path ever since, so: Is there a changelog? The only changelog is the git changelog. I will be writing a real changelog to go in the actual release tarball before the official release. The git change

[flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-03 Thread Johnny Rosenberg
I don't know how it happened, but I accidently sent the message below privately and not to the list. Maybe a result of my built in stupidity. -- Forwarded message -- From: Johnny Rosenberg Date: 2013/3/3 Subject: Re: [flac-dev] flac 1.3.0pre1 prelease To: Cristian Rodríguez 20