Re: [flac-dev] [PATCH] Change test scripts shell to bash, to avoid lack of arithmetic support in dash, which is sh on Ubuntu 10.04

2013-03-19 Thread Erik de Castro Lopo
Jaren Stangret wrote: > Erik, > > I was thinking of doing this: > export MALLOC_PERTURB_=$(awk 'BEGIN { srand(); print int(rand() * 32767 % > 255 + 1) }') > > Or would you prefer using 'date'? Your's is probably better and this is probably an improvement: awk 'BEGIN { srand(); print int(ra

Re: [flac-dev] [PATCH] Change test scripts shell to bash, to avoid lack of arithmetic support in dash, which is sh on Ubuntu 10.04

2013-03-19 Thread Jaren Stangret
Which I think srand actually uses 'date' as it's seed in this case... On Tue, Mar 19, 2013 at 10:29 PM, Jaren Stangret wrote: > Erik, > > I was thinking of doing this: > export MALLOC_PERTURB_=$(awk 'BEGIN { srand(); print int(rand() * 32767 % > 255 + 1) }') > > Or would you prefer using 'date'

Re: [flac-dev] [PATCH] Change test scripts shell to bash, to avoid lack of arithmetic support in dash, which is sh on Ubuntu 10.04

2013-03-19 Thread Jaren Stangret
Erik, I was thinking of doing this: export MALLOC_PERTURB_=$(awk 'BEGIN { srand(); print int(rand() * 32767 % 255 + 1) }') Or would you prefer using 'date'? On Tue, Mar 19, 2013 at 10:22 PM, Erik de Castro Lopo wrote: > Jesse Weinstein wrote: > > > The subject line mostly says it all, but for

Re: [flac-dev] [PATCH] Change test scripts shell to bash, to avoid lack of arithmetic support in dash, which is sh on Ubuntu 10.04

2013-03-19 Thread Erik de Castro Lopo
Jesse Weinstein wrote: > The subject line mostly says it all, but for reference, having #!/bin/sh > causes the following error: > > arithmetic expression: expecting primary: " % 255 + 1" Arithmetic support is actually not the issue, rather its that dash/sh doesn't support $RANDOM. The solution

[flac-dev] Failing case00a test (was Re: flac 1.3.0pre2 pre-release)

2013-03-19 Thread Jesse Weinstein
On Ubuntu 10.04.4 LTS, with default options (i.e. fresh checkout of HEAD : 93c12c784ad0337f665c647d5378ea4c67d63fe4 , autogen.sh && ./configure && make) I get the exact same error when running (cd test && ./test_flac.sh ). I know Erik has already confirmed this, but I thought I might as well add m

[flac-dev] [PATCH] Change test scripts shell to bash, to avoid lack of arithmetic support in dash, which is sh on Ubuntu 10.04

2013-03-19 Thread Jesse Weinstein
The subject line mostly says it all, but for reference, having #!/bin/sh causes the following error: arithmetic expression: expecting primary: " % 255 + 1" --- test/test_flac.sh|2 +- test/test_grabbag.sh |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/tes

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-19 Thread JonY
On 3/20/2013 00:35, Janne Hyvärinen wrote: >> >> As for calling __wgetmainargs, I have some concerns about the security >> implications: >> LoadLibrary("msvcrt.dll") <- Which msvcrt? Theoretical security exploit. > > There is msvcrt.dll in the System32 dir in all supported Windows > systems. That

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-19 Thread LRN
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19.03.2013 20:35, Janne Hyvärinen wrote: > > On 19.3.2013 15:49, JonY wrote: >> On 3/19/2013 19:59, Janne Hyvärinen wrote: >>> On 18.3.2013 12:25, Erik de Castro Lopo wrote: JonY wrote: > Before anyone does anything, see __wgetmainar

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-19 Thread Janne Hyvärinen
On 19.3.2013 15:49, JonY wrote: > On 3/19/2013 19:59, Janne Hyvärinen wrote: >> On 18.3.2013 12:25, Erik de Castro Lopo wrote: >>> JonY wrote: >>> Before anyone does anything, see __wgetmainargs . It can expand wildcards. S

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-19 Thread JonY
On 3/19/2013 19:59, Janne Hyvärinen wrote: > On 18.3.2013 12:25, Erik de Castro Lopo wrote: >> JonY wrote: >> >>> Before anyone does anything, see __wgetmainargs >>> . >>> >>> It can expand wildcards. Since it already provides argc/argv/env, it

Re: [flac-dev] flac 1.3.0pre2 pre-release

2013-03-19 Thread Erik de Castro Lopo
Jaren Stangret wrote: > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 > > Anyone else hitting this or is just my system?