On 25-04-13 05:30, Erik de Castro Lopo wrote:
> The problem is that the failure in the awk script isn't recognised as
> a failure in the shell script.
No, really, it's not only that. With the fixed git, I get this when I
change one of the expected values to something else:
> [...]
> Testing FLAC
Erik de Castro Lopo wrote:
> Martijn van Beurden wrote:
>
> > On 24-04-13 14:34, Erik de Castro Lopo wrote:
> > > That's an error in the awk script, which is embedded in the shell
> > > script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
> > > investigate that futher.
> >
> >
Martijn van Beurden wrote:
> On 24-04-13 14:34, Erik de Castro Lopo wrote:
> > That's an error in the awk script, which is embedded in the shell
> > script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
> > investigate that futher.
>
> On my system awk links to mawk 1.3.3
Yep fa
Janne Hyvärinen wrote:
> Changing it to #define PPR if(filename) { if(raw) {
> printf("%s:",filename); } else { flac_printf("%s:",filename); } }
Thanks. Applied.
> makes GCC happy.
Its really about more than making GCC happy. The if statement
was genuinely an ambiguous compile. See the 'Dangli
On 24-04-13 14:34, Erik de Castro Lopo wrote:
> That's an error in the awk script, which is embedded in the shell
> script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
> investigate that futher.
On my system awk links to mawk 1.3.3
>> I don't know why, but the test continues an
On 24.4.2013 15:42, Erik de Castro Lopo wrote:
> Janne Hyvärinen wrote:
>
>> +#define PPR if(filename) if(raw) printf("%s:",filename); else
>> flac_printf("%s:",filename);
> Are you sure about that line?
>
> GCC complains about an ambiguous 'else'. It definitely needs some
> curly braces somewher
Janne Hyvärinen wrote:
> +#define PPR if(filename) if(raw) printf("%s:",filename); else
> flac_printf("%s:",filename);
Are you sure about that line?
GCC complains about an ambiguous 'else'. It definitely needs some
curly braces somewhere there to make the intend explicit.
Cheers,
Erik
--
Martijn van Beurden wrote:
> I was running make fullcheck when I found something weird. After editing
> the *expect.meta files , make fullcheck ran all tests and said "All
> tests passed", but the output included this (this is the last tests from
> test_metaflac.sh)
>
> > [...]
> > test case60
