[flac-dev] extend visibility attributes usage to osx builds

2014-05-25 Thread Ozkan Sezer
The attached small configury patch extends visibility attributes usage to darwin (osx) builds. Tested by cross-compiling on a linux host using gcc-.4.0.2 and gcc-4.2.1 against 10.4 and 10.6 SDKs. Regards. -- O.S. diff --git a/configure.ac b/configure.ac index 6d0fa00..d3c302a 100644 ---

[flac-dev] replace -Wextra with -W

2014-05-25 Thread Ozkan Sezer
The attached small configury patch replaces -Wextra with -W in the main CFLAGS and CXXFLAGS assignments. A few lines after them, -Wextra is conditionally added already with XIPH_ADD_CFLAGS([-Wextra]), so this allows build using older compilers. Regards. -- O.S. diff --git a/configure.ac

Re: [flac-dev] extend visibility attributes usage to osx builds

2014-05-25 Thread Ozkan Sezer
On 5/25/14, Erik de Castro Lopo mle...@mega-nerd.com wrote: Ozkan Sezer wrote: The attached small configury patch extends visibility attributes usage to darwin (osx) builds. Tested by cross-compiling on a linux host using gcc-.4.0.2 and gcc-4.2.1 against 10.4 and 10.6 SDKs. Thanks Ozkan,

Re: [flac-dev] make dllimport/dllexport attributes work with mingw (and others)

2014-05-25 Thread lvqcl
Erik de Castro Lopo wrote: Ozkan Sezer wrote: My apologies, obviously sent an old testing patch. Correct one is attached (declspec2.diff). Compilation tested using MinGW (gcc-3.4.5, binutils-2.20), and MinGW-w64 (gcc-4.5.4, binutils-2.21.90.) lvqcl, Can you please validate this new

Re: [flac-dev] make dllimport/dllexport attributes work with mingw (and others)

2014-05-25 Thread lvqcl
Ozkan Sezer wrote: flac.exe built with mingw with or without the dllimport/dllexport patch always requires libFLAC-8.dll (because flac/Makefile.am has libFLAC.la in flac_LDADD and not libFLAC-static.la), and the patch doesn't make it any more or any less dependent on any 'foreign' dlls: the

Re: [flac-dev] make dllimport/dllexport attributes work with mingw (and others)

2014-05-25 Thread Ozkan Sezer
On 5/25/14, lvqcl lvqcl.m...@gmail.com wrote: Ozkan Sezer wrote: flac.exe built with mingw with or without the dllimport/dllexport patch always requires libFLAC-8.dll (because flac/Makefile.am has libFLAC.la in flac_LDADD and not libFLAC-static.la), and the patch doesn't make it any more or

Re: [flac-dev] XIPH_C_COMPILER_IS_CLANG preventing many flags

2014-05-25 Thread Erik de Castro Lopo
Ozkan Sezer wrote: XIPH_C_COMPILER_IS_CLANG in configury (commit a6a4b6f) is blocking many flags including the visibility attributes: I guess this needs relaxing, possibly a lot. What incompatibility led to this commit? The differences between GCC and Clang actually arose in the libsndfile

Re: [flac-dev] XIPH_C_COMPILER_IS_CLANG preventing many flags

2014-05-25 Thread Ozkan Sezer
On 5/25/14, Erik de Castro Lopo mle...@mega-nerd.com wrote: Ozkan Sezer wrote: XIPH_C_COMPILER_IS_CLANG in configury (commit a6a4b6f) is blocking many flags including the visibility attributes: I guess this needs relaxing, possibly a lot. What incompatibility led to this commit? The