Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-05-02 Thread Earl Chew
Josh, Sure. I can try. Would you give me a more detailed description of the requirement ? What exactly does "general MM:SS handling" mean ? Earl From: Josh Coalson To: Earl Chew ; "flac-dev@xiph.org" Sent: Tuesday, May 1, 2012 8:

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-04-26 Thread Earl Chew
heet.c to allow metaflac_test.sh to run to completion I haven't checked git yet but I hope this patch has not gone in.  I don't like the special case that this is creating. It would be better to allow MM:SS everywhere but I consider that low priority. >____ >

Re: [flac-dev] [PATCH] Fix buffer overflow in metaflac

2012-04-06 Thread Earl Chew
It would really be better to compare against sizeof(application_id) rather than coupling to all these instances of 4 all over the place. From: Erik de Castro Lopo To: flac-dev@xiph.org Sent: Thursday, April 5, 2012 4:02:10 AM Subject: Re: [flac-dev] [PATCH] F

Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-03-18 Thread Earl Chew
Erik, Thanks for the update. It certainly was a strange problem to debug. Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Sunday, March 18, 2012 1:36:42 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-03-18 Thread Earl Chew
and send it to me directly ? I am using: dash.i686    0.5.5.1-3.fc12 bash.i686    4.0.33-1.fc12 Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Tuesday, March 13, 2012 12:43:11 PM Subject: Re: [flac-dev] PATCH: Add test for

Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-03-13 Thread Earl Chew
From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Sunday, March 11, 2012 3:16:11 AM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote: > There is only one test to verify handling of harmonics of the filter table > sampling fr

Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-03-13 Thread Earl Chew
Sigh ... curiouser and curiouser ... From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Monday, March 12, 2012 1:36:23 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain Earl Chew wrote: > I suspect /bin/sh be

Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-03-12 Thread Earl Chew
Erik, I suspect /bin/sh being dash is what is causing the problem. I will rework the syntax. Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Sunday, March 11, 2012 10:59:50 PM Subject: Re: [flac-dev] PATCH: Add test for metaflac

Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-03-11 Thread Earl Chew
Erik, I'm using bash.  Before I alter the syntax, what shell are you using ? Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Sunday, March 11, 2012 3:16:11 AM Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay

[flac-dev] [PATCH] Support 56kHz to 19.2kHz gain analysis (Patch v4)

2012-02-26 Thread Earl Chew
Because these filter coefficients can be generated from a known source, they are preferred to the FooBar2000 coefficients whose provenance is unknown. Signed-off-by: Earl Chew 0001-Support-56kHz-to-19.2kHz-gain-analysis-Patch-v4.patch Description: Binary data

[flac-dev] R128Gain

2012-02-26 Thread Earl Chew
I came across:  http://www.hydrogenaudio.org/forums/index.php?showtopic=85978 which references:  http://tech.ebu.ch/loudness The site suggests broad European (broadcast?) support for R128. One implementation is at: http://r128gain.sourceforge.net/ ___

[flac-dev] PATCH: Add test for metaflac --add-replay-gain

2012-02-26 Thread Earl Chew
correct. There is only one test to verify handling of harmonics of the filter table sampling frequencies. Signed-off-by: Earl Chew ---  test/test_metaflac.sh |   86 +  1 files changed, 86 insertions(+), 0 deletions(-) diff --git a/test/test_metaflac.sh

Re: [flac-dev] Regain play analysis patches

2012-02-20 Thread Earl Chew
  }     }'  /dev/null - Original Message - From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Friday, February 17, 2012 3:30:00 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote: > I'm a little reluctant to introduce another co

[flac-dev] PATCH: Port equalloudfilt.m MATLAB to scilab

2012-02-18 Thread Earl Chew
Although the script doesn't generate identical results, it seems to get fairly close. The deviations for the Butterworth filter settings seem larger than for the equal loudness filter. This script requires OpenSource scilab which is available for Windows, Linux and MacOS. http://www.scilab.org

Re: [flac-dev] Regain play analysis patches

2012-02-17 Thread Earl Chew
Erik, Ok. These tests will be skipped if bc(1) is not available. Earl - Original Message - From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Friday, February 17, 2012 3:30:00 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote: > I'm

Re: [flac-dev] Regain play analysis patches

2012-02-17 Thread Earl Chew
I'm a little reluctant to introduce another compiled program when there are so many other options that will work well enough out of the box. Here are two ideas: 1. Use bc(1) to compute the raw samples 2. Use perl(1) to compute the raw samples To generate raw unsigned samples using bc(1) for exam

Re: [flac-dev] Regain play analysis patches

2012-02-14 Thread Earl Chew
Erik, Brian, Ok. Earl - Original Message - From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Sent: Tuesday, February 14, 2012 6:52:34 PM Subject: Re: [flac-dev] Regain play analysis patches Brian Willoughby wrote: > What about using the C library sin() and cos() functions to gene

Re: [flac-dev] Regain play analysis patches

2012-02-14 Thread Earl Chew
Ok. I'll redo the test using sox. Earl - Original Message - From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Tuesday, February 14, 2012 12:13:39 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote: > One per filter table entry. That&#x

Re: [flac-dev] Regain play analysis patches

2012-02-14 Thread Earl Chew
on my machine. What are your thoughts ? Earl - Original Message - From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Sent: Tuesday, February 14, 2012 12:41:51 AM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote: > Erik, > > Ok. I've updated th

Re: [flac-dev] Regain play analysis patches

2012-02-13 Thread Earl Chew
?  It means that the wav files need to be checked into the repository. (There are already some small image files in the repository as a precedent.) Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Saturday, February 11, 2012 12:51:

Re: [flac-dev] Regain play analysis patches

2012-02-11 Thread Earl Chew
Erik, I'll rework the patches and send them out again. Earl - Original Message - From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Saturday, February 11, 2012 12:51:22 PM Subject: Re: [flac-dev] Regain play analysis patches Earl Chew wrote: > That being

Re: [flac-dev] Regain play analysis patches

2012-02-10 Thread Earl Chew
Mike, I'm not an expert at DSP work, and I'd gladly defer to any one with any reasonable amount of DSP experience. I followed the link, but I'm not sure how to interpret the graph exactly. I believe it's showing filter behaviour. The two curves look similar, but are clearly not the same. At th

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-03 Thread Earl Chew
have any more insight ? Earl From: Earl Chew To: "flac-dev@xiph.org" Sent: Thursday, February 2, 2012 8:50:17 AM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Erik, I'll resync and have anot

[flac-dev] PATCH: Don't force automake 1.11 AM_SILENT_RULES

2012-02-02 Thread Earl Chew
Don't force automake 1.11 AM_SILENT_RULES on folks who don't have it. diff --git a/configure.ac b/configure.ac index 6a65fcc..36ac6c6 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,7 @@  AC_INIT(src/flac/main.c)  AM_INIT_AUTOMAKE(flac, 1.2.1) -AM_SILENT_RULES([yes]) +m4_ifdef([AM_SILE

Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-02-02 Thread Earl Chew
Erik, I'll resync and have another look. Earl From: Erik de Castro Lopo To: flac-dev@xiph.org Cc: Earl Chew Sent: Wednesday, February 1, 2012 10:30:21 PM Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion Earl

[flac-dev] Support 28kHz, 56kHz and 112kHz gain analysis

2012-01-14 Thread Earl Chew
David Robinson kindly provided me the filter values for 28 kHz sampling rate and I have inserted the filter values into the gain analysis table. Following the previous patch: http://lists.xiph.org/pipermail/flac-dev/2012-January/003067.html extend the supported sample rates to cover all rates

[flac-dev] Support 56kHz to 19.2kHz gain analysis (Patch v3)

2012-01-11 Thread Earl Chew
lues in the Foobar2000 table that are not accounted for are: 112000 = 4 x 28000 56000 = 2 x 28000 To accommodate this, a 28 kSamples/sec entry is required in the base table.  I'll save this for aseparate patch. ____ From: Earl Chew To: "Flac-dev@xiph.

[flac-dev] Support 56kHz to 19.2kHz gain analysis (Patch v3)

2012-01-11 Thread Earl Chew
lues in the Foobar2000 table that are not accounted for are: 112000 = 4 x 28000 56000 = 2 x 28000 To accommodate this, a 28 kSamples/sec entry is required in the base table.  I'll save this for a separate patch. ____ From: Earl Chew To: "Flac-dev@xiph.

[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-01-11 Thread Earl Chew
When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows meta

[Flac-dev] Support 56kHz to 19.2kHz gain analysis (Patch v2)

2012-01-07 Thread Earl Chew
Revise patch to correctly allocate enough buffer for gain analysis. From: Earl Chew To: "Flac-dev@xiph.org" Sent: Saturday, January 7, 2012 11:12:17 AM Subject: [Flac-dev] Support 56kHz to 19.2kHz gain analysis Copy additional filter v

[Flac-dev] Support 56kHz to 19.2kHz gain analysis

2012-01-07 Thread Earl Chew
Copy additional filter values from Foobar2000 as found in to allow metaflac to perform gain analysis on high sample rate audio. flac.diff Description: Binary data ___

[Flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

2012-01-06 Thread Earl Chew
When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows meta