7 and 8 that make
> use of these new functions.
I'll address that separately.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> Fix for incorrect calculation of a tag length inside FLAC__ASSERT.
Good catch. Patch applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
f
lvqcl wrote:
> This patch increases speed of FLAC__lpc_restore_signal_wide_intrin_sse41
> (decoding of 24-bit FLAC files for 32-bit platform).
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
lvqcl wrote:
> This patch increases speed of FLAC__lpc_restore_signal_wide_intrin_sse41
> (decoding of 24-bit FLAC files for 32-bit platform).
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
orgot to write something explanatory
> after "[PATCH 2/4]" in the subject of the original message.
No problem :-).
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
lvqcl wrote:
> This patch removes unused code. Which in turn simplifies
> FLAC__lpc_restore_signal_16_intrin_sse2() function.
I love patches that remove unused code.
Applied. Thanks.
Erik
--
--
Erik de Castro Lop
yway.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
directing
> stderr to a file, the printing result is corrupt.
> We should use fputws simply.
> A patch is attached.
Patch applied. Thanks.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
nternals of these windows are
> explained in the documentation that is in the patch itself.
If I understand this correctly, these new apodization functions only
affect compression and that files compressed with these new functions
will still decode correctly with older versions of the FLAC d
lvqcl wrote:
> Comments?.. A patch that slightly simplifies win_utf8_io is attached.
I like it. Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-
> }
> #else
> rc = vsnprintf (str, size, fmt, va);
> #endif
> va_end (va);
>
> return rc;
> }
This one has the advantage of simplicity, there are only two things
to test.
Either of those two are fine. You choose and send a patch. I'll write
a
ATE, fmt, va);
- rc = (rc > 0) ? rc : (size == 0 ? 1024 : size * 2);
+ rc = vsnprintf (str, size, fmt, va);
+ if (rc < 0) {
+ rc = size - 1;
+ str [rc] = 0;
+ }
#else
rc = vsnprintf (str, size, fmt, va);
#end
of the time most fields are empty when basic
> info like artist, album, title, track number and release date are the
> only fields that are set.
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
h
onality.
About a year ago we had the 1.3.0 release, the first official release
in over 5 years and as far as I am aware no third party front ends
were broken.
I suspect the same will be true of the next release.
Erik
--
--------
> Maybe it's better to revert vsnprintf_s to vsprintf or to use vnsprintf?
Ok, we need to drop vsnprintf_s to support WinXP. I'd prefer vsnprintf
over vsprintf but have no way of testing any of these options.
Erik
--
-------
not the other way round :-).
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> This patch simplifies XMM -> int64 conversion
> in fixed_intrin_sse2.c and fixed_intrin_ssse3.c
Applied, thanks.
Erik
--
------
Erik de Castro Lopo
http://www.mega
lvqcl wrote:
> Currently cpu.h defines variuos FLAC__SSEN_SUPPORTED if GCC >= 4.9
> even for non-x86 architectures.
> After this patch cpu.h checks the presence of FLAC__HAS_X86INTRIN.
Applied, thanks.
Erik
--
------
s.
I thought Micorsoft had recently stopped supporting WinXP. If Micorsoft
has stopped supporting it I see no reason for FLAC to support it.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
_
f days.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
rgv[i] are not freed
> when utf8argv itself is freed.
>
>
> Part #3: 'if (ret != 0) break;' line seems redundant.
Applied al three. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
aximum file name lengths.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
CPUInfo *info).
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
;+' to '|' in ENDSWAP_16 and ENDSWAP_32 macros.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
01-Various-documentation-fixes-merge-with-html-docs.patch
>
> The pages should now be identical in content except the index,
> and only for pages that are featured in both lines.
Both applied, both pushed.
Thanks,
Erik
--
--------
h?id=66a59af0bdc5ae4a719aac5d4a8c41817906a01f
Ugly, but that seemse to be the standard solution to this:
https://www.gnu.org/software/automake/manual/html_node/Per_002dObject-Flags.html
Let me play with this.
Erik
--
----------
prefer to see as the default optimisation level?
I'm sure there is a solution to this. Lets find it.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing
s code
> in stream_encoder
Applied. Thanks.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> This patch tries to simplify the code that tries to detect
> whether OS supports SSE instructions.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
to 30% for
> -8 mode),
> AMD Athlon64, Phenom, Bulldozer/Piledriver, but no increase or even very small
> speed decrease (~2% for -8 mode) on Intel Core2.
Applied. Thanks.
Erik
--
----------
Erik de Castro
x27;t mention it then.
Both applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
.
Cheers,
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
(version A is the current code).
Sounnds good.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
; before applying
the what we want. Please test.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ll -g asks the compiler to add debug symbols. What hapens if you strip
the binary?
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
d the above with:
CFLAGS="-O3 -funroll-loops -Wall -W -Winline $CFLAGS"
so CFLAGS are preserved and enforce optimisations.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
pt also generates config.log which would also be interesting.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> Erik de Castro Lopo wrote:
>
> > lvqcl wrote:
> >
> >> The most problematic parts are 3 and 4 since I cannot directly
> >> test them neither on Darwin PPC nor on Linux PPC.
> >
> > I'll try to power up my Linux/PPC mach
y normal domain) and I'l get you in contact with the
current owner.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
ff ) ^ FLAC__crc16_table[ ((crc)>>8) ^ (data) ]
> ))
> ^
>^
>
> The patch is attached.
Applied. Thanks.
Erik
--
----------
C". The patch is attached.
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
heers,
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> Not only test_replaygain.sh (commit 1988855), but also
> test_flac.sh requires additional --force-raw-format option.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
It doesn't looks right. The second patch fixes this.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
l that code, or it's too early yet?
I think it should go. Would love to see a patch :-).
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing
lvqcl wrote:
> This patch adds FLAC-vs2010.sln, *.vcxproj and *.vcxproj.filters
> files to EXTRA_DIST section of corresponding Makefile.am files.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
. Thanks.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
= strlen_console(name)+2;
> console_chars_left = console_width - (len % console_width);
>
> A simple patch is attached.
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
ase will have them though, because it's easy for me to
> compile the right one" -- Josh Coalson
>
>
> I suspect that PPC/Altivec asm code is disabled for good.
I agree.
Thanks for looking into this.
Cheers,
Erik
--
---
lvqcl wrote:
> This archive contains files for Visual Studio 2010 and newer
> (.sln, .vcxproj, .vcxproj.filters).
>
> Allows to build files for x86-64 platform.
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
htt
lvqcl wrote:
> This patch removes unused
> FLAC__bitreader_read_rice_signed_block_asm_ia32_bswap()
> and makes bitreader_read_from_client_() function static again.
Applied. Thanks.
Erik
--
------
Erik de Castro
lvqcl wrote:
> Erik de Castro Lopo wrote:
>
> >> 3)
> >> Currently there are two ia32 asm files (bitreader_asm.nasm and
> >> stream_encoder_asm.nasm)
> >> that are unused and not necessary to compile libFLAC: they offer no speed
> >> benefit
lvqcl wrote:
> Does it mean that PowerPC/Altivec asm optimizations were disabled
> almost 10 years ago?
Certainly seems that way.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
or with
> very large 16-bit partitions.
>
> This is related to commits 6f7ec60c and 187e596e.
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> This patch removes MSVC "spoon feeding".
Applied. Thanks.
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@
lvqcl wrote:
> 1)
> lpc.c, FLAC__lpc_quantize_coefficients():
> 2)
> There's the following code in stream_decoder.c:
Like you, I don't see a lot of value in these. I think I'll decline
these.
Cheers,
Erik
--
---
(which will be pushed
soon).
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Martin Leese wrote:
> Would not a /* Do not remove */ comment be
> sufficient (and much less effort)?
Less effort, but also less reliable.
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
unbreak the
> integration tests.
Applied (after I fixed a spaces/tabs issue). Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xi
lvqcl wrote:
> Did you decide that those patches ain't worth applying?
> (I admit that they don't really solve any problem).
Hadn't decided yet. Please give me 12 hours. Gotta go to
work now :-)
Cheers,
Erik
--
-----
gt; (found another place with this double conversion, inside
> src/utils/flactimer/main.cpp. It also has unnecessary #defines
> for int64_t/uint64_t)
Do you want to create a patch for this or should I?
Erik
--
--------
Erik de Castro Lopo wrote:
> I much prefer the second version because its such a trivial patch.
Actually, no, the second is better because its explicit and has
comments.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.
ld be
easy for someone to remove the "+ 4" again and break it.
Before I commit this, I'd like to have a test that triggers this
problem. Let me work on that.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.co
tly, so
> here's the link:
>
> http://www.audiograaf.nl/misc_stuff/0001-Fix-dead-links-and-copyright-year.patch
Applied. Thanks.
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
s of MSVC > 6?
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> The 1st patch fixes compiling of test_libFLAC with MSVC.
>
> The 2nd patch fixes Makefile.lite build system
> (I don't use it, but this patch is really simple...)
Good catch. Applied.
Erik
--
--------
lvqcl wrote:
> --endian and --sign aren't just options for raw input, but also
> for raw output. So the help text was corrected.
Appled. Thanks.
Erik
--
------
Erik de Castro Lopo
http://www.me
. Applied.
Thanks,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
ng the last four lines is easy but is it sufficient?
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
d5 sums, so maybe the
> problem is in the test itself?
Yes, the tests were broken and were only passing by replying on
undefined behaviour.
Tests fixed, and pass on amd64/Linux, powerpc64/Linux and armh/Linux.
Erik
--
-----------
pute_residual(data[], data_len, order, residual[]) function.
Can someone please provide me with a copy of the file snippet6.wav ? I'd
like to test this some more.
Erik
--
----------
Erik de Castro Lopo
h
lvqcl wrote:
> Erik de Castro Lopo wrote:
>
> >> FLAC__int16 s16buffer[FLAC__MAX_BLOCK_SIZE * FLAC__MAX_CHANNELS *
> >> sizeof(FLAC__int32)/sizeof(FLAC__int16)];
> >>
> >> instead of
> >>
> >> FLAC__int16 s16buffer[FLAC__MA
Martijn van Beurden wrote:
>
> op 29-06-14 15:31, Erik de Castro Lopo schreef:
> > I would appreciate it if people could kick this around, test on other
> > platforms/architectures and test for performance regressions.
>
> These patches indeed fix the -Wcast-align warn
(FLAC__int32)/sizeof(FLAC__int32)];
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> In FLAC 1.2.1 there was an assert in FLAC__bitmath_ilog2 and
> FLAC__bitmath_ilog2_wide functions:
Patches 10 to 15 applied, tested and pushed.
Thanks,
Erik
--
--
Erik de Castro Lopo
http://www.mega-ne
lvqcl wrote:
> Erik de Castro Lopo wrote:
>
> > All 9 patchsets applied, tested and pushed. Thanks!
>
> Great, thanks. (Un)fortunately, I have yet more patches...
Nothing unfortunate about more patches as long as those
patches make fla
ntly working on fixing the cast-align issue in md5.c. This is
a lot more difficult and requires that I first write some unit tests
for the md5 stuff before I even change anything.
Erik
--
------
Erik de Castro Lopo
http://ww
t the conclusion was.
The patch still applies, and the test suite passes. If there is a
problem with this patch that the test suite doesn't catch, we should
write a test that does catch it.
If there is no problem with the patch I'll push it.
Erik
--
----------
gt; PS: I thought that you became FLAC maintainer in 2012, not in 2014...
Also fixed.
Cheers,
Erik
--
----------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph
lvqcl wrote:
> Erik de Castro Lopo wrote:
>
> > Things I need to do for this new release:
> >
> > * Deal with all current patches on the mailing list.
>
> Any patches pending? I have some bugfixes, and I'd like to
> make sure that they don't interfere
forge.net/viewvc/flac/flac/src/flac/main.c?r1=1.169&r2=1.169.2.1&pathrev=FLAC_RELEASE_1_2_1_MAINTENANCE_BRANCH
All 9 patchsets applied, tested and pushed. Thanks!
Erik
--
----------
Erik de Ca
Martijn van Beurden wrote:
> op 27-06-14 14:11, Erik de Castro Lopo schreef:
> > There has been at least one person on this list who is able to do
> > perfromance tests on FLAC. I would appreciate it if someone could
> > run such a performance test before and after the above
Hi all,
I fixed the first cast-align warning in this commit:
commit 40e817dc526d1d41e900bb0f54d1a4451bda01ed
Author: Erik de Castro Lopo
Date: Fri Jun 27 21:58:26 2014 +1000
src/flac/decode.c : Fix a cast-align warning from GCC.
The old code was creating an array of
Martijn van Beurden wrote:
> op 27-06-14 12:26, Erik de Castro Lopo schreef:
>
> > Does the test suite pass after you have compiled it?
>
> Yes, it does. At least, make check does (with ./configure
> --disable-thorough-tests, as the thorough tests take more than a
>
ave Miroslav) are in the AUTHORS file :)
I've pushed an update to that file. If anyone feels they or
someone else has been left off that list, please let me know.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
__
ing warning for x86_64-MinGW-w64
> builds, produced by every ".pic.o" object:
> >warning: -fPIC ignored for target (all code is position independent)
> >[enabled by default]
>
> Patch attached.
Thanks. Applied and pushed.
Erik
--
t that it hasn't broken the build for you?
Cheers,
Erik
--
------
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Miroslav Lichvar wrote:
> On Thu, Jun 19, 2014 at 07:28:11PM +1000, Erik de Castro Lopo wrote:
> > Miroslav Lichvar wrote:
> > > In file included from /usr/include/math.h:45:0,
> > > from grabbag/replaygain.c:25:
> > > /usr/include/bits/mathdef
rik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
lvqcl wrote:
> Erik de Castro Lopo писал(а) в своём письме Thu, 19
> Jun 2014 17:01:26 +0400:
>
> >> (currently src/libFLAC/ia32 folder contains unused lpc_asm-unrolled.nasm
> >> file, so why remove unused bitreader_asm.nasm and stream_encoder_asm.nasm
> >
7;m still trying to decide on the right fix for that issue.
I would appreciate it if you could update you patch to address
the issues I raised above.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
__
ed bitreader_asm.nasm and stream_encoder_asm.nasm
> files?)
I don't see any point in keeping files in release tarballs or in Git that
provide no value. Documentation provides value, but unused source code
does not.
All the various build system files should be cleansed of references to the
eplaygain.c:25:
> /usr/include/bits/mathdef.h:35:21: note: previous declaration of 'float_t'
> was here
> typedef long double float_t; /* `float' expressions are evaluated as
What distro? What package and what version of the what package installed
that file?
Erik
--
---
n't think that they will become useful again, but who knows...
I think they should be deleted in a commit that says something like "Removing
old nasm versions of some functions". That will clearly mark that commit so
that if needed the files can be easily
mailing list.
* Review all bugs reported against 1.3.0 on the sf.net.
* Testing and coordination of testing across platforms and build systems.
Anything else I've forgotten or people would like to see?
Cheers,
Erik
--
--
Erik de C
Erik de Castro Lopo wrote:
> lvqcl wrote:
>
> > Some projects/makefiles add both 'include' and 'include/share'
> > to the list of additional include directories.
>
> I think that is suboptimal.
>
> > For example, src/share/utf8/utf8.c includ
401 - 500 of 1117 matches
Mail list logo
