Re: [flac-dev] [PATCH] configure: only use -mstackrealign for mingw32

2015-04-10 Thread JonY
On 4/11/2015 05:10, Erik de Castro Lopo wrote: Tristan Matthews wrote: --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..e7d68c3 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,11 @@ if test

Re: [flac-dev] Can't cross-compile from git now.

2014-09-27 Thread JonY
On 3/9/2013 06:20, Erik de Castro Lopo wrote: bat guano wrote: Hi I have a problem now cross-compiling FLAC from latest git. With Ubuntu 12.04 and g++-mingw-w64-i686 (4.6.3-1ubuntu5+5ubuntu1). I think that the problem might have been introduced on 5 Mar 2013 with commit 05609d5

Re: [flac-dev] 2GB limit patch

2014-09-27 Thread JonY
On 3/5/2013 09:57, nu774 wrote: 2. i686-pc-mingw also needs fseeko()/ftello() definitions (only fseeko64() and ftello64() available). Not true for i686-w64-mingw32, it has Linux style LFS64 with _FILE_OFFSET_BITS. signature.asc Description: OpenPGP digital signature

Re: [flac-dev] vsnprintf_s and vsnprintf

2014-09-21 Thread JonY
On 9/21/2014 08:17, lvqcl wrote: JonY wrote: You could just request mingw to include a vsnprintf_s implementation for XP and earlier, mingw-w64 has already done so. I use MinGW-w64: it's XhmikosR's MSYS that contains MinGW-w64 build of GCC/Binutils for Windows from nevcairiel. It has

Re: [flac-dev] Bug fix and compatibility patches for 1.3.0pre4

2013-05-04 Thread JonY
On 5/5/2013 09:03, Timothy B. Terriberry wrote: Robert Kausch wrote: The _lseeki64 patch probably is a little more controversial. The problem is that fseeki64 and ftelli64 are not available in Windows XP - at least not without installing extra MSVC runtime libraries. I changed compat.h and

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-19 Thread JonY
On 3/20/2013 00:35, Janne Hyvärinen wrote: As for calling __wgetmainargs, I have some concerns about the security implications: LoadLibrary(msvcrt.dll) - Which msvcrt? Theoretical security exploit. There is msvcrt.dll in the System32 dir in all supported Windows systems. That is what the

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY
On 3/18/2013 14:55, Erik de Castro Lopo wrote: Brian Willoughby wrote: I believe that shell does handle wildcards on all Unix variants, including OSX. Yes. Since Windows does not handle them, I suggest that the main flac code not be littered with code that's not necessary on the

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY
On 3/18/2013 09:55, LRN wrote: On 18.03.2013 02:10, JonY wrote: On 3/17/2013 23:01, LRN wrote: All those ifdefs will at least be confined rather than spread out through the code. I did it plibc-style: in compat.h: #if defined(_WIN32) #define FOPEN grabbag__fopen_utf8_wrapper #else #define

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY
On 3/18/2013 19:21, Janne Hyvärinen wrote: On 18.3.2013 11:35, JonY wrote: Before anyone does anything, see __wgetmainargs http://msdn.microsoft.com/en-us/library/ff770599.aspx. It can expand wildcards. Since it already provides argc/argv/env, it is more a less a drop-in replacement

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-18 Thread JonY
On 3/18/2013 19:34, LRN wrote: On 18.03.2013 13:35, JonY wrote: Before anyone does anything, see __wgetmainargs http://msdn.microsoft.com/en-us/library/ff770599.aspx. It can expand wildcards. Since it already provides argc/argv/env, it is more a less a drop-in replacement for the main

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-17 Thread JonY
On 3/17/2013 23:01, LRN wrote: All those ifdefs will at least be confined rather than spread out through the code. I did it plibc-style: in compat.h: #if defined(_WIN32) #define FOPEN grabbag__fopen_utf8_wrapper #else #define FOPEN fopen #endif in grabbag: #if defined(_WIN32)

Re: [flac-dev] Patch to add Unicode filename support for win32 flac

2013-03-16 Thread JonY
On 3/17/2013 10:33, Janne Hyvärinen wrote: Here's a patch that makes MSVC compiled flac.exe able to use wildcards and encode/decode files with Unicode characters in names. It may not be the prettiest code but it fulfills its primary purpose. I tried to alter FLAC code as little as possible. It

Re: [flac-dev] Can't cross-compile from git now.

2013-03-13 Thread JonY
On 3/13/2013 06:50, Erik de Castro Lopo wrote: JonY wrote: Dave, my toolchain automatically links libssp already, I am using vanilla sources. Are you doing a native Windows compile with MinGW or cross compiling from Linux? Crossing from Cygwin, GCC built from vanilla FSF sources. Why

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread JonY
On 3/12/2013 18:58, Erik de Castro Lopo wrote: Erik de Castro Lopo wrote: JonY wrote: Please do a link time test instead, I am not getting this error and would like to keep stack protector on. I'll write an m4 macro. I have attampted to write a macro that reliably detects

Re: [flac-dev] Patch for cross compilation with MinGW32

2012-06-23 Thread JonY
On 6/24/2012 10:23, Christoph Terasa wrote: Hello, I had some difficulties compiling the current git ( http://git.xiph.org/?p=flac.git;a=commit;h=a7e3705d051bafd1cae90f6605287cc1d9f2a18d ) using the Ubuntu 12.04 supplied MinGW32 cross compiler: I configured the FLAC build with

Re: [flac-dev] Trying to link against libFLAC_static.lib (windows)

2012-03-25 Thread JonY
On 3/26/2012 06:52, Glenn McCord wrote: Did you compile the dll earlier? If so, you can try cleaning the project and rebuilding. I've compiled the .dll earlier, but they've now all been deleted. They would have been built when I built the entire solution (and thus all the projects). I've

Re: [flac-dev] Trying to link against libFLAC_static.lib (windows)

2012-03-23 Thread JonY
On 3/23/2012 13:59, Glenn McCord wrote: Hi. I'm trying to get a project linking to libFLAC_static.lib but I get linker errors such as the following. The __imp__ prefix seems to imply that some kind of .dll usage is happening, which it shouldn't. All I need is the C lib, so I just build

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-09 Thread JonY
On 2/10/2012 02:14, LRN wrote: On 09.02.2012 21:41, Ben Allison wrote: Dave Yeo wrote: Yes that makes sense. Requiring a C99 compliant compiler seems quite reasonable. Well I'm actually going to be even more reasonable than that. The only bits of C99 that flac will really require is header

Re: [flac-dev] [PATCH] Remove even more CPP hackery

2012-02-07 Thread JonY
On 2/8/2012 03:33, Dave Yeo wrote: On 02/07/12 12:03 am, Erik de Castro Lopo wrote: Dave Yeo wrote: This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been been replaced by klibc. Considering the age of EMX and lack of testing and that klibc contains so many improvements I

Re: [flac-dev] [PATCH 2/2] OS/2 EMX natively uses AOUT so pass -f aout to NASM

2012-02-05 Thread JonY
On 2/5/2012 16:01, Erik de Castro Lopo wrote: JonY wrote: On 2/5/2012 13:30, Erik de Castro Lopo wrote: Dave Yeo wrote: --- configure.ac |1 + Both applied (first with a minor tweak). Thanks. Erik Unfortunately, this steps on my patch. Updated patch attached. Cygwin really

Re: [flac-dev] Moving CPP hackery

2012-02-04 Thread JonY
On 2/4/2012 13:20, Erik de Castro Lopo wrote: Hi all, especially David Yeo and JonY, I've started moving compiler specific CPP hacker into a separate file at include/share/compat.h. Eventually I hope to be able to move all of the require CPP hackery for $random_compiler into this file

Re: [flac-dev] Moving CPP hackery

2012-02-04 Thread JonY
On 2/4/2012 17:45, Erik de Castro Lopo wrote: JonY wrote: Looks like there are some missed defines in the test_libFLAC++. Attached patch fixes that. Good one. Thanks. Also, wsock32 usage is deprecated, on Win7, wsock32 forwards everything to ws2_32, suggest changing to -lwsock32

Re: [flac-dev] [PATCH 2/2] OS/2 EMX natively uses AOUT so pass -f aout to NASM

2012-02-04 Thread JonY
On 2/5/2012 13:30, Erik de Castro Lopo wrote: Dave Yeo wrote: --- configure.ac |1 + Both applied (first with a minor tweak). Thanks. Erik Unfortunately, this steps on my patch. Updated patch attached. Cygwin really shouldn't be calling win32 API. On the otherhand, I can't seem to

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-02-03 Thread JonY
On 2/3/2012 06:33, JonY wrote: On 2/3/2012 02:50, Erik de Castro Lopo wrote: JonY wrote: Attached patch builds without any warnings for MinGW. Sorry JonY, that patch does not apply against current git master which is here: https://git.xiph.org/?p=flac.git;a=summary Specifically I

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-02-02 Thread JonY
On 2/1/2012 22:36, JonY wrote: On 2/1/2012 18:52, Erik de Castro Lopo wrote: JonY wrote: Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-02-01 Thread JonY
On 2/1/2012 18:52, Erik de Castro Lopo wrote: JonY wrote: Alright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format

Re: [Flac-dev] Git branch with compiling fixes for win32

2011-11-26 Thread JonY
On 11/16/2011 06:49, JonY wrote: On 11/16/2011 03:20, Erik de Castro Lopo wrote: JonY wrote: On 11/14/2011 18:01, JonY wrote: On 11/10/2011 19:22, JonY wrote: On 11/10/2011 18:39, Erik de Castro Lopo wrote: I'm subscribed to the list (and I set my reply-to to the list). Please do not CC

Re: [Flac-dev] Git branch with compiling fixes for win32

2011-11-15 Thread JonY
On 11/14/2011 18:01, JonY wrote: On 11/10/2011 19:22, JonY wrote: On 11/10/2011 18:39, Erik de Castro Lopo wrote: I'm subscribed to the list (and I set my reply-to to the list). Please do not CC me. JonY wrote: Its probably on one of the sf tracker somewhere, I can't seem to find

Re: [Flac-dev] Git branch with compiling fixes for win32

2011-11-15 Thread JonY
On 11/16/2011 03:20, Erik de Castro Lopo wrote: JonY wrote: On 11/14/2011 18:01, JonY wrote: On 11/10/2011 19:22, JonY wrote: On 11/10/2011 18:39, Erik de Castro Lopo wrote: I'm subscribed to the list (and I set my reply-to to the list). Please do not CC me. JonY wrote: Its probably

Re: [Flac-dev] Git branch with compiling fixes for win32

2011-11-10 Thread JonY
On 11/10/2011 08:02, Erik de Castro Lopo wrote: JonY wrote: I submitted a patch sometime ago to correct printf specifiers for win32 by using inttypes.h, but there were no response, so I thought flac development was dead. Development is probably complete. Maintenance should continue

Re: [Flac-dev] Git branch with compiling fixes for win32

2011-11-09 Thread JonY
On 11/10/2011 06:58, Erik de Castro Lopo wrote: Sven-Hendrik Haase wrote: Si señor: http://code.entropywave.com/git/flac.git Ok, there are about 6 commits there. Over the weekend I'll have a look at them and if they're fine, I'll push them to the Xiph Git repo. If anyone else has Flac