Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-06 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > LRN wrote: > > > I've sent a utf-8 support patch to flac-dev, but it didn't arrive. The > > patch file is around 64k, so i believe that this is the problem. Maybe > > i should compress it? > > Maybe send it directly to me, erikd at my usual domain name. I have LRN's

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread Erik de Castro Lopo
LRN wrote: > I've sent a utf-8 support patch to flac-dev, but it didn't arrive. The > patch file is around 64k, so i believe that this is the problem. Maybe > i should compress it? Maybe send it directly to me, erikd at my usual domain name. Erik -- -

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread LRN
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05.03.2013 20:39, Ben Allison wrote: > I would be willing to add Windows Unicode support (and large file > mode) to the flac binary tool, but frankly I'm not sure that it > could be done as a single cross-platform source file. There would > be a

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread nu774
(2013/03/06 6:20), Ben Allison wrote: > My worry is more around metadata handling and parsing commandline input. > You can't pass UTF-8 in setlocale on windows (from the docs: "If you > provide a code page like UTF-7 or UTF-8, setlocale will fail, returning > NULL."). There is a good chance that t

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread LRN
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.03.2013 01:20, Ben Allison wrote: > On 06.03.2013 01:02, Chris Moeller wrote: >> On Tue, 5 Mar 2013 11:39:19 -0500, Ben Allison wrote: >>> On 05.03.2013 12:30, Erik de Castro Lopo wrote: ktf said: > No unicode support for Windows either.

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread Ben Allison
My worry is more around metadata handling and parsing commandline input. You can't pass UTF-8 in setlocale on windows (from the docs: "If you provide a code page like UTF-7 or UTF-8, setlocale will fail, returning NULL."). There is a good chance that the behavior will still be correct with UTF-8

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread Chris Moeller
Take a look at how the Opus Tools package handles it. So far as I remember, it requires minimal changes to the file(s) containing references to the main entry point and to fopen. It imports the command line arguments as wchar_t and converts them to UTF-8, and has replacement functions for fopen and

Re: [flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread Ben Allison
I would be willing to add Windows Unicode support (and large file mode) to the flac binary tool, but frankly I'm not sure that it could be done as a single cross-platform source file. There would be a significant amount of either Windows API function calls or MSVC-specific extensions to the C libr

[flac-dev] Answering the Hydrogen Audio thread

2013-03-05 Thread Erik de Castro Lopo
There is a thread over on Hydrogen Audio forums: http://www.hydrogenaudio.org/forums/index.php?showtopic=99757 I will answer what I can here. > mudlord says : > As usual, Fidel Castro Loco ignored Windows. Wrong. As the git logs show, I have commited a bunch of windows specific fixes myse