Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-25 Thread Erik de Castro Lopo
Janne Hyvärinen wrote: On 22.5.2013 17:03, Felix Homann wrote: Sorry that it took so long to reply. As mentioned in an earlier mail my first bisect session wasn't accurate. I've done a new one: Here's my patch suggestion but I'm no Android guy. Patch applied. Thanks Janne. Erik --

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-24 Thread Felix Homann
2013/5/23 Janne Hyvärinen c...@sci.fi Here's my patch suggestion but I'm no Android guy. Yes, this patch fixes the Android build. There are still a couple of warnings building for Android. I'll report them in a seperate mail. Thanks, Felix ___

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-23 Thread Janne Hyvärinen
On 22.5.2013 17:03, Felix Homann wrote: Sorry that it took so long to reply. As mentioned in an earlier mail my first bisect session wasn't accurate. I've done a new one: Here's my patch suggestion but I'm no Android guy. diff --git a/src/flac/utils.c b/src/flac/utils.c index

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-22 Thread Felix Homann
Sorry that it took so long to reply. As mentioned in an earlier mail my first bisect session wasn't accurate. I've done a new one: git bisect bad d0c219f1978dbaa00a063ac82aa75c8af152cbbb is the first bad commit commit d0c219f1978dbaa00a063ac82aa75c8af152cbbb Author: Erik de Castro Lopo

[flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-15 Thread Felix Homann
Hi, I couldn't figure out how to file a bug in the bugtracker at sourceforge. So I send a report this way. Building FLAC from git for Android fails with the following message: utils.c: In function 'get_console_width': utils.c:181:17: error: storage size of 'w' isn't known utils.c:181:17:

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-15 Thread Ulrich Klauer
Felix Homann wrote: utils.c: In function 'get_console_width': utils.c:181:17: error: storage size of 'w' isn't known utils.c:181:17: warning: unused variable 'w' [-Wunused-variable] [That's apparently src/flac/utils.c.] Strange thing. It looks like struct winsize isn't known anymore.

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-15 Thread Ulrich Klauer
Felix Homann wrote: Yes, HAVE_SYS_PARAM_H is set in config.h: OK ... Yet still I don't see how a change in src/libFLAC/include/private/macros.h could affect src/flac/utils.c in any way. Anyone got an idea? Ulrich ___ flac-dev mailing list

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-15 Thread Felix Homann
2013/5/15 Ulrich Klauer ulr...@chirlu.de Felix Homann wrote: Yes, HAVE_SYS_PARAM_H is set in config.h: OK ... Yet still I don't see how a change in src/libFLAC/include/private/macros.h could affect src/flac/utils.c in any way. Anyone got an idea? I haven't spend too much attention to

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-15 Thread Felix Homann
Here are the warnings I get with 03a9e6064d406e3656afacdbe50e8e47ebfa0de3: LANG=C android-make | grep Warning bitreader.c: In function 'FLAC__bitreader_skip_bits_no_crc': bitreader.c:494:4: warning: implicit declaration of function 'MIN' [-Wimplicit-function-declaration] bitreader.c:494:4:

Re: [flac-dev] FLAC currently won't compile for Android [bisected]

2013-05-15 Thread Ulrich Klauer
Felix Homann wrote: Here are the warnings I get with 03a9e6064d406e3656afacdbe50e8e47ebfa0de3: It seems Android sys/param.h doesn't define MIN/MAX. Could you try to revert this commit on current master (or simply change line 35 of src/libFLAC/include/private/macros.h back to #if