[flac-dev] [PATCH 13] cpu.c / cpu_asm.nasm

2014-06-28 Thread lvqcl
According to docs, it's incorrect to just call CPUID with EAX=1. One must to ensure that this value is supported. CPUs that don't support CPUID level 1 are very old, but... if FLAC tests CPUID presence it should also test CPUID level support. Also the function FLAC__cpu_have_cpuid_asm_ia32 was

Re: [flac-dev] PATCH for cpu.c

2014-03-27 Thread Erik de Castro Lopo
lvqcl wrote: Explanation of changes in this patch: Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org

[flac-dev] PATCH for cpu.c

2014-03-22 Thread Oliver Stöneberg
Hi, after having some discussion of the FPU/SSE behavior on the sf.net bug tracker as well as having some other changes we made for the MAME/MESS project sitting around I thought about joining this list to make things easier. First one is the latest modification we had to make to compile with

[flac-dev] PATCH for cpu.c

2013-08-21 Thread lvqcl
1) Some time ago all project files for MSVC 6 were removed; it makes sense to remove the code that is necessary only for MSVC 6 and older compilers. --- a\src\libFLAC\cpu.c 2013-08-13 13:30:24.0 +0400 +++ b\src\libFLAC\cpu.c 2013-08-16 21:46:42.177485300 +0400 @@ -285,14 +285,7 @@ #

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Ozkan Sezer
On 8/21/13, lvqcl lvqcl.m...@gmail.com wrote: 1) Some time ago all project files for MSVC 6 were removed; it makes sense to remove the code that is necessary only for MSVC 6 and older compilers. One may still compile using command line instead of a project file. Does it really hurt keeping

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Erik de Castro Lopo
Ozkan Sezer wrote: On 8/21/13, lvqcl lvqcl.m...@gmail.com wrote: 1) Some time ago all project files for MSVC 6 were removed; it makes sense to remove the code that is necessary only for MSVC 6 and older compilers. One may still compile using command line instead of a project file. Does

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Timothy B. Terriberry
Erik de Castro Lopo wrote: Its crufty old code. I should be removed. It makes no sense to keep supporting 20 year old compilers (MSVC6 was was released in 1989 and MSVC7 in 1992 [0]). That's not quite accurate. MSC6 was released in 1989. MSVC was released in 1998. So only 15 years old :).

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Timothy B. Terriberry
Timothy B. Terriberry wrote: That's not quite accurate. MSC6 was released in 1989. MSVC was released in 1998. So only 15 years old :). *MSVC6, I meant. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Erik de Castro Lopo
Timothy B. Terriberry wrote: Erik de Castro Lopo wrote: Its crufty old code. I should be removed. It makes no sense to keep supporting 20 year old compilers (MSVC6 was was released in 1989 and MSVC7 in 1992 [0]). That's not quite accurate. MSC6 was released in 1989. MSVC was released