Re: [flashrom] [PATCH] Support old libpci <2.2.4

2010-05-21 Thread Carl-Daniel Hailfinger
On 20.05.2010 21:14, Uwe Hermann wrote: > On Fri, May 14, 2010 at 02:25:40PM +0200, Carl-Daniel Hailfinger wrote: > >> - If we want to get flashrom working with libpayload, we'd better not >> rely on the more exotic features of libpci because every such feature >> has to be coded up and I don't

Re: [flashrom] [PATCH] Support old libpci <2.2.4

2010-05-20 Thread Uwe Hermann
On Fri, May 14, 2010 at 02:25:40PM +0200, Carl-Daniel Hailfinger wrote: > - If we want to get flashrom working with libpayload, we'd better not > rely on the more exotic features of libpci because every such feature > has to be coded up and I don't think we want to link flashrom-as-payload > agains

Re: [flashrom] [PATCH] Support old libpci <2.2.4

2010-05-14 Thread Carl-Daniel Hailfinger
On 14.05.2010 11:51, Peter Lemenkov wrote: > 2010/5/14 Stefan Reinauer : > >> On 5/14/10 4:00 AM, Carl-Daniel Hailfinger wrote: >> >>> libpci < 2.2.4 can not store class info in struct pci_dev. >>> Read class info manually and store it in a separate variable. >>> > > >> Wouldn't i

Re: [flashrom] [PATCH] Support old libpci <2.2.4

2010-05-14 Thread Peter Lemenkov
2010/5/14 Stefan Reinauer : > On 5/14/10 4:00 AM, Carl-Daniel Hailfinger wrote: >> libpci < 2.2.4 can not store class info in struct pci_dev. >> Read class info manually and store it in a separate variable. > Wouldn't it make more sense to ask people to update their libpci? > pciutils 2.2.3 is mor

Re: [flashrom] [PATCH] Support old libpci <2.2.4

2010-05-14 Thread Stefan Reinauer
On 5/14/10 4:00 AM, Carl-Daniel Hailfinger wrote: > libpci < 2.2.4 can not store class info in struct pci_dev. > Read class info manually and store it in a separate variable. > > Signed-off-by: Carl-Daniel Hailfinger > Wouldn't it make more sense to ask people to update their libpci? pciutils 2

[flashrom] [PATCH] Support old libpci <2.2.4

2010-05-13 Thread Carl-Daniel Hailfinger
libpci < 2.2.4 can not store class info in struct pci_dev. Read class info manually and store it in a separate variable. Signed-off-by: Carl-Daniel Hailfinger Index: flashrom-libpci_old_workaround/board_enable.c === --- flashrom-lib