Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-06 Thread Alan Teeder
: Thomas Geymayer Sent: Wednesday, March 06, 2013 12:42 AM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] How to get my bug fix into the git? Hi, Am 2013-03-06 00:11, schrieb Godspeed Dash: I don't think it is related specific to the strdup(), it looks more like it has

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-06 Thread James Turner
On 6 Mar 2013, at 11:11, Alan Teeder ajtee...@v-twin.org.uk wrote: ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/, is still at Boost 1.44, and many MSVC users will be using that rather than the latest version. I am updating my own Boost version at the moment, and will report if that

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-06 Thread Thomas Geymayer
Am 2013-03-06 12:11, schrieb Alan Teeder: ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/, is still at Boost 1.44, and many MSVC users will be using that rather than the latest version. I am updating my own Boost version at the moment, and will report if that solves the compilation

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-06 Thread Alan Teeder
-Original Message- From: James Turner Sent: Wednesday, March 06, 2013 11:42 AM To: FlightGear developers discussions Subject: Re: [Flightgear-devel] How to get my bug fix into the git? On 6 Mar 2013, at 11:11, Alan Teeder ajtee...@v-twin.org.uk wrote: ftp://ftp.ihg.uni-duisburg.de

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-06 Thread Alan Teeder
I have upgraded boost to 1.53, building with MSVC10. All now runs. The biggest problem was sorting out the resulting Cmake chaos. Alan -- Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-05 Thread Gijs de Rooy
Hi Thomas, Anyhow, I have just pushed a fix which replaces the manual string copying with directly using std::string. Please test if this also solves your problem. Not sure if I'm experiencing the same issue, but it looks related. SimGear fails to compile for me, showing these errors:

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-05 Thread Godspeed Dash
Hi Gijs, I don't think it is related specific to the strdup(), it looks more like it has something to do with boost 1.44, I was compiling using a higher version, boost 1.53. And @Tom, I used macros to work around the strdup() under MSVC, as you suggested, and I have submitted the merge request

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-05 Thread Thomas Geymayer
Hi, Am 2013-03-06 00:11, schrieb Godspeed Dash: I don't think it is related specific to the strdup(), it looks more like it has something to do with boost 1.44, I was compiling using a higher version, boost 1.53. The warnings should now have gone, but the other errors look like due to a very

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-03 Thread Thomas Geymayer
Am 2013-03-03 05:20, schrieb Zhitao Li: I believe your commit has fixed the specific problem, however, there is more similar string related heap corruptions popping up in the debug mode, I think I can try to fix them in a similar way you did to fix this one, if it's OK Yes, there strdup is

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-02 Thread Zhitao Li
Message- From: Thomas Geymayer [mailto:tom...@gmail.com] Sent: Friday, March 01, 2013 4:22 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] How to get my bug fix into the git? Hi Godspeed, Am 2013-03-01 10:14, schrieb Zhitao Li: I am new to the FlightGear

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-02 Thread Thomas Geymayer
Am 2013-03-03 00:49, schrieb Zhitao Li: I have seem [1], and I don't think it is caused by the linking problem, I check and experimented the cmake parameter, it's more likely the implementation of the function in visual studio that's causing it. (the malloc() within the strdup() is probably

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-02 Thread Zhitao Li
: Thomas Geymayer [mailto:tom...@gmail.com] Sent: Saturday, March 02, 2013 5:20 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] How to get my bug fix into the git? Am 2013-03-03 00:49, schrieb Zhitao Li: I have seem [1], and I don't think it is caused by the linking

[Flightgear-devel] How to get my bug fix into the git?

2013-03-01 Thread Zhitao Li
Hi everyone, I am new to the FlightGear project, I just found and fixed my first bug, I am wondering how to get my fix into the main git next branch? Thanks! Sincerely Godspeed -- Everyone hates slow

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-01 Thread Arnt Karlsen
On Fri, 1 Mar 2013 02:14:59 -0700, Zhitao wrote in message 004601ce165d$409a80c0$c1cf8240$@gmail.com: Hi everyone, I am new to the FlightGear project, I just found and fixed my first bug, I am wondering how to get my fix into the main git next branch? ..you put it here?:

Re: [Flightgear-devel] How to get my bug fix into the git?

2013-03-01 Thread Thomas Geymayer
Hi Godspeed, Am 2013-03-01 10:14, schrieb Zhitao Li: I am new to the FlightGear project, I just found and fixed my first bug, Great ;) I'm not sure if your fix [2] is really a fix or just hiding symptoms. I currently have no VS available for testing but eg. at [1] it seems like its a linking