Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread Csaba Halász
On Sun, Jan 30, 2011 at 8:51 PM, Frederic Bouvier wrote: > > But if you start without a joystick, you won't be able to open that dialog That is true. Easily fixed by reevaluating the menu state after the reload. Should probably be refactored a little to avoid code duplication (I simply copied the

Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread Gene Buckle
On Sun, 30 Jan 2011, Frederic Bouvier wrote: > > Maybe DirectInput would do a better job here, but we still use the > legacy api inherited from the early days of Windows. > DirectInput support would be a huge win for the Windows build. g. -- Proud owner of F-15C 80-0007 http://www.f15sim.com

Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread Frederic Bouvier
- "Csaba Halász" a écrit : > On Sun, Jan 30, 2011 at 1:58 PM, Frederic Bouvier > wrote: > > > > I noticed three things under Windows : > >  1. the state of menu entry "Help > Joystick information" is not modified > >    when I remove or add a joystick after start > > Confirmed, but unrelate

Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread Frederic Bouvier
> >  2. if I do "Reload input" with the joystick already recognized, axes > >    goes wrong and I have to do a Reset to initialize them. > >  3. if I remove the joystick while the joystick information dialog is > >    displayed and reload input, fgfs segfault. > > Don't see these problems under d

Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread James Turner
On 30 Jan 2011, at 14:24, Csaba Halász wrote: >> 2. if I do "Reload input" with the joystick already recognized, axes >>goes wrong and I have to do a Reset to initialize them. >> 3. if I remove the joystick while the joystick information dialog is >>displayed and reload input, fgfs segf

Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread Csaba Halász
On Sun, Jan 30, 2011 at 1:58 PM, Frederic Bouvier wrote: > > I noticed three things under Windows : >  1. the state of menu entry "Help > Joystick information" is not modified >    when I remove or add a joystick after start Confirmed, but unrelated to the patch. The joystick information window d

Re: [Flightgear-devel] Reload joystick config

2011-01-30 Thread Frederic Bouvier
Hi, > On 28 Jan 2011, at 09:02, James Turner wrote: > > > Looks good to me, from a visual inspection. I'll apply over the > weekend, and poke some people to test. Depending on when 2.2.0 happens > this might even be worth back-porting, but we should wait for some > positive testing feedback befor

Re: [Flightgear-devel] Reload joystick config

2011-01-29 Thread James Turner
On 28 Jan 2011, at 09:02, James Turner wrote: > Looks good to me, from a visual inspection. I'll apply over the weekend, and > poke some people to test. Depending on when 2.2.0 happens this might even be > worth back-porting, but we should wait for some positive testing feedback > before that.

Re: [Flightgear-devel] Reload joystick config

2011-01-28 Thread Csaba Halász
On Fri, Jan 28, 2011 at 10:02 AM, James Turner wrote: > > On 28 Jan 2011, at 08:21, Andreas Gaeb wrote: > >> In the meantime I played around with this a little and came up with the >> attached patch which does what I describe above. This seems to work, >> though I didn't do any checks to rule out

Re: [Flightgear-devel] Reload joystick config

2011-01-28 Thread James Turner
On 28 Jan 2011, at 08:21, Andreas Gaeb wrote: > In the meantime I played around with this a little and came up with the > attached patch which does what I describe above. This seems to work, > though I didn't do any checks to rule out the suspected issues. Looks good to me, from a visual inspect

[Flightgear-devel] Reload joystick config

2011-01-28 Thread Andreas Gaeb
this didn't seem to get through the first time, so I'm resending it... > Hello, > > I notice the Reload Input menu item does not do anything, at least when > tuning the joystick configuration file. This seems to be related to none > of the classes derived from FGInput overriding the reinit method