[fluent-nhib] Re: Conventions overhaul

2009-03-13 Thread James Gregory
Ok I've just committed a change that updates how multiple column names are handled. It's a breaking change, but not a big deal. Anything that uses multiple columns now has a ColumnNames pseudo collection which you can add to and, more importantly, clear. On properties it's called ColumnNames, and o

[fluent-nhib] Re: Conventions overhaul

2009-03-13 Thread Adriano Machado
Isn't the case just to apply the IOneToOneConventions to the inherited mappings (both Discriminated and joined subclasses)? On Mar 12, 4:45 pm, James Gregory wrote: > Ah, I see your problem. You can have multiple column names for the key in a > relationship, so I either need to make this more ex

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread Jon Kruger
Don't know how you want to implement this, but here's is a patch using TheColumnNameIs() on OneToManyPart. Feel free to do it some other way. http://jonkruger.com/onetomanypart-thecolumnnameis.patch On Mar 12, 3:36 pm, Jon Kruger wrote: > I think I'm having the same problem... I'm trying to ov

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread James Gregory
Ah, I see your problem. You can have multiple column names for the key in a relationship, so I either need to make this more explicit, or provide a way to clear them. I'm away from my machine ATM, so unfortunately there's nothing I can do until I get back. I'll have a think on a solution to this, b

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread Jon Kruger
I think I'm having the same problem... I'm trying to override the conventions for one-to-many relationships. I did this: public class HasManyConvention : IHasManyConvention { public bool Accept(IOneToManyPart target) { return true; } public vo

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread Adriano Machado
James, Yes, I am using AutoMapping. After a glimpse on the trunk source code, I've found that on AutoMapper.cs, line 35, the convention is hard-coded. What happens is, given that I now have my set of conventions, it generates a subclass with 2-key foreign key, instead of just one. I am not sur

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread BringerOD
Would like to automap to support joinedsubclasses. http://groups.google.com/group/fluent-nhibernate/browse_thread/thread/902ffa065f320aa2/d391d4318945f257?hl=en&lnk=gst&q=JoinedSubClass#d391d4318945f257 Thanks for your work on this. Its brilliant! On Mar 4, 6:10 am, James Gregory wrote: > Guy

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread James Gregory
I'm not sure what you mean, are you using automapping? On Thu, Mar 12, 2009 at 12:58 PM, Adriano Machado wrote: > > James, > > Regarding inheritance and subclasses, how do I define the convention > for the primary key of the subclasses? > > On Mar 11, 8:22 pm, James Gregory wrote: > > Sounds go

[fluent-nhib] Re: Conventions overhaul

2009-03-12 Thread Adriano Machado
James, Regarding inheritance and subclasses, how do I define the convention for the primary key of the subclasses? On Mar 11, 8:22 pm, James Gregory wrote: > Sounds good, I'm out tomorrow but I'm free all weekend so I'll try to catch > you then. > > On Wed, Mar 11, 2009 at 10:07 PM, Paul Batum

[fluent-nhib] Re: Conventions overhaul

2009-03-11 Thread James Gregory
Sounds good, I'm out tomorrow but I'm free all weekend so I'll try to catch you then. On Wed, Mar 11, 2009 at 10:07 PM, Paul Batum wrote: > Nice work James. I see you implemented shortcuts, they look nice. > > Now, lets have a chat about getting this into the semantic model branch... > :) > > >

[fluent-nhib] Re: Conventions overhaul

2009-03-11 Thread Paul Batum
Nice work James. I see you implemented shortcuts, they look nice. Now, lets have a chat about getting this into the semantic model branch... :) On Thu, Mar 12, 2009 at 8:39 AM, James Gregory wrote: > ...and it's committed! *Hides from the angry mob of devs with broken > builds* > The wiki has be

[fluent-nhib] Re: Conventions overhaul

2009-03-11 Thread James Gregory
...and it's committed! *Hides from the angry mob of devs with broken builds* The wiki has been updated with the new syntax, as well as with some dedicated pages to conventions. - Conventions - Convention Interfaces

[fluent-nhib] Re: Conventions overhaul

2009-03-04 Thread Paul Batum
As James mentioned, he and I have already discussed the topic of new conventions + semantic model. I really don't think its going to be a problem. Obviously, the inner machinery that makes James' conventions work will change when we move to the semantic model, but our users will be isolated from th

[fluent-nhib] Re: Conventions overhaul

2009-03-04 Thread James
Sounds excellent. On Mar 4, 8:10 am, James Gregory wrote: > Guys, > > This email is a heads up, with an opportunity to provide feedback before I > commit these changes to trunk. I want to make it clear that I'm not bashing > the work of the developers before myself who wrote the original convent

[fluent-nhib] Re: Conventions overhaul

2009-03-04 Thread James Gregory
Andrew: Paul and I have already spoke about this stuff and his branch, don't worry about it. I'm not working on anything without first considering the rewrite. As far as I'm concerned, development on trunk is going to slow down and I'm going to commit some time to the semantic model rewrite; then w

[fluent-nhib] Re: Conventions overhaul

2009-03-04 Thread Andrew Stewart
Hi James Generally I agree that a rewrite of conventions needed to be done, you could really see that class was getting crowded and ugly. I'd of probably implemented it very similar to your way, however can any of this be achieved: - Some form of backwards compatibility layer for previous versi

[fluent-nhib] Re: Conventions overhaul

2009-03-04 Thread Martin Hornagold
YE!! Fantastic. We are not worthy James. This will likely solve all my slightly uneasy feelings about conventions and prevent further hair loss due to head scratching. Can't wait to get my hands on it From: fluent-nhibernate@googlegroups.com [mailto:fluent-nhibern...@googl