Re: [fluid-dev] Short note durations on percussion channel

2009-10-08 Thread S. Christian Collins
Josh, Just to clarify, note durations wouldn't be extended if they were already long enough--we'd simply be setting a minimum possible note duration (8-10 ms) to allow the note to get through the attack phase. As far as I can tell from my testing in the past, this appears to be similar to th

Re: [fluid-dev] Short note durations on percussion channel

2009-10-08 Thread josh
Quoting "S. Christian Collins" : Josh, I think your resolution is reasonable, and it seems it will only really affect GM/GS MIDI files, and not other usage, so that's good. The reason I brought up the GS sound effects bank (patch 56 on the percussion channel, if memory serves me correctly) is t

[fluid-dev] Re: Fast file renderer

2009-10-08 Thread josh
Quoting David Henningsson : j...@resonance.org wrote: Hello David, I was looking at that bug that I mentioned before, where FluidSynth gets stuck in fluid_player_join() when doing fast file render and the renderer fails to be created (because of invalid format settings for example). I

Re: [fluid-dev] MIDI mode

2009-10-08 Thread josh
Quoting David Henningsson : j...@resonance.org wrote: Yes I did take your suggestions into consideration. I probably should have responded before just going ahead with implementing things, kind of a bad habit of mine, which probably comes from many years of working solo on projects. Will you

[fluid-dev] Re: Fast file renderer

2009-10-08 Thread David Henningsson
j...@resonance.org wrote: Hello David, I was looking at that bug that I mentioned before, where FluidSynth gets stuck in fluid_player_join() when doing fast file render and the renderer fails to be created (because of invalid format settings for example). I notice that in fluid_player_join()

Re: [fluid-dev] MIDI mode

2009-10-08 Thread David Henningsson
j...@resonance.org wrote: > Yes I did take your suggestions into consideration. I probably should > have responded before just going ahead with implementing things, kind > of a bad habit of mine, which probably comes from many years of > working solo on projects. Will you be annoyed if I start

Re: [fluid-dev] Short note durations on percussion channel

2009-10-08 Thread S. Christian Collins
Josh, I think your resolution is reasonable, and it seems it will only really affect GM/GS MIDI files, and not other usage, so that's good. The reason I brought up the GS sound effects bank (patch 56 on the percussion channel, if memory serves me correctly) is that many of the sounds are loo

Re: [fluid-dev] re: MIDI mode

2009-10-08 Thread josh
Hello Jimmy, Quoting jimmy : May I suggest that "gm" be the default mode for inter-operability with keyboards and sound modules. GM would probably be expected mode for most (80-90%???) of MIDI users, especially the beginners. I'm not sure actually if that is the case. For myself, G

Re: [fluid-dev] MIDI mode

2009-10-08 Thread josh
Hello David, Quoting David Henningsson : So I went ahead and added GM On/Off and GS Reset SYSEX handling. You told me to let you know when I think things should have been done differently; so here it goes. I think implementing a synth.midi-mode setting at this time is bad since it gives the i

Re: [fluid-dev] Short note durations on percussion channel

2009-10-08 Thread josh
If a composer is using percussion sounds on a non-percussion MIDI channel in GM/GS mode, then its up to them to ensure that the note durations are long enough. At least as far as the standard is concerned, which is what we should follow. Josh Quoting David Henningsson : S. Christian Coll

[fluid-dev] re: MIDI mode

2009-10-08 Thread jimmy
> Date: Thu, 08 Oct 2009 01:07:54 -0700 > From: j...@resonance.org > > So I went ahead and added GM On/Off and GS Reset SYSEX > handling.    > There are now 2 parameters synth.midi-mode=normal/gm/gs > and  > synth.midi-mode-lock=no/yes.  If midi-mode-lock is set > . . . > > Feedback and tes

Re: [fluid-dev] Short note durations on percussion channel

2009-10-08 Thread josh
Hello Chris, I realize I didn't respond to these emails and kind of just proceeded to implement things. I'm personally convinced that ignoring note-offs on the percussion channel, when GM/GS mode is enabled, is the way it should be done (its defined in the standard after all and most man

Re: [fluid-dev] MIDI mode

2009-10-08 Thread josh
These changes are meant to address missing percussion in GM and GS MIDI files. The GM standard says that note-offs should be ignored on MIDI channel 10 for all but Long Guiro and Long Whistle. In addition, the MIDI standard requires that for each note-on there is a corresponding note-off.

Re: [fluid-dev] MIDI mode

2009-10-08 Thread S. Christian Collins
Josh, How does this affect the GS sound effects bank? -~Chris j...@resonance.org wrote: So I went ahead and added GM On/Off and GS Reset SYSEX handling. There are now 2 parameters synth.midi-mode=normal/gm/gs and synth.midi-mode-lock=no/yes. If midi-mode-lock is set to yes then SYSEX MIDI

[fluid-dev] MIDI mode

2009-10-08 Thread josh
So I went ahead and added GM On/Off and GS Reset SYSEX handling. There are now 2 parameters synth.midi-mode=normal/gm/gs and synth.midi-mode-lock=no/yes. If midi-mode-lock is set to yes then SYSEX MIDI mode messages have no effect (useful for forcing FluidSynth to a particular mode). If