Re: [VOTE] Remove Visitor Patterns from AbstractRenderer.java

2004-02-24 Thread Glen Mazza
2.) (This I'm less sure on) After reverting, I'd like to remove the "render" functions within the InlineArea objects in favor of direct function calls within AbstractRenderer: -1 Remember one of the three basic OO principles: use virtual methods instead of switch according to a class marker. T

cvs commit: xml-fop/src/java/org/apache/fop/apps Fop.java

2004-02-24 Thread pbwest
pbwest 2004/02/24 20:50:17 Modified:src/java/org/apache/fop/apps Tag: FOP_0-20-0_Alt-Design Fop.java Log: Logger instance made public Revision ChangesPath No revision No revision 1.1.2.7 +2 -2 xml-fop

cvs commit: xml-fop/src/java/org/apache/fop/render/xml XMLRenderer.java

2004-02-24 Thread gmazza
gmazza 2004/02/24 19:32:17 Modified:src/java/org/apache/fop/area/inline Character.java InlineArea.java InlineParent.java Leader.java Space.java TextArea.java Viewport.java src/java/org/apache/fop/render AbstractRenderer.java

Re: [PATCH] Support for percentages and table-units

2004-02-24 Thread J.Pietschmann
Finn Bock wrote: That is not correct. Temporarily storing the area dimension in the FO tree just long enough for the getNextBreakPoss() to return does *not* in any way prevent reusing the FO tree or the LM tree for an other rendering run. It prevents overlapping/concurrent runs. Whether these a

Re: [VOTE] Remove Visitor Patterns from AbstractRenderer.java

2004-02-24 Thread J.Pietschmann
Glen Mazza wrote: 1.) Remove the serveVisitor() +0 2.) (This I'm less sure on) After reverting, I'd like to remove the "render" functions within the InlineArea objects in favor of direct function calls within AbstractRenderer: -1 Remember one of the three basic OO principles: use virtual meth

DO NOT REPLY [Bug 27199] - [PATCH] FOP breadcrumb problem

2004-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27199] - [PATCH] FOP breadcrumb problem

2004-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27199] - [PATCH] FOP breadcrumb problem

2004-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27199] New: - [PATCH] FOP breadcrumb problem

2004-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: xml-fop/src/java/org/apache/fop/area FootnoteRefArea.java BeforeFloatRefArea.java

2004-02-24 Thread pbwest
pbwest 2004/02/24 05:41:27 Added: src/java/org/apache/fop/area Tag: FOP_0-20-0_Alt-Design FootnoteRefArea.java BeforeFloatRefArea.java Log: More Area stubs Revision ChangesPath No revision No revision 1.1.

Re: [VOTE] Remove Visitor Patterns from AbstractRenderer.java

2004-02-24 Thread Jeremias Maerki
+0 if you feel this simplifies things. On 22.02.2004 23:41:03 Glen Mazza wrote: > Team, > > To simplify the Area Tree<-->Renderer interaction somewhat, making this > section of the code easier to follow, I'd like to make two changes to > the code: > > 1.) Remove the serveVisitor() methods...

Re: PS & PCL: How do I test them?

2004-02-24 Thread Jeremias Maerki
PS is mostly tested using GhostScript (and Acrobat Distiller). See http://www.ghostscript.com/ Also download GSview which is a viewer frontend for GhostScript. I haven't done any PCL-testing myself, but I guess with PCL you will need two or three different PCL printers if you want to do it seriou

Re: [PATCH] Support for percentages and table-units

2004-02-24 Thread Finn Bock
[Finn Bock] I don't understand how you propose to solve any of this, but I hope it would be Ok to commit the straight forward solution I propose. [J.Pietschmann] Whatever works. I just want to note that given the almost one- to-one correspondence between FOs and LMs both in classes and instances

Re: [VOTE] Remove Visitor Patterns from AbstractRenderer.java

2004-02-24 Thread Chris Bowditch
Glen Mazza wrote: Team, To simplify the Area Tree<-->Renderer interaction somewhat, making this section of the code easier to follow, I'd like to make two changes to the code: 1.) Remove the serveVisitor() methods in AbstractRenderer.java [1], and return to what we were using last year, that

cvs commit: xml-fop/src/java/org/apache/fop/area RegionBodyRefArea.java

2004-02-24 Thread pbwest
pbwest 2004/02/24 00:53:03 Modified:src/java/org/apache/fop/area Tag: FOP_0-20-0_Alt-Design RegionBodyRefArea.java Log: Updated Licence to 2.0 Adjusted clone() Revision ChangesPath No revision No revision