fo.InlineLevel -- make abstract?

2005-01-03 Thread Glen Mazza
Simon, Any problem with making fo.InlineLevel an abstract class? Any reason why you made it instantiable--or was this just an oversight? (Actually, anyone know why we're not making FObj and FObjMixed abstract as well? I might be missing something here...) Thanks, Glen

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo FObj.java IntrinsicSizeAccess.java

2005-01-03 Thread Glen Mazza
+1! Ausgezeichnet! Danke... Glen --- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > Sorry, I'm so used to using A-F Enums that I didn't > think about that. > I've fixed this and hope that you can agree with my > change now. >

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo FObj.java IntrinsicSizeAccess.java

2005-01-03 Thread Jeremias Maerki
Sorry, I'm so used to using A-F Enums that I didn't think about that. I've fixed this and hope that you can agree with my change now. On 03.01.2005 14:51:00 Glen Mazza wrote: > Jeremias, > > Would you please elaborate on the need for this? I > want to make sure that adding an additional dependen

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo FObj.java IntrinsicSizeAccess.java

2005-01-03 Thread Glen Mazza
Jeremias, Would you please elaborate on the need for this? I want to make sure that adding an additional dependency on the Avalon project is passing a cost-benefit analysis here. We're not a fluffy hi-level word processing system --we are a very low-level application (like a compiler), that is i

Re: cvs commit: xml-fop/src/java/org/apache/fop/datatypes LengthBase.java

2005-01-03 Thread Jeremias Maerki
I'm trying to understand what's going on here. One thing that strikes me as odd is that PropertyList.convertAttributeToProperty() always contructs Properties based on the parentFO. Normally, this is probably ok since most calculation bases are the parent FOs but in the case of content-width/height