Re: Checking for OutputSource for renderer overrides

2005-01-11 Thread Glen Mazza
--- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > > > > Personally, I would rather we get rid of > > RendererFactory and put the logic back where it > > was--in FOTreeBuilder and RenderPagesModel. This > > functionality is just too specific to be reused > > elsewhere in FOP. > > I don't see your

Re: Checking for OutputSource for renderer overrides

2005-01-11 Thread Jeremias Maerki
On 08.01.2005 19:27:38 Glen Mazza wrote: > --- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > > If someone embeds FOP in > > his/her application the > > not supplying an OutputStream when a renderer needs > > one is a bug and so > > it doesn't matter if the error message comes early > > or only w

Re: Checking for OutputSource for renderer overrides

2005-01-08 Thread Glen Mazza
--- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > I think you're confusing things. Yes, I think I was. > If someone embeds FOP in > his/her application the > not supplying an OutputStream when a renderer needs > one is a bug and so > it doesn't matter if the error message comes early > or only w

Re: Checking for OutputSource for renderer overrides

2005-01-07 Thread Jeremias Maerki
On 07.01.2005 11:01:28 Glen Mazza wrote: > --- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > > > You're right, my change was suboptimal. When I think > > about this I must > > say that I'd prefer to remove that check entirely > > and let the individual > > renderers check if they have everything t

Re: Checking for OutputSource for renderer overrides

2005-01-07 Thread Glen Mazza
--- Jeremias Maerki <[EMAIL PROTECTED]> wrote: > You're right, my change was suboptimal. When I think > about this I must > say that I'd prefer to remove that check entirely > and let the individual > renderers check if they have everything to write to > their target. I don't think so, because w

Re: Checking for OutputSource for renderer overrides

2005-01-06 Thread Jeremias Maerki
You're right, my change was suboptimal. When I think about this I must say that I'd prefer to remove that check entirely and let the individual renderers check if they have everything to write to their target. The renderer knows best what it needs. Having this check in the RendererFactory only puts