Re: Style issues.

2002-08-21 Thread Karen Lease
Your explanation couldn't be clearer. I now understand why the underscore doesn't bother me so much even though I'm not such a Heathen as not to use Emacs: 1) I type on a french keyboard and I don't have to shift to get the underscore character (only to get most every other useful character fo

Re: Style issues.

2002-08-21 Thread J.Pietschmann
Karen Lease wrote: > Arved Sandstrom wrote: >> I may be a person who is ill-qualified to comment on variable names. > > Hmm, perhaps that is my problem too; I still remember the PDP3 I had to > boot with the front panel switches to make it read the paper tape > and when I screwed up, I had

Re: Style issues.

2002-08-21 Thread Karen Lease
Arved Sandstrom wrote: >>-Original Message- >>From: Peter B. West [mailto:[EMAIL PROTECTED]] >>Sent: August 20, 2002 9:51 PM >>To: [EMAIL PROTECTED] >>Subject: Re: Style issues. >> > [ SNIP ] > >> > The only encoding rule I'

Re: Style issues.

2002-08-21 Thread J.Pietschmann
Peter B. West wrote: > > a more iterator like pattern: > >while (hasNextLM()) { > >curLM = nextLM(); ... > the first idiom is actually easier to follow. I suppose you could say, > if you needed such a crutch, that it was a pattern. The problem is, the Java libraries use th

Re: Style issues.

2002-08-21 Thread Peter B. West
Jim Wright wrote: > >> Ah, the rich diversity of life on earth! (Incidentally, I think the >> red stars might be disappearing from mozilla. Perhaps the name of God >> has been spoken in some remote monastery.) > > Now, THERE's an obscure reference to an old Ray Bradbury(?) story. Yeesh ;-) -

Re: Style issues.

2002-08-21 Thread Jim Wright
. > > Peter > > Arved Sandstrom wrote: >>> -Original Message- >>> From: Peter B. West [mailto:[EMAIL PROTECTED]] >>> Sent: August 20, 2002 9:51 PM >>> To: [EMAIL PROTECTED] >>> Subject: Re: Style issues. >> [ SNIP ] >&

Re: Style issues.

2002-08-21 Thread Peter B. West
been spoken in some remote monastery.) Peter Arved Sandstrom wrote: >>-Original Message- >>From: Peter B. West [mailto:[EMAIL PROTECTED]] >>Sent: August 20, 2002 9:51 PM >>To: [EMAIL PROTECTED] >>Subject: Re: Style issues. > > [ SNIP ] > >>

Re: Style issues.

2002-08-20 Thread Kevin O'Neill
> >> if ((bp = getNextBreakPoss(childLC, null)) != null) { > > Probably comes from long years of writing C and C++ and avoiding extra > > lines of code. Must be taste since I don't find it that bad, but if we > > all vote it out in the style rules, I'll agree to banish it! > > It comes fr

RE: Style issues.

2002-08-20 Thread Arved Sandstrom
> -Original Message- > From: Peter B. West [mailto:[EMAIL PROTECTED]] > Sent: August 20, 2002 9:51 PM > To: [EMAIL PROTECTED] > Subject: Re: Style issues. [ SNIP ] > > The only encoding rule I'd realy like to have: > > Don't mix underscores with c

Re: Style issues.

2002-08-20 Thread Peter B. West
J.Pietschmann wrote: > Karen Lease wrote: > >>> if ((bp = getNextBreakPoss(childLC, null)) != null) { >> >> Probably comes from long years of writing C and C++ and avoiding extra >> lines of code. Must be taste since I don't find it that bad, but if we >> all vote it out in the style ru

Re: Style issues.

2002-08-20 Thread J.Pietschmann
Karen Lease wrote: >> if ((bp = getNextBreakPoss(childLC, null)) != null) { > Probably comes from long years of writing C and C++ and avoiding extra > lines of code. Must be taste since I don't find it that bad, but if we > all vote it out in the style rules, I'll agree to banish it! It com

Re: Style issues.

2002-08-19 Thread Karen Lease
Hi all, I see this started a few days ago, but I just came back from a couple of weeks of vacation (and a couple of months of being totally buried in work), so before I go back to the office, I'll at least let you know I'm still around and even reading the list now and then :-) I also recogniz

RE: Style issues.

2002-08-15 Thread Arved Sandstrom
> -Original Message- > From: Kevin O'Neill [mailto:[EMAIL PROTECTED]] > Sent: August 15, 2002 9:14 PM > To: FOP Developers > Subject: Re: Style issues. > [ SNIP ] > Now you might say "but a developer might forget to do it so it's > worthless over

Re: Style issues.

2002-08-15 Thread Kevin O'Neill
Peter, > What's the riposte? Comments lie, especially through entropy. The > compiler takes no notice of any other intention you are encoding in the > name. I disagree, the analogy is not correct. Comments lie, code shouldn't. I'm not advocating that we write lots of inline comments, in fact

Re: Style issues.

2002-08-15 Thread Peter B. West
Jeremias, Kevin, What's the riposte? Comments lie, especially through entropy. The compiler takes no notice of any other intention you are encoding in the name. >>currentPageNumber = m_pageNumber + 1; Have mercy. Peter Jeremias Maerki wrote: > On 15.08.2002 13:01:51 Kevin O'Neill wrote:

RE: Style issues.

2002-08-15 Thread Victor Mote
Keith Groves wrote: > Regarding 1. Tabs: > I've worked on a project with someone (Dale, cc'd) who set up the project > CVS store to not allow checkins of source containing tabs. The > server would > return a polite message telling the developer to change the tabs to spaces > and try again. > W

Re: Style issues.

2002-08-15 Thread Jeremias Maerki
On 15.08.2002 13:01:51 Kevin O'Neill wrote: > On Thu, 2002-08-15 at 20:59, Jeremias Maerki wrote: > > I know that's probably unpopular but I usually like to reference member > > variables like this: > > this.currentPageNumber = pageNumber + 1; > > I used to use that convention except that someon

Re: Style issues.

2002-08-15 Thread Kevin O'Neill
On Thu, 2002-08-15 at 20:59, Jeremias Maerki wrote: > I know that's probably unpopular but I usually like to reference member > variables like this: > this.currentPageNumber = pageNumber + 1; I used to use that convention except that someone always forgets to do it and your back where you started

Re: Style issues.

2002-08-15 Thread Jeremias Maerki
I know that's probably unpopular but I usually like to reference member variables like this: this.currentPageNumber = pageNumber + 1; That is a bit more to write but I don't particularly like underscores in names. On 15.08.2002 12:40:06 Kevin O'Neill wrote: > > > 5. I don't think naming styles

Re: Style issues.

2002-08-15 Thread Kevin O'Neill
> 5. I don't think naming styles should be mixed without good > (and preferably explained) reason: > boolean m_bInited = false; > Yuck! Actually I really like to be able to tell members from parameters and local variables. I tend to use an _ before member variables (eg _currentPage

Re: Style issues.

2002-08-15 Thread Kevin O'Neill
> I'll volunteer to write the style doc and go over the whole codebase > after my two-week absence starting Sunday. An additional possibility is > to use checkstyle to help analyze and maintain the quality of the code. > The Avalon subproject does that. I'll check what it can do for us. I can hig

Re: Style issues.

2002-08-15 Thread Keiron Liddle
On Thu, 2002-08-15 at 11:36, Jeremias Maerki wrote: > I'll volunteer to write the style doc and go over the whole codebase > after my two-week absence starting Sunday. An additional possibility is > to use checkstyle to help analyze and maintain the quality of the code. > The Avalon subproject doe

RE: Style issues.

2002-08-15 Thread Keith Groves
/08/02 00:32 Subject: Re: Style issues. pietsch, Style judgements are a very personal matter. Personal tastes follow. J.Pietschmann wrote: > 1. I'd appreciate if indentation uses spaces instead of >tabs. And because I can avoid using tabs, I expect >everyone else avoidin

Re: Style issues.

2002-08-15 Thread Jeremias Maerki
Hi there I agree with most of the points you brought up. I've wondered myself in the last few days if I should dare to make another attempt to bring this up. The XML project refers to the Sun Coding Conventions for Java style. But as you will all agree this is not enough. It leaves too much room

Re: Style issues.

2002-08-15 Thread Keiron Liddle
Hello, All I can say is that most of your issues are related to work done by someone who is not here right now. For what its worth I agree with you. On Wed, 2002-08-14 at 22:08, J.Pietschmann wrote: > Hello all, > I just took a more extended look at CVS HEAD. There are > some style issues which

Re: Style issues.

2002-08-14 Thread Peter B. West
pietsch, Style judgements are a very personal matter. Personal tastes follow. J.Pietschmann wrote: > 1. I'd appreciate if indentation uses spaces instead of >tabs. And because I can avoid using tabs, I expect >everyone else avoiding tabs too. This is pretty much a necessity because of