Re: Patching with GIT/SVN (Re: Making MinOptMax Immutable)

2009-11-04 Thread Vincent Hennebert
Hi, Looks like Max is busy with more urgent things :-) As this patch will affect my future work on the layout engine, I’d like to take over the patch review. Your suggestion to use Skype sounds good. That will ease the job a bit. I’ll contact you off-line to exchange details and arrange a time.

Re: Patching with GIT/SVN (Re: Making MinOptMax Immutable)

2009-11-04 Thread Max Berger
Hi *, Vincent Hennebert schrieb: Hi, Looks like Max is busy with more urgent things :-) Yes, work keeps me occupied most of the time. I was actually just looking at the patch again, and decided that I am unable to apply it, because I do cannot verify if the renames are correct, as it affects

Re: Patching with GIT/SVN (Re: Making MinOptMax Immutable)

2009-11-04 Thread Alexander Kiel
Hi Max, One more thing I noticed: Alex, you are introducing deprecated methods and then using them. Please either - don't mark the methods as deprecated, if they are valid helper methods or - don't use the deprecated methods, but rather use whatever you inted to replace it with. I marked