On Fri, Aug 13, 2010 at 10:57 AM, Glenn Adams wrote:
> 3. Adjust the Checkstyle profile to allow "log" and disallow whitespace
>> before and after parantheses. Then remove "log"-related //CS constants
>> and excessive whitespace.
>>
>
> I would not agree to restricting the style rules to prohibit
inline
On Thu, Aug 12, 2010 at 8:25 PM, Jeremias Maerki wrote:
>
> 1. Clarify the thing with LineBreak*.
>
It was necessary to update the line break data in order to regenerate
LineBreakUtils.java; otherwise, the generation process failed to to a
missing column ('CP') when it attempts to pull do
Thanks, Vincent.
On 12.08.2010 18:31:50 Vincent Hennebert wrote:
> Hi,
>
> Jeremias Maerki wrote:
> > I've now applied the patch locally and done a detailed review. I'm
> > posting this a bit outside the context of recent discussions to simply
> > state my present opinion after looking into the p
Hi,
Jeremias Maerki wrote:
> I've now applied the patch locally and done a detailed review. I'm
> posting this a bit outside the context of recent discussions to simply
> state my present opinion after looking into the patch.
>
> Generally, this is a big improvement. So thanks, Glenn, for your wo
linkmap.xml? I don't think we have a file with that name in FOP. Could
that be coming from Apache Forrest somehow, maybe due to a buggy XML
parser maybe? Maybe putting a current Xerces and Xalan in the JRE's
lib/endorsed directory may change something. Otherwise, please provide a
snippet from the o
I agree that we should remove this. The manifest's Classpath is quite
restricted in its usefulness. Furthermore, I've long ago added some code
that builds up the classpath dynamically when necessary. Hardly anyone
will call FOP by "java -jar fop.jar". Most people will use one of the
scripts (I do,
https://issues.apache.org/bugzilla/show_bug.cgi?id=1063
--- Comment #18 from M.H. 2010-08-12 08:27:58 EDT ---
Even with FOP 0.95, we sometimes have OutOfMemory issues with larger FO files
(or FO files producing large PDF files with several dozen or hundred pages. We
tweaked our main server applic
I've now applied the patch locally and done a detailed review. I'm
posting this a bit outside the context of recent discussions to simply
state my present opinion after looking into the patch.
Generally, this is a big improvement. So thanks, Glenn, for your work
here!
I'm also not particularly ha
vincent,
my apologies if I offended, as that was not my intent; i'm sure we will
manage to work our way through this towards a successful conclusion;
respectfully,
glenn
On Thu, Aug 12, 2010 at 7:41 PM, Vincent Hennebert wrote:
> This message lacks of courtesy, therefore I do not wish to contin
This message lacks of courtesy, therefore I do not wish to continue the
discussion.
I’ll proceed as I explained in my previous message.
Or maybe it’s just me not being a native English speaker...
Vincent
Glenn Adams wrote:
> Inline below.
>
> On Wed, Aug 11, 2010 at 7:45 PM, Vincent Henneber
https://issues.apache.org/bugzilla/show_bug.cgi?id=49727
Ruud changed:
What|Removed |Added
OS/Version||Windows 7
--
Configure bugmail: https://is
https://issues.apache.org/bugzilla/show_bug.cgi?id=1063
Antti Karanta changed:
What|Removed |Added
CC||antti.kara...@napa.fi
--
Configure
On Thu, Aug 12, 2010 at 3:18 PM, Glenn Adams wrote:
> that is a reasonable objection to removing the file, so indeed i would not
> object to leaving it in place; however, i did not test checkstyle 1.4, and
> indeed, there are a few changes that appear at the end of the new
> checkstyles-5.1.xml f
@ Chris
On Wed, Aug 11, 2010 at 11:20 PM, Chris Bowditch wrote:
>
> First of all let me start by saying many thanks to Glenn for the hours and
> hours of effort that he must of put into going through the code and
> resolving the checkstyle warnings. Thanks Glenn!
>
>
Your welcome. I logged ~40 h
14 matches
Mail list logo
