[jira] [Commented] (FOP-2293) Whitespace management extension

2013-08-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753851#comment-13753851 ] Vincent Hennebert commented on FOP-2293: Hi Seifeddine, thanks for your patc

Re: [VOTE][RESULT] Merge Temp_FopFontsForSVG into trunk

2013-08-28 Thread Vincent Hennebert
Time to sum up. We have 6 +1, the vote passes. That said, there have been reservations expressed about the dependency on a patched version of Batik. So I’ll defer the merge until the PMC has found a viable solution for Batik’s future. Thanks, Vincent On 21/08/13 12:08, Vincent Hennebert wrote

[jira] [Commented] (FOP-2292) [PATCH] NullPointerException after page IPD change

2013-08-27 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751422#comment-13751422 ] Vincent Hennebert commented on FOP-2292: What I actually meant is to mak

[jira] [Commented] (FOP-2292) [PATCH] NullPointerException after page IPD change

2013-08-27 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751166#comment-13751166 ] Vincent Hennebert commented on FOP-2292: The error seems to indicate a bug in

[jira] [Commented] (FOP-2292) [PATCH] NullPointerException after page IPD change

2013-08-27 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751080#comment-13751080 ] Vincent Hennebert commented on FOP-2292: I can reproduce it with 1.1, but not

[jira] [Resolved] (FOP-2291) break-after="page" produces blank page but doesn't use blank page master

2013-08-21 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-2291. Resolution: Invalid Indeed the output is correct WRT the spec. See section 7.27.2, "

[VOTE] Merge Temp_FopFontsForSVG into trunk

2013-08-21 Thread Vincent Hennebert
This work allows to directly use FOP-configured fonts for SVG images, instead of trying to find, via AWT, equivalent fonts installed on the system, and then mapping them to FOP fonts when generating the output. Please note that this introduces a dependency on the trunk version of Batik, with the p

Re: svn commit: r1508599 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: cli/CommandLineOptions.java fonts/apps/AbstractFontReader.java fonts/apps/PFMReader.java fonts/apps/TTFReader.java util/Co

2013-07-30 Thread Vincent Hennebert
Some background on this: for years I had been able to activate debug output just by uncommenting the LOGLEVEL line in the fop script (line 246), that I had customized to use a JDK 1.4 logger. Suddenly, some time last year that ceased working. I finally decided to investigate and it turned out to b

Re: svn commit: r1508208 [1/10] - in /xmlgraphics/fop/branches/Temp_FopFontsForSVG: ./ lib/ src/codegen/fonts/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/afp/fonts/ src/java/org/apache/fop/a

2013-07-29 Thread Vincent Hennebert
For those interested in playing with the code in this branch, you will have to use a trunk version of Batik with the patch from the following issue applied: https://issues.apache.org/jira/browse/BATIK-1041 Vincent On 29/07/13 23:45, vhenneb...@apache.org wrote: > Author: vhennebert > Date: Mon J

[jira] [Updated] (FOP-2275) Quadratic Bézier curves not properly rendered

2013-07-16 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2275: --- Attachment: quadratic-bezier.pdf quadratic-bezier.svg quadratic

[jira] [Created] (FOP-2275) Quadratic Bézier curves not properly rendered

2013-07-16 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2275: -- Summary: Quadratic Bézier curves not properly rendered Key: FOP-2275 URL: https://issues.apache.org/jira/browse/FOP-2275 Project: Fop Issue Type: Bug

[jira] [Closed] (FOP-1333) External graphic doesnt size properly with height set at 100%

2013-07-01 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert closed FOP-1333. -- Resolution: Not A Problem The two overflow messages can be explained: * Regarding the region

[jira] [Closed] (FOP-2272) The content of fo:table-cell was lost at the end of a page

2013-07-01 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert closed FOP-2272. -- Resolution: Not A Problem You have a keep-together.within-column="always" on

Re: Adding a new layout manager

2013-06-21 Thread Vincent Hennebert
On 21/06/13 09:21, sdridi wrote: > OK, now I have something working. I borrowed some code from > ListBlockLayoutManager, which is simple enough to understand. > > Luis, is it okay to inherit from BlockStackinLayoutManager even though my > extension does not have any FO properties? What's the best

Re: Adding a new layout manager

2013-06-21 Thread Vincent Hennebert
On 20/06/13 15:56, sdridi wrote: > Glenn Adams-2 wrote >> I would suggest you not just read code but run it with Eclipse or NetBeans >> to trace the execution process. That is one of the best ways to learn >> actual code behavior. > > Yes of course, debugging is my only way to break FOP mystery >

Re: FOP using ICU?

2013-06-19 Thread Vincent Hennebert
On 19/06/13 10:33, Glenn Adams wrote: > On Wed, Jun 19, 2013 at 4:00 PM, Vincent Hennebert > wrote: > >> On 19/06/13 02:40, Glenn Adams wrote: >>> On Wed, Jun 19, 2013 at 1:05 AM, Chris Bowditch >>> wrote: >>> >>>> Hi Glenn, >>>>

Re: FOP using ICU?

2013-06-19 Thread Vincent Hennebert
On 19/06/13 02:40, Glenn Adams wrote: > On Wed, Jun 19, 2013 at 1:05 AM, Chris Bowditch > wrote: > >> Hi Glenn, >> >> >> On 18/06/2013 11:12, Glenn Adams wrote: >> >>> To be more clear, I propose we replace FOP's implementation of UAX14 with >>> use of ICU's line break iterator, and that ICU becom

Re: FOP using ICU?

2013-06-18 Thread Vincent Hennebert
t it is costing us in interoperability (I mean lack >> thereof) by failing to use ICU. I don't see any issue about size. >> >> >> On Tue, Jun 18, 2013 at 6:00 PM, Vincent Hennebert >> wrote: >> >>> On 18/06/13 06:46, Glenn Adams wrote: >>>&

Re: FOP using ICU?

2013-06-18 Thread Vincent Hennebert
On 18/06/13 06:46, Glenn Adams wrote: > Is there a reason FOP doesn't use ICU for determining line break > boundaries? The FOP implementation of UAX14 (org.apache.fop.text.linebreak) > seems to be out of date and basically unmaintained. According to [1], a > number of Apache projects are using it,

[jira] [Commented] (FOP-2193) Intermediate format introduces white space in SVG while it should not

2013-05-08 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651695#comment-13651695 ] Vincent Hennebert commented on FOP-2193: You have to generate the PDF from th

[jira] [Commented] (FOP-2222) Incorrect page break in cell

2013-05-07 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651355#comment-13651355 ] Vincent Hennebert commented on FOP-: This issue indeed corresponds to wha

[jira] [Commented] (FOP-2193) Intermediate format introduces white space in SVG while it should not

2013-05-07 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651252#comment-13651252 ] Vincent Hennebert commented on FOP-2193: I can still reproduce it with the la

Re: svn commit: r1480018 [1/2] - in /xmlgraphics/fop/trunk: ./ src/codegen/unicode/java/org/apache/fop/complexscripts/bidi/ src/codegen/unicode/java/org/apache/fop/text/linebreak/ src/java/org/apache/

2013-05-07 Thread Vincent Hennebert
On 07/05/13 20:53, vhennebert wrote: > Author: vhennebert > Date: Tue May 7 18:53:29 2013 > New Revision: 1480018 > > URL: http://svn.apache.org/r1480018 > Log: > Cosmetics only: removed Checkstyle SuppressWithNearbyCommentFilter and fixed > corresponding issues > Modified: xmlgraphics/fop/trun

Re: [jira] [Assigned] (FOP-2210) [PATCH] Complex script IF to output missing glyphs

2013-04-26 Thread Vincent Hennebert
On 25/04/13 22:33, Glenn Adams wrote: > On Thu, Apr 25, 2013 at 1:08 PM, Vincent Hennebert > wrote: > >> On 25/04/13 17:48, Glenn Adams wrote: >>> On Thu, Apr 25, 2013 at 2:31 AM, Vincent Hennebert >> wrote: >>> >>>> >>>> It do

Re: [jira] [Assigned] (FOP-2210) [PATCH] Complex script IF to output missing glyphs

2013-04-25 Thread Vincent Hennebert
On 25/04/13 17:48, Glenn Adams wrote: > On Thu, Apr 25, 2013 at 2:31 AM, Vincent Hennebert > wrote: > >> >> It doesn’t shock me to store text as text in the IF and to re-do the >> glyph mapping when rendering it to the final output format. This is >> actually ho

Re: [jira] [Assigned] (FOP-2210) [PATCH] Complex script IF to output missing glyphs

2013-04-25 Thread Vincent Hennebert
On 25/04/13 10:35, Alexios Giotis wrote: > For our use cases, it would be much better to add new child elements to IF or > do other similar extensions, that having to repeat part of the costly layout > process. Besides repeating, the FO -> IF is easily executed by multiple > threads, while the I

[jira] [Commented] (FOP-1099) footnotes within tables and listsl get lost

2013-04-18 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635441#comment-13635441 ] Vincent Hennebert commented on FOP-1099: Repeating the footnote on every

[jira] [Commented] (FOP-2230) RowSpanning will not effect, if there is not a column with all rows

2013-04-18 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635015#comment-13635015 ] Vincent Hennebert commented on FOP-2230: That confirms what I was going to say:

Re: Rendering issue: table with multiple cell spans

2013-04-17 Thread Vincent Hennebert
Hi Seifeddine, Welcome to FOP! On 17/04/13 17:00, sdridi wrote: > Hello, > > I'm new to the Apache FOP project and I would like to help fixing this bug > https://issues.apache.org/jira/browse/FOP-2230 > . Considering the huge > code base of FOP,

[jira] [Commented] (FOP-2230) RowSpanning will not effect, if there is not a column with all rows

2013-04-17 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634321#comment-13634321 ] Vincent Hennebert commented on FOP-2230: After a closer look at this example,

[jira] [Commented] (FOP-2211) [PATCH] Fix & improve the handling of temporary files using the new URI resource resolvers

2013-04-16 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633107#comment-13633107 ] Vincent Hennebert commented on FOP-2211: To elaborate a bit, I think we now

[jira] [Comment Edited] (FOP-2221) [PATCH] Make overflow messages easier to read and fix wrong/ missing messages

2013-04-16 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633014#comment-13633014 ] Vincent Hennebert edited comment on FOP-2221 at 4/16/13 5:0

[jira] [Updated] (FOP-2221) [PATCH] Make overflow messages easier to read and fix wrong/ missing messages

2013-04-16 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2221: --- Attachment: overflow-message.fo Error message wrongly indicates that the extent is overflowed

Re: [Xmlgraphics-fop Wiki] Trivial Update of "Patrick93" by Patrick93

2013-04-09 Thread Vincent Hennebert
> > On 4/8/13 7:39 PM, Glenn Adams wrote: >> >> On Mon, Apr 8, 2013 at 5:54 AM, Vincent Hennebert > <mailto:vhenneb...@gmail.com>> wrote: >> >> On 29/03/13 22:49, Glenn Adams wrote: >> > Is there a way we can stop this type of spam? Fo

[jira] [Resolved] (FOP-2234) NPE when rendering a document with markers and accessibility is enabled

2013-04-08 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-2234. Resolution: Fixed Fixed in rev. 1465599: http://svn.apache.org/r1465599

Re: [Xmlgraphics-fop Wiki] Trivial Update of "Patrick93" by Patrick93

2013-04-08 Thread Vincent Hennebert
On 29/03/13 22:49, Glenn Adams wrote: > Is there a way we can stop this type of spam? For example, by moderating > wiki updates, or by placing stronger requirements on wiki registration, > write access, etc? Yes: http://wiki.apache.org/general/OurWikiFarm#per_wiki_access_control_-_tighten_your_wik

[jira] [Updated] (FOP-2234) NPE when rendering a document with markers and accessibility is enabled

2013-04-08 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2234: --- Attachment: markers.fo > NPE when rendering a document with markers and accessibility

[jira] [Created] (FOP-2234) NPE when rendering a document with markers and accessibility is enabled

2013-04-08 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2234: -- Summary: NPE when rendering a document with markers and accessibility is enabled Key: FOP-2234 URL: https://issues.apache.org/jira/browse/FOP-2234 Project: Fop

[jira] [Resolved] (FOP-2231) typo

2013-03-27 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-2231. Resolution: Invalid FOP is to be pronounced as a word. See here for more details: http

Re: svn commit: r1457180 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr: BlockContainerLayoutManager.java BlockLevelEventProducer.xml inline/InlineLevelEventProducer.java inline/InlineL

2013-03-20 Thread Vincent Hennebert
On 19/03/13 00:49, Luis Bernardo wrote: > On 3/18/13 9:04 AM, Vincent Hennebert wrote: >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/BlockContainerLayoutManager.java >>> (original) >>> +++ >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/lay

Re: svn commit: r1457180 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr: BlockContainerLayoutManager.java BlockLevelEventProducer.xml inline/InlineLevelEventProducer.java inline/InlineL

2013-03-20 Thread Vincent Hennebert
raphics.apache.org > Subject: Re: svn commit: r1457180 - in > /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr: > BlockContainerLayoutManager.java BlockLevelEventProducer.xml > inline/InlineLevelEventProducer.java inline/InlineLevelEventProducer.xml > inline/LineLayoutManager.java > &

[jira] [Resolved] (FOP-2226) Image resources are not closed when rendering into the Intermediate Format

2013-03-19 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-2226. Resolution: Fixed Fixed in rev. 1458382: http://svn.apache.org/r1458382

[jira] [Created] (FOP-2226) Image resources are not closed when rendering into the Intermediate Format

2013-03-19 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2226: -- Summary: Image resources are not closed when rendering into the Intermediate Format Key: FOP-2226 URL: https://issues.apache.org/jira/browse/FOP-2226 Project

Re: svn commit: r1457180 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr: BlockContainerLayoutManager.java BlockLevelEventProducer.xml inline/InlineLevelEventProducer.java inline/InlineL

2013-03-18 Thread Vincent Hennebert
Please revert this patch as it introduces too many inaccuracies. See inline comments. On 16/03/13 01:27, lbernardo wrote: Author: lbernardo Date: Sat Mar 16 00:27:00 2013 New Revision: 1457180 URL: http://svn.apache.org/r1457180 Log: FOP-2221: Make overflow messages easier to read and fix wron

Why store glyph mappings on FOText?

2013-03-13 Thread Vincent Hennebert
Hi, this question is for Glenn I guess. What is the rationale behind storing glyph mappings on FOText (by a call to addMapping) rather than the instance of TextLM.AreaInfo that is about to be created? IIC that would avoid creating MapRange instances and increasing the mutability of FOText. Also,

[jira] [Commented] (FOP-2213) Kerning is no longer applied

2013-02-19 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581630#comment-13581630 ] Vincent Hennebert commented on FOP-2213: If a font provides a kern table bu

[jira] [Updated] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2213: --- Attachment: kerning_1.1.pdf kerning_1.0.pdf fop.xconf

[jira] [Created] (FOP-2213) Kerning is no longer applied

2013-02-15 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2213: -- Summary: Kerning is no longer applied Key: FOP-2213 URL: https://issues.apache.org/jira/browse/FOP-2213 Project: Fop Issue Type: Bug

[jira] [Created] (FOP-2212) o.a.f.fonts.Font.getKernValue should take glyph indices and not characters as parameters

2013-02-15 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2212: -- Summary: o.a.f.fonts.Font.getKernValue should take glyph indices and not characters as parameters Key: FOP-2212 URL: https://issues.apache.org/jira/browse/FOP-2212

[jira] [Commented] (FOP-2211) [PATCH] Fix & improve the handling of temporary files using the new URI resource resolvers

2013-02-12 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577008#comment-13577008 ] Vincent Hennebert commented on FOP-2211: Hi Alexios, thanks for your patches

[jira] [Resolved] (FOP-2148) page-position="only" in conditional-page-master-reference does not work

2013-02-08 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-2148. Resolution: Fixed Fix Version/s: trunk Thanks for your bug report. Support for page

Re: Fwd: FOP 1.1 - Unable to copy/paste text is not working

2013-01-31 Thread Vincent Hennebert
[Moving over to fop-dev as this is getting technical] On 30/01/13 15:58, Glenn Adams wrote: > On Wed, Jan 30, 2013 at 6:44 AM, Neeraj wrote: > >> >> Yes, my editor can handle used font. >> If you highlight the text in the editor and set the font to Arial do you >> see any >> glyph? For PDF text

[jira] [Resolved] (FOP-1719) [PATCH] fop hangs, 100% cpu usage while rendering pdf

2013-01-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-1719. Resolution: Fixed Fixed in rev. 1440094: http://svn.apache.org/viewvc?rev=1440094&view

[jira] [Resolved] (FOP-1719) [PATCH] fop hangs, 100% cpu usage while rendering pdf

2013-01-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert resolved FOP-1719. Resolution: Fixed Fixed in rev. 1440094: http://svn.apache.org/viewvc?rev=1440094&view

[jira] [Updated] (FOP-1719) [PATCH] fop hangs, 100% cpu usage while rendering pdf

2013-01-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-1719: --- Attachment: footnote_footnote-only-final-page_multiple_whole.xml IIOBE thrown when running

[jira] [Updated] (FOP-1719) [PATCH] fop hangs, 100% cpu usage while rendering pdf

2013-01-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-1719: --- Attachment: footnote_footnote-only-final-page_multiple_whole.xml IIOBE thrown when running

[jira] [Reopened] (FOP-1719) [PATCH] fop hangs, 100% cpu usage while rendering pdf

2013-01-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert reopened FOP-1719: The code throws an IndexOutOfBoundsException with the attached test case

[jira] [Reopened] (FOP-1719) [PATCH] fop hangs, 100% cpu usage while rendering pdf

2013-01-29 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert reopened FOP-1719: The code throws an IndexOutOfBoundsException with the attached test case

Re: svn commit: r1435344 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fonts/LazyFont.java status.xml

2013-01-22 Thread Vincent Hennebert
ch affect. However, >> when profiling, this was identified as a hot spot. >> >> >> On Mon, Jan 21, 2013 at 11:52 AM, Vincent Hennebert >> wrote: >> >>> Hi Glenn, >>> >>> does that significantly improve performance? I would be really su

Re: svn commit: r1435344 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fonts/LazyFont.java status.xml

2013-01-21 Thread Vincent Hennebert
Hi Glenn, does that significantly improve performance? I would be really surprised if it would, given that the method call is probably inlined by the JIT compiler anyway. Do you have figures to share? Thanks, Vincent On 18/01/13 22:13, gadams wrote: > Author: gadams > Date: Fri Jan 18 21:13:42

Re: remove fop1.1rc1 binaries?

2013-01-21 Thread Vincent Hennebert
Hi Glenn, I think they can definitely be removed from the mirrors (the source as well for that matter). But I think that, rather than removing them altogether, they should be moved to the archives: http://archive.apache.org/dist/xmlgraphics/fop/binaries/ where actually they already appear. Not to

[jira] [Updated] (FOP-2193) Intermediate format introduces white space in SVG while it should not

2013-01-18 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2193: --- Attachment: actual.pdf if.xml expected.pdf • expected output

[jira] [Updated] (FOP-2193) Intermediate format introduces white space in SVG while it should not

2013-01-18 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2193: --- Attachment: fop.xconf Configuration file > Intermediate format introdu

[jira] [Created] (FOP-2193) Intermediate format introduces white space in SVG while it should not

2013-01-18 Thread Vincent Hennebert (JIRA)
Vincent Hennebert created FOP-2193: -- Summary: Intermediate format introduces white space in SVG while it should not Key: FOP-2193 URL: https://issues.apache.org/jira/browse/FOP-2193 Project: Fop

[jira] [Updated] (FOP-2193) Intermediate format introduces white space in SVG while it should not

2013-01-18 Thread Vincent Hennebert (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Hennebert updated FOP-2193: --- Attachment: svg-if-space.fo Sample FO file illustrating the issue

Re: [Vote] Add dependency to fontbox for OTF CFF

2013-01-10 Thread Vincent Hennebert
+1 Vincent On 10/01/13 13:07, Robert Meyer wrote: > Hi all, > > I posted a message yesterday about getting opinions on either adding a > dependency to fontbox to use their implementation or write our own for OTF > CFF support. I personally think that using fontbox would be the better option

Re: Move o.a.f.complexscripts.bidi.BidiClass to build/gensrc

2012-11-23 Thread Vincent Hennebert
uld be safer to separate generated classes from the ones that are manually edited. > None of the rationale you provide below are compelling. So I object to this > proposed change. > > On Thu, Nov 22, 2012 at 2:52 AM, Vincent Hennebert > wrote: > >> Hi, >> >>

Move o.a.f.complexscripts.bidi.BidiClass to build/gensrc

2012-11-22 Thread Vincent Hennebert
Hi, I’ve recently stumbled upon this o.a.f.complexscripts.bidi.BidiClass that appears to be generated. I think it should be moved to the build/gensrc directory. Reasons are: • It doesn’t need to be understood and maintained by developers in the same way as other classes. Changes will be made to

Re: svn commit: r1342781 - in /xmlgraphics/fop/trunk: src/documentation/content/xdocs/bugs.xml src/documentation/content/xdocs/faq.xml status.xml

2012-11-20 Thread Vincent Hennebert
converters are used for the preview and the actual HTML generation. I’ll try and investigate what’s going on. Vincent On 20/11/12 14:40, Glenn Adams wrote: > ok, i can accept > > On Tue, Nov 20, 2012 at 3:52 AM, Vincent Hennebert > wrote: > >> Ok, so what about the attach

Re: svn commit: r1342781 - in /xmlgraphics/fop/trunk: src/documentation/content/xdocs/bugs.xml src/documentation/content/xdocs/faq.xml status.xml

2012-11-20 Thread Vincent Hennebert
nguage, then please propose a replacement > for discussion here. > > On Tue, Oct 9, 2012 at 11:10 PM, Vincent Hennebert > wrote: > >> (Going through old unread commit messages...) >> >> I’d like to soften a bit the rather martial tone introduced in those >> c

Re: properly tag hyphenated words [was: svn commit: r1405158 - in /xmlgraphics/fop/trunk: ./ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/area/inline/ src/java/org/apache/fop/layo

2012-11-02 Thread Vincent Hennebert
(Some notes relating to this work that I thought would be more easily retrievable if I put them here rather than in the Bugzilla entry.) I had to forgo the soft hyphen approach due to a hack in XGC that replaces soft hyphens with normal hyphens when no glyph is available in the font for soft hyphe

Re: [Vote] for the merge of Temp_RoundedCorners

2012-10-19 Thread Vincent Hennebert
+1 Having the ‘absolute’ versions of the properties would be nice but this is not IMO a blocker requirement for the merge of this work. Here are a few comments based on a quick look at the branch: • o.a.f.fo.Constants PR_X_BORDER_START_RADIUS_START PR_X_BORDER_START_RADIUS_END PR_X_BORDER_E

Re: svn commit: r1342781 - in /xmlgraphics/fop/trunk: src/documentation/content/xdocs/bugs.xml src/documentation/content/xdocs/faq.xml status.xml

2012-10-09 Thread Vincent Hennebert
(Going through old unread commit messages...) I’d like to soften a bit the rather martial tone introduced in those changes. If I were a new user looking into submitting a bug and reading this page, I think I would refrain from doing so for fear of the police forces breaking into my home in the mid

New Checkstyle and FindBugs issues

2012-10-08 Thread Vincent Hennebert
There are new Checkstyle and FindBugs issues in the trunk. From the affected files it seems like at least some of them originates from commit 1391502. It would be good to fix them as it would make it easier for us to check that our own code doesn’t introduce any new issue. Thanks, Vincent

Re: [Bug 53902] New: Add scope to header table cell

2012-09-28 Thread Vincent Hennebert
Sorry for the delay. On 20/09/12 19:36, Glenn Adams wrote: > On Thu, Sep 20, 2012 at 11:02 PM, Vincent Hennebert > wrote: > >> On 20/09/12 02:05, Glenn Adams wrote: >>> On Thu, Sep 20, 2012 at 3:15 AM, Vincent Hennebert wrote: >>> >>>>> In XS

Re: [Bug 53902] New: Add scope to header table cell

2012-09-20 Thread Vincent Hennebert
On 20/09/12 02:05, Glenn Adams wrote: > On Thu, Sep 20, 2012 at 3:15 AM, Vincent Hennebert wrote: > >> I’ve started to work on this. Any feedback about the proposed extension >> from any interested party will be most welcome. >> >> Thanks, >> Vincent >>

Re: [VOTE] Merge Temp_URI_Resolution/ into XGC trunk

2012-09-20 Thread Vincent Hennebert
This vote should be held on general@ Vincent On 20/09/12 10:16, mehdi houshmand wrote: > Hi All, > > I believe I've completed the work on XGC to allow restrictions to the I/O > capabilities, by default, obviously, the mechanisms haven't changed. I've > tried to address some of the suggestions m

Re: [Bug 53902] New: Add scope to header table cell

2012-09-19 Thread Vincent Hennebert
I’ve started to work on this. Any feedback about the proposed extension from any interested party will be most welcome. Thanks, Vincent On 19/09/12 12:22, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53902 > > Priority: P2 > Bug ID: 53902

Re: svn commit: r1380169 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: events/CompositeEventListener.java pdf/PDFEncoding.java

2012-09-04 Thread Vincent Hennebert
On 03/09/12 09:38, mehdi wrote: > Author: mehdi > Date: Mon Sep 3 08:38:26 2012 > New Revision: 1380169 > > URL: http://svn.apache.org/viewvc?rev=1380169&view=rev > Log: > Amended a couple javadocs and some trivial clean up > > Modified: > > xmlgraphics/fop/trunk/src/java/org/apache/fop/eve

Re: Small error to the documentation

2012-07-19 Thread Vincent Hennebert
On 18/07/12 18:21, Glenn Adams wrote: > On Wed, Jul 18, 2012 at 2:35 AM, Chris Bowditch > wrote: > >> On 14/07/2012 22:14, Glenn Adams wrote: >> >> Hi Glenn, >> >> I've moved this discussion to fop-dev as its now more relevant there. >> >> >> the source for this file is under >> src/documentatio

Re: Switching to JIRA [was: Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/]

2012-07-18 Thread Vincent Hennebert
On 18/07/12 13:46, Alexios Giotis wrote: > > On Jul 18, 2012, at 3:19 PM, Vincent Hennebert wrote: > >> On 18/07/12 01:14, Glenn Adams wrote: >>> On Tue, Jul 17, 2012 at 6:05 PM, Alexios Giotis >>> wrote: >>> >>>> The end result is to

Switching to JIRA [was: Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/]

2012-07-18 Thread Vincent Hennebert
On 18/07/12 01:14, Glenn Adams wrote: > On Tue, Jul 17, 2012 at 6:05 PM, Alexios Giotis wrote: > >> The end result is to provide a documentation trail. I initially replied to >> this thread because Jira is not (yet) used in FOP and it happens to provide >> this feature. > > > FYI, Alex, if you a

Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/

2012-07-18 Thread Vincent Hennebert
Hi Alexios, thanks for you input. On 18/07/12 01:05, Alexios Giotis wrote: > Hi Vincent, > > On Jul 17, 2012, at 12:10 PM, Vincent Hennebert wrote: > >> On 13/07/12 22:52, Alexios Giotis wrote: >>> A change log or "release notes" can be generated by J

Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/

2012-07-17 Thread Vincent Hennebert
&version=12316940 > > Alexios Giotis > > On Jul 13, 2012, at 6:08 PM, Vincent Hennebert wrote: > >> We can decide to change that and use a bug tracking system instead, but >> in the same time we do that we will have to have in place a new >> mechanism to generat

Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/

2012-07-13 Thread Vincent Hennebert
On 13/07/12 14:07, Glenn Adams wrote: > On Fri, Jul 13, 2012 at 2:05 AM, Pascal Sancho wrote: > >> IMHO, using a bugtracker system to list bugfix or changes is a good idea. >> But today, the practice in FOP project is to fill this list directly >> in the cited page. >> We can adopt a new policy he

Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/

2012-07-12 Thread Vincent Hennebert
On 12/07/12 16:17, Glenn Adams wrote: > On Thu, Jul 12, 2012 at 9:00 AM, Vincent Hennebert > wrote: > >> On 12/07/12 14:47, Glenn Adams wrote: >>> On Thu, Jul 12, 2012 at 7:45 AM, Vincent Hennebert >> wrote: >>> >>>> On 12/07/12 14:37, Glenn A

Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/

2012-07-12 Thread Vincent Hennebert
On 12/07/12 14:47, Glenn Adams wrote: > On Thu, Jul 12, 2012 at 7:45 AM, Vincent Hennebert > wrote: > >> On 12/07/12 14:37, Glenn Adams wrote: >>> Is this addressing a specific bug? If not, then please enter a bug and >>> update the status to ensure this

Re: svn commit: r1360665 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/java/org/apache/fop/intermediate/ test/java/org/apache/fop/layoutengine/

2012-07-12 Thread Vincent Hennebert
On 12/07/12 14:37, Glenn Adams wrote: > Is this addressing a specific bug? If not, then please enter a bug and > update the status to ensure this association for documentation and release > notes tracking purposes. I added an entry in the status.xml file. > Also, I notice you left a printf in pl

Re: git-svn doesn't update svn:mergeinfo

2012-07-05 Thread Vincent Hennebert
On 05/07/12 02:54, Glenn Adams wrote: > On Wed, Jul 4, 2012 at 3:54 PM, Alexios Giotis wrote: > >> Well actually git-svn has an option to update the svn:mergeinfo. It might >> be worth giving it a try. There are some restrictions and I suggest to test >> it first. The following is part of $ man gi

Re: [VOTE] Merge Temp_URI_Unification

2012-07-04 Thread Vincent Hennebert
One thing I forgot to mention: this work deserves its entry in the status.xml file, with importance set to ‘high’. On 04/07/12 08:38, mehdi houshmand wrote: > On 3 July 2012 15:48, Vincent Hennebert wrote: >> The new classes FopConfParser, FopFactoryBuilder and FopFactoryConfig >

Re: svn commit: r1357110 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/afp/util/ test/java/org/apache/fop/afp/

2012-07-04 Thread Vincent Hennebert
Mehdi, When applying a patch submitted by a contributor, you must put his name in the log message. Also, it’s good practice to refer to the Bugzilla number. And also add an entry to the status.xml file. Thanks, Vincent On 04/07/12 08:04, mehdi wrote: > Author: mehdi > Date: Wed Jul 4 07:04:03

Re: On Merging XGC 1.5rc1 & FOP 1.1rc1 back to Trunk?

2012-07-03 Thread Vincent Hennebert
On 02/07/12 20:12, Glenn Adams wrote: > What would people prefer? > >- merging these RC1 tagged revs back to trunk now (i.e., real soon now) Yes, but don’t delete the fop-1_1 branch after the merge. Use the following trick to keep it alive: http://svnbook.red-bean.com/en/1.6/svn.branchmerge.a

Re: svn commit: r1356398 - /xmlgraphics/fop/tags/fop-1_1rc1/src/documentation/content/xdocs/fo.xml

2012-07-03 Thread Vincent Hennebert
Glenn, On 02/07/12 19:49, gad...@apache.org wrote: > Author: gadams > Date: Mon Jul 2 18:49:00 2012 > New Revision: 1356398 > > URL: http://svn.apache.org/viewvc?rev=1356398&view=rev > Log: > Fix broken link to permit documentation deployment. Please port that change to the branch and revert it

Re: [VOTE] Merge Temp_URI_Unification

2012-07-03 Thread Vincent Hennebert
On 02/07/12 14:40, Glenn Adams wrote: > On Mon, Jul 2, 2012 at 7:25 AM, mehdi houshmand wrote: > >> Ahh I see, ok, thanks Pascal. I think we got our wires crossed a little >> there ;) >> >> Glenn, my plan was to merge the URI-resolution stuff in tomorrow. If this >> burdens you in some way, could

Re: [VOTE] Merge Temp_URI_Unification

2012-07-03 Thread Vincent Hennebert
I had started to build up a list of questions and comments but didn’t get round to finishing it in time. Anyway, here it is, hopefully it will still provide valuable feedback. The most important items to address are the possible regression regarding strict FO validation and the public API. The new

Re: svn commit: r1356121 - /xmlgraphics/fop/trunk/src/documentation/content/xdocs/team.xml

2012-07-02 Thread Vincent Hennebert
On 02/07/12 09:57, cbowdi...@apache.org wrote: > replace tabs with space. Correct use of it's with its as suggested by > Vincent. Sorry for the noise. > I should have done all the changes in a single commit. Actually not. It’s good to follow the atomicity of commits. That way it’s easy to revert

Re: [VOTE][RESULT] Merge Temp_TrueTypeInPostScript branch into trunk

2012-06-22 Thread Vincent Hennebert
branch implicitly meant to approve that of the XGC branch. Please shout if you believe this is twisting the Apache policy too much, and we’ll see what we can do. Vincent On 22/06/12 11:50, Vincent Hennebert wrote: > We have 7 +1, the vote passes. > > I’ll proceed with the merge within

Re: [VOTE][RESULT] Merge Temp_TrueTypeInPostScript branch into trunk

2012-06-22 Thread Vincent Hennebert
We have 7 +1, the vote passes. I’ll proceed with the merge within the next few days. Thanks, Vincent On 15/06/12 11:25, Vincent Hennebert wrote: > As you may have noticed, I’ve recently spent some time updating the > Temp_TrueTypeInPostScript branch to the latest trunk and doing some &

[VOTE] Merge Temp_TrueTypeInPostScript branch into trunk

2012-06-15 Thread Vincent Hennebert
As you may have noticed, I’ve recently spent some time updating the Temp_TrueTypeInPostScript branch to the latest trunk and doing some clean-up (thanks to Robert for updating the testcases to JUnit 4). We have been using the code from this branch for quite a while now and it has proven to work re

Re: svn commit: r1339667 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/modca/GraphicsObject.java

2012-05-17 Thread Vincent Hennebert
Hi Glenn, This change introduces a dependency on Java 1.6. Please revert. Thanks, Vincent On 17/05/12 16:53, gadams wrote: > Author: gadams > Date: Thu May 17 15:53:37 2012 > New Revision: 1339667 > > URL: http://svn.apache.org/viewvc?rev=1339667&view=rev > Log: > Fix findbugs warning. > > Mo

<    1   2   3   4   5   6   7   8   9   10   >