https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Alex Giotis changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
Configure bugmail: https:
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Vincent Hennebert changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #26 from Mehdi Houshmand 2012-03-22 21:55:19
UTC ---
> And despite that, they probably don't even bring adequate coverage. Many
> fields
> are set to a mock of some property (see e.g. EnumLengthTestCase). So the
> equals
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #25 from Alex Giotis 2012-03-22 19:20:08
UTC ---
Thanks for reviewing and applying this patch !
I am happy that the deadlock is gone. I had a 2nd look on the final changes and
for me this issue is now resolved. I am leaving th
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #24 from Vincent Hennebert 2012-03-22
18:00:46 UTC ---
Patch applied in rev. 1303891:
http://svn.apache.org/viewvc?rev=1303891&view=rev
Sorry for the delay about this, and thanks for your patience.
I didn't include the test c
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #23 from Vincent Hennebert 2012-03-22
16:54:42 UTC ---
Hi Alexios,
(In reply to comment #21)
> Vincent, thanks for looking at it.
>
> > * Why use Double.doubleToLongBits in equals methods to compare doubles
> > (NumericPrope
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #22 from Alex Giotis 2012-03-22 02:08:31
UTC ---
This patch should also resolve Bug 50703.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #21 from Alex Giotis 2012-03-22 02:02:02
UTC ---
Vincent, thanks for looking at it.
> * Why declare the equals and hashCode methods on interfaces (Numeric,
> PercentBase)? They are defined on Object anyway, and AFAICT declari
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #20 from Vincent Hennebert 2012-03-21
20:41:37 UTC ---
Thanks for your patch! I have a few questions following a quick review:
* Why declare the equals and hashCode methods on interfaces (Numeric,
PercentBase)? They are defined
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Alex Giotis changed:
What|Removed |Added
Attachment #28412|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #18 from Mehdi Houshmand 2012-03-09 09:15:10
UTC ---
> Why not just put that in a unit test?? None of this code is tested and a
> little
> mistake could have far-reaching ramifications.
By that I obviously meant the Property
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #17 from Mehdi Houshmand 2012-03-09 09:12:12
UTC ---
> - I don't think we get added value by testing the hashCode() & equals()
> implementations. The tests don't protect from future changes in the tested
> classes (e.g. addin
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #16 from Alex Giotis 2012-03-02 16:33:36
UTC ---
*** Bug 51625 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this ma
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Alexis Giotis changed:
What|Removed |Added
Attachment #27495|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #14 from Alexis Giotis 2011-12-15 12:27:57
UTC ---
Hi Medhi,
Now that you are a commiter and mockito is used, is there a reason for not
applying this patch ?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #13 from Alexis Giotis 2011-10-24 16:59:20
UTC ---
Now that there was a vote and Mockito has been accepted, what about applying
the patch ? Is there something holding it ?
--
Configure bugmail: https://issues.apache.org/bugzi
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #12 from Simon Pepping 2011-09-27 08:25:35
UTC ---
(In reply to comment #9)
> Some of the tests added require Mockito, I tried to avoid using mocking as
> much
> as possible for the obvious reason that the commiters haven't ag
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #11 from Mehdi Houshmand 2011-09-15 13:01:18
UTC ---
Excellent, thanks for looking over it, I agree, that //TODO shouldn't have
gotten through.
Thanks again for taking the time to check through it.
--
Configure bugmail: http
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
--- Comment #10 from Alexis Giotis 2011-09-15 12:09:38
UTC ---
Medhi, thanks for checking & fixing checkstyle issues. Using the Property.eq()
definitely makes the equals() methods easier to read. I used the eclipse auto
generated equals()
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Mehdi Houshmand changed:
What|Removed |Added
Attachment #27477|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Alexis Giotis changed:
What|Removed |Added
Attachment #27358|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=46962
Vincent Hennebert changed:
What|Removed |Added
Summary|Deadlock in PropertyCache |[PATCH] Deadlock in
22 matches
Mail list logo
