Re: JavaIO Default ICC Profiles

2016-01-13 Thread Matthias Reischenbacher
Hi, I just added two patches at https://issues.apache.org/jira/browse/FOP-2564 which attempt to give more control over ICC profile handling. On commons side I added the ICC profile as a separate parameter to the ImageBuffered/ImageRendered constructors. This causes quite some code changes in other

Re: JavaIO Default ICC Profiles

2016-01-13 Thread Luis Bernardo
Yes, that is what I was suspecting. My suggestion then is to do the check when loading the image, as you propose. If there is no embedded profile in the PNG do not embed one by default. We could make this configurable but I don;t see the need for that until we find an example where having the defau

Re: JavaIO Default ICC Profiles

2016-01-13 Thread Matthias Reischenbacher
Hi, FOP-1575 seems to be similar, but isn't the same. I also can't reproduce it on my platform (win, jdk 8), so perhaps it has been fixed in the meantime by some other change. Regarding your other questions: getEffectiveICCProfile() is always called, regardless of embedded or non-embedded profile

Re: JavaIO Default ICC Profiles

2016-01-12 Thread Luis Bernardo
Can you check whether FOP-1575 is the same problem? Is getEffectiveICCProfile() only called if there is no embedded profile? Could there be cases where that profile is in fact correct? On 1/12/16 9:25 PM, Matthias Reischenbacher wrote: Hi, I've been struggling today with the PDF display of

JavaIO Default ICC Profiles

2016-01-12 Thread Matthias Reischenbacher
Hi, I've been struggling today with the PDF display of a PNG with "gray" color space. When using the default PNG loader (with the raw PNG loader all works fine), the colors are displayed very "light" and "dull". During a debug session I found out that the ImageIO loader assigns a default Gray ICC