Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Max Berger
Dear FopDevs, I've added the patched version and submitted a feature request for retroweaver: https://sourceforge.net/tracker/index.php?func=detail&aid=2063970&group_id=104240&atid=637383 Since the next release date is still a little bit away I hope this can be fixed properly by then. Max Jere

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Jeremias Maerki
As long as we don't distribute the unreleased package in one of our own releases, it's fine. We need to apply the same policy as we do for other libraries. If the source distribution doesn't contain those build dependencies, it's ok to keep the unreleased package. On 20.08.2008 18:31:46 Max Berger

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Adrian Cumiskey
Hi Max, Personally I'm fine with it until we take a future retroweaver release containing your patch. So +1 from me. Adrian. Max Berger wrote: Dear Fop-Devs, further insight on retroweaver: I've downloaded and patched retroweaver not to modify Boolean.valueOf, which is now correctly verifi

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Max Berger
Dear Fop-Devs, further insight on retroweaver: I've downloaded and patched retroweaver not to modify Boolean.valueOf, which is now correctly verified against 1.4. I could add the (patched) artifact to fops lib/build. I will try and discuss with the retroweaver maintainer about options to include

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Max Berger
Adrian, Adrian Cumiskey schrieb: > I don't think it is Max... looks like @since 1.4. you're right - looks like the other valueOf methods (for integer, etc.) where introduced in 1.5, and this one was indeed introduced in 1.4. I've reverted that change. Apparently retroweaver still modifies calls

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Adrian Cumiskey
I don't think it is Max... looks like @since 1.4. /** * Returns a Boolean instance representing the specified * boolean value. If the specified boolean value * is true, this method returns Boolean.TRUE; * if it is false, this method returns Boolean.FALSE. * If a new B