Re: [foreman-dev] Foreman develop broken at the moment: feel free to blame me :)

2017-05-03 Thread Ivan Necas
Ivan Necas writes: The issues with validates_lengths_from_database should be over now. If your tests are still failing, it's your problem now :) -- Ivan > Ivan Necas writes: > >> Tomer Brisker writes: >> >>> Not sure if it's related or not, but seems that develop is still broken on >>> mysql

Re: [foreman-dev] Foreman develop broken at the moment: feel free to blame me :)

2017-05-02 Thread Ivan Necas
Ivan Necas writes: > Tomer Brisker writes: > >> Not sure if it's related or not, but seems that develop is still broken on >> mysql - lots of errors to do with field lengths, so I'm guessing it >> may be. > > I think it's related in a way that the fix we did in > validate_length_from_database re

Re: [foreman-dev] Foreman develop broken at the moment: feel free to blame me :)

2017-05-02 Thread Ivan Necas
Tomer Brisker writes: > Not sure if it's related or not, but seems that develop is still broken on > mysql - lots of errors to do with field lengths, so I'm guessing it > may be. I think it's related in a way that the fix we did in validate_length_from_database revealed an issue we had in our co

Re: [foreman-dev] Foreman develop broken at the moment: feel free to blame me :)

2017-05-01 Thread Tomer Brisker
Not sure if it's related or not, but seems that develop is still broken on mysql - lots of errors to do with field lengths, so I'm guessing it may be. On Fri, Apr 28, 2017 at 11:09 AM, Ivan Necas wrote: > Hi, > > I've spend very interesting week fighting some intermittent issues on > foreman_rem

[foreman-dev] Foreman develop broken at the moment: feel free to blame me :)

2017-04-28 Thread Ivan Necas
Hi, I've spend very interesting week fighting some intermittent issues on foreman_remote_execution CI. I finally tracked it to [1] yesterday and send a patch to validates_lengths_from_database. However, glad that I've finally found the cause and the gem tests were passing, I haven't spend that muc