Re: [foreman-dev] Re: Revert removal of @host.params for host_param

2017-05-11 Thread Daniel Lobato
Right now 1.15 is released. I decided not to document the deprecation as the consensus seems to maintain both ways of addressing this. The deprecations are still going to show up in the logs, so I suggest someone submits a PR to remove the deprecations and cherry-pick it for 1.15.1

Re: [foreman-dev] Re: Revert removal of @host.params for host_param

2017-04-19 Thread Andrew Schofield
At the very least support both. This is a point release and this is a pretty major change for a non-major release. As per the comment from Ewoud the bulk of people who will use this use it in ERB and templates. The templates being probably the easiest to 'fix'. Personally, keeping this

Re: [foreman-dev] Re: Revert removal of @host.params for host_param

2017-04-19 Thread Greg Sutcliffe
On Wed, 2017-04-19 at 14:10 +0300, Tomer Brisker wrote: > Since it seems there wasn't an agreement on reverting this made in > time for 1.15, I'd say we should support both for now and reconsider > in the future pending a rewrite of the template engine using a proxy > object as we discussed. +1,

Re: [foreman-dev] Re: Revert removal of @host.params for host_param

2017-04-19 Thread Tomer Brisker
Since it seems there wasn't an agreement on reverting this made in time for 1.15, I'd say we should support both for now and reconsider in the future pending a rewrite of the template engine using a proxy object as we discussed. On Tue, Apr 18, 2017 at 10:15 AM, Marek Hulán

Re: [foreman-dev] Re: Revert removal of @host.params for host_param

2017-04-18 Thread Marek Hulán
On pondělí 17. dubna 2017 11:22:07 CEST Daniel Lobato wrote: > Sorry to relive the topic but > https://github.com/theforeman/foreman/pull/4219 didn't get in, > and it's time to update the documentation for 1.15 including deprecations. > > Since reverting the change is probably something not to be

[foreman-dev] Re: Revert removal of @host.params for host_param

2017-04-17 Thread Daniel Lobato
Sorry to relive the topic but https://github.com/theforeman/foreman/pull/4219 didn't get in, and it's time to update the documentation for 1.15 including deprecations. Since reverting the change is probably something not to be done during RC, I wonder what to do. The options are: 1. Keep