Aw: Re: [PATCH] PR fortran/99112 - [11 Regression] ICE with runtime diagnostics for SIZE intrinsic function

2021-03-14 Thread Harald Anlauf via Fortran
Hi Tobias, > I do not see any reason why 'tmp' is replaced by 'temp' in this > code. Also for doing patch archeology, it helps if there are no > changes unless it makes sense. Adding an -e- does not count ;-) > > Hence, OK with that change. I've corrected that. This also reduces the size of

Re: 12 PR fixed

2021-03-14 Thread Steve Kargl via Fortran
On Sun, Mar 14, 2021 at 12:38:59PM +0100, Tobias Burnus wrote: > On 14.03.21 06:13, Jerry DeLisle wrote: > > > Well, I am seeing the falling upon a closer look.  I do not know if > > related to the patch yet.  Lets make sure this is fixed. > > > > FAIL: gfortran.dg/pr87907.f90   -O  (internal

Re: 12 PR fixed

2021-03-14 Thread Jerry DeLisle
I can convert the tabs/spaces no problem. On 3/14/21 5:01 AM, Tobias Burnus wrote: Small additional remark: I see new lines which use 8 spaces instead of a tab – that should also be fixed. And: Please don't forget to CC gcc-patches@ as well. Thanks, Tobias On 14.03.21 12:38, Tobias Burnus

Re: 12 PR fixed

2021-03-14 Thread Tobias Burnus
Small additional remark: I see new lines which use 8 spaces instead of a tab – that should also be fixed. And: Please don't forget to CC gcc-patches@ as well. Thanks, Tobias On 14.03.21 12:38, Tobias Burnus wrote: On 14.03.21 06:13, Jerry DeLisle wrote: Well, I am seeing the falling upon a

Re: 12 PR fixed

2021-03-14 Thread Tobias Burnus
On 14.03.21 06:13, Jerry DeLisle wrote: Well, I am seeing the falling upon a closer look.  I do not know if related to the patch yet.  Lets make sure this is fixed. FAIL: gfortran.dg/pr87907.f90   -O  (internal compiler error) FAIL: gfortran.dg/pr87907.f90   -O  (test for excess errors) FAIL:

Early ping: Re: [Patch] Fortran: Fix func decl mismatch [PR93660]

2021-03-14 Thread Tobias Burnus
Early ping – and minor post script: + hidden_typelist = TREE_CHAIN (hidden_typelist); This change is to avoid running into the ICE: gcc_assert (hidden_typelist == NULL_TREE || TREE_VALUE (hidden_typelist) == void_type_node); The purpose of this assert is to check that

Re: [PATCH] PR fortran/99112 - [11 Regression] ICE with runtime diagnostics for SIZE intrinsic function

2021-03-14 Thread Tobias Burnus
Hi Harald, hi Paul, On 13.03.21 09:58, Paul Richard Thomas via Fortran wrote: I am not sure of the etiquette for this - it looks OK to me :-) :-) On Fri, 12 Mar 2021 at 21:20, Harald Anlauf via Fortran the addition of runtime checks for the SIZE intrinsic created a regression that