Re: Ping: [Patch, fortran] PR115070 (and PR115348) - [13/14/15 Regression] ICE using IEEE_ARITHMETIC in a derived type method with class, intent(out)

2024-07-19 Thread Steve Kargl
Thanks for the patch and chasing down the magic. Path is ok to commit. -- steve On Fri, Jul 19, 2024 at 05:32:26PM +0100, Paul Richard Thomas wrote: > Hi All, > > Ping! > > I understand now why this works. The scope of the block is merged and so > all the previous declarations that would othe

Ping: [Patch, fortran] PR115070 (and PR115348) - [13/14/15 Regression] ICE using IEEE_ARITHMETIC in a derived type method with class, intent(out)

2024-07-19 Thread Paul Richard Thomas
Hi All, Ping! I understand now why this works. The scope of the block is merged and so all the previous declarations that would otherwise disappear are added, even by the empty statement. Regards Paul On Mon, 15 Jul 2024 at 17:10, Paul Richard Thomas < paul.richard.tho...@gmail.com> wrote: >

Re: [Ping, Patch, Fortran, PR88624, v1] Fix Rejects allocatable coarray passed as a dummy argument

2024-07-19 Thread Paul Richard Thomas
Hi Andre, The patch looks fine to me. Please add the original testcase as pr88624.f90, since it can be a compile only. The addition to coarray/dummy_1.f90 is fine as well but I think that it is good to address the reporter's problem directly. Thanks Paul On Wed, 17 Jul 2024 at 14:10, Andre Veh

Re: [PATCH] Fortran: character array constructor with >= 4 constant elements [PR103115]

2024-07-19 Thread Andre Vehreschild
Hi Harald, you right, that solution looks pretty obvious to me. Ok by me. Thanks for the patch and the opportunity to give back a review. Keep up the good work! Regards, Andre On Thu, 18 Jul 2024 21:27:13 +0200 Harald Anlauf wrote: > Dear all, > > here's a quite obvious fix for an ICE

Re: [Fortran, Patch, PR77518, (coarray), v2] Fix ICE in sizeof(coarray)

2024-07-19 Thread Andre Vehreschild
Hi Paul, thanks for the review. > While I realise that this is not your doing, should we not > check DECL_LANG_SPECIFIC ()) before touching GFC_DECL_SAVED_DESCRIPTOR? I like that idea. I have added it. But what should we do when DECL_LANG_SPECIFIC is not set? I have chosen to add a gcc_unreachab

Re: [r15-2135 Regression] FAIL: libgomp.oacc-fortran/privatized-ref-2.f90 -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable -Os at line 32 (test for warnings, line 31) on Linux/x86_64

2024-07-19 Thread Thomas Schwinge
Hi! First, note this is now GCC PR115989 "[15 regression] libgomp.oacc-fortran/privatized-ref-2.f90 fails after r15-2135-gc3aa339ea50f05". Otherwise: On 2024-07-19T06:54:46+0100, Paul Richard Thomas wrote: > Thanks for doing that test. Here is what the error looks like on 14-branch: > libgomp

Re: [r15-2135 Regression] FAIL: libgomp.oacc-fortran/privatized-ref-2.f90 -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable -Os at line 32 (test for warnings, line 31) on Linux/x86_64

2024-07-19 Thread Paul Richard Thomas
Hi Haochen, Thanks for doing that test. Here is what the error looks like on 14-branch: libgomp.oacc-fortran/privatized-ref-2.f90:36:22: 36 | A = [(3*j, j=1, 10)] | ^ Warning: ‘a.offset’ is used uninitialized [-Wuninitialized] libgomp.oacc-fortran/privatized-ref-2.f