Re: [PATCH] fortran: implment split for fortran 2023

2025-07-26 Thread Yuao Ma
Hi Mikael, On 7/27/2025 3:57 AM, Mikael Morin wrote: Hello, here are a few more comments on the patch below. It's not ready yet, but the remarks should be easily addressed. Thanks for the thorough review! I've addressed the comments and attached a new patch below. diff --git a/gcc/fortran

Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-26 Thread Andre Vehreschild
Hi Harald and Mikael, sorry when I jumped too much in answering different questions to my evident error. What I am trying to correct with my lastest patch is exactly what Harald wants. Standard compliant evaluation of all arguments to a (coindexed) expression before those arguments are used

Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-26 Thread Mikael Morin
Le 26/07/2025 à 19:03, Harald Anlauf a écrit : Gesendet: Samstag, 26. Juli 2025 um 15:17 Von: "Mikael Morin" An: "Harald Anlauf" , ve...@gmx.de CC: fortran@gcc.gnu.org Betreff: Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712 Le

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-26 Thread Mikael Morin
Hello, here are a few more comments on the patch below. It's not ready yet, but the remarks should be easily addressed. diff --git a/gcc/fortran/trans-intrinsic.cc b/gcc/fortran/trans-intrinsic.cc index be984271d6a..c2a91c93d28 100644 --- a/gcc/fortran/trans-intrinsic.cc +++ b/gcc/fortran/trans

[PATCH 2/3] fortran: Trigger reference saving on pointer dereference [PR121185]

2025-07-26 Thread Mikael Morin
From: Mikael Morin Regression-tested on x86_64-pc-linux-gnu. OK for master? -- >8 -- This is a follow-up to revision: r16-2371-g8f41c87654fd819e48c9f6f1ac3d87e35794d310 fortran: Factor array descriptor references That revision introduced new variables to limit repeated subexpressions in array

[PATCH 1/3] fortran: Bound class container lookup after array descriptor [PR121185]

2025-07-26 Thread Mikael Morin
From: Mikael Morin Regression-tested on x86_64-pc-linux-gnu. OK for master? -- >8 -- Don't look for a class container too far after an array descriptor. This avoids generating a polymorphic array reference, using the virtual table of a parent object, to access a non-polymorphic child having a t

[PATCH 0/3] fortran: Wrongly polymorphic array references [PR121185]

2025-07-26 Thread Mikael Morin
From: Mikael Morin PR 121185 exhibited wrong code examples where for assignements such as: class_obj%non_poly = class_obj%non_poly * x polymorphic references are (wrongly) used to access the left-hand-side array. This is caused by: 1. In the scalarizer, we delay (since r16-2248) evaluation of

[PATCH 3/3] fortran: Consistently use the same assignment reallocation condition [PR121185]

2025-07-26 Thread Mikael Morin
From: Mikael Morin Regression-tested on x86_64-pc-linux-gnu. OK for master? -- >8 -- This is a follow-up to: r16-2248-gac8e536526393580bc9a4339bab2f8603eff8a47 fortran: Delay evaluation of array bounds after reallocation That revision delayed the evaluation of array bounds, with changes in two

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-26 Thread Steve Kargl
On Sat, Jul 26, 2025 at 11:57:50PM +0800, Yuao Ma wrote: > > On 7/26/2025 11:25 PM, Steve Kargl wrote: > > On Sat, Jul 26, 2025 at 09:14:43PM +0800, Yuao Ma wrote: > > > + add_sym_4s ("split", GFC_ISYM_SPLIT, CLASS_IMPURE, > > > + BT_UNKNOWN, 0, GFC_STD_F2023, > > > + gfc_check_split,

Aw: Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-26 Thread Harald Anlauf
> Gesendet: Samstag, 26. Juli 2025 um 19:03 > Von: "Harald Anlauf" > An: morin-mik...@orange.fr, ve...@gmx.de > CC: fortran@gcc.gnu.org > Betreff: Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of > OpenCoarray fail to pass, works on 15.1.1 20250712 > > The function get_val() return

Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-26 Thread Harald Anlauf
> Gesendet: Samstag, 26. Juli 2025 um 15:17 > Von: "Mikael Morin" > An: "Harald Anlauf" , ve...@gmx.de > CC: fortran@gcc.gnu.org > Betreff: Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of > OpenCoarray fail to pass, works on 15.1.1 20250712 > > Le 24/07/2025 à 22:01, Harald Anlauf

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-26 Thread Yuao Ma
Hi Steve, On 7/26/2025 11:25 PM, Steve Kargl wrote: On Sat, Jul 26, 2025 at 09:14:43PM +0800, Yuao Ma wrote: + add_sym_4s ("split", GFC_ISYM_SPLIT, CLASS_IMPURE, + BT_UNKNOWN, 0, GFC_STD_F2023, + gfc_check_split, NULL, gfc_resolve_split, + "string", BT_CH

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-26 Thread Steve Kargl
On Sat, Jul 26, 2025 at 09:14:43PM +0800, Yuao Ma wrote: > > + add_sym_4s ("split", GFC_ISYM_SPLIT, CLASS_IMPURE, > + BT_UNKNOWN, 0, GFC_STD_F2023, > + gfc_check_split, NULL, gfc_resolve_split, > + "string", BT_CHARACTER, dc, REQUIRED, INTENT_IN, > + "set"

Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-26 Thread Mikael Morin
Le 24/07/2025 à 22:01, Harald Anlauf a écrit : Hi Andre, Gesendet: Donnerstag, 24. Juli 2025 um 10:25 Von: "Andre Vehreschild" An: "Harald Anlauf" CC: fortran@gcc.gnu.org Betreff: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712 Hi Ha

[PATCH] fortran: implment split for fortran 2023

2025-07-26 Thread Yuao Ma
Hi all, This patch introduces a complete implementation of the SPLIT intrinsic, including documentation and test cases. While Tobias previously mentioned that a similar effect could be achieved with existing functionality, I believe having direct support for this operation won't cause any iss