Re: [fossil-dev] Check-in etiquette

2015-08-27 Thread Richard Hipp
On 8/27/15, Baruch Burstein wrote: > Hi, > > I know that when making changes to makemake.tcl, I am expected to run the > script to generate the new makefiles and check them in as well. However, I > am on a computer where I cannot easily install TCL (company policy). I > committed the changes to ma

Re: [fossil-dev] Check-in etiquette

2015-08-27 Thread Jan Nijtmans
2015-08-27 11:03 GMT+02:00 Baruch Burstein : > I made the change locally in my makefile and used it. I then made the same > change in the tcl script and committed that one. > I guess I could have just committed my hand-changed makefile. Slightly better would have been to commit it to the "pending-

Re: [fossil-dev] Check-in etiquette

2015-08-27 Thread Baruch Burstein
On Thu, Aug 27, 2015 at 11:15 AM, Jan Nijtmans wrote: > > Joe already correct that: > > I saw that (thanks from me too).I was wondering for future times. The only potential problem: people might wonder how you tested > the change. I

Re: [fossil-dev] Check-in etiquette

2015-08-27 Thread Jan Nijtmans
2015-08-27 9:33 GMT+02:00 Baruch Burstein : > Hi, > > I know that when making changes to makemake.tcl, I am expected to run the > script to generate the new makefiles and check them in as well. However, I > am on a computer where I cannot easily install TCL (company policy). I > committed the chang

[fossil-dev] Check-in etiquette

2015-08-27 Thread Baruch Burstein
Hi, I know that when making changes to makemake.tcl, I am expected to run the script to generate the new makefiles and check them in as well. However, I am on a computer where I cannot easily install TCL (company policy). I committed the changes to makemake.tcl without regenerating the makefiles,