[fossil-dev] Unused variable in export.c

2018-05-08 Thread Johan Kuuse
Hi, fossil version This is fossil version 2.6 [c0ed95060c] 2018-05-05 19:10:20 UTC uname -a Linux kuuse-VirtualBox 4.13.0-38-generic #43-Ubuntu SMP Wed Mar 14 15:20:44 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux cc -I. -I./src -Ibld -Wall -DFOSSIL_DYNAMIC_BUILD=1 -g -O2 -DHAVE_AUTOCONFIG_H -D_H

Re: [fossil-dev] Emacs users:vc-region-history only for git so far.

2018-01-17 Thread Johan Kuuse
+1 (Emacs fan) /J El 17 ene. 2018 3:21, "Stephan Beal" escribió: > You don't need emacs for this: > > f annotate ... ¦ sed - n ${startLine},${endLine}p > > should do the trick. Except on Windows, of course (of course). > > - stephan > Sent from a mobile device, possibly from bed. Please e

[fossil-dev] Patch: h2 to h3

2018-01-16 Thread Johan Kuuse
Hi, Probably a typo in the default skins CSS makes H3 headers look bigger than H2 ones. BR, Johan Index: skins/default/css.txt == --- skins/default/css.txt +++ skins/default/css.txt @@ -42,11 +42,11 @@ font-size: 1.25em; } .

[fossil-dev] Patch: setup.c unused var, linenoise note

2017-12-22 Thread Johan Kuuse
Hi, Minor things. BR, Johan Index: src/setup.c == --- src/setup.c +++ src/setup.c @@ -1385,19 +1385,10 @@ "1", "HH:MM:SS", "2", "-MM-DD HH:MM", "3", "YYMMDD HH:MM", "4", "(off)" }; - static con

[fossil-dev] minor issues

2017-12-14 Thread Johan Kuuse
Hi, ./src/db.c:69:14: missing initializer for field ‘rc’ of ‘const struct Stmt’ #define empty_Stmt_m {BLOB_INITIALIZER,NULL, NULL, NULL, 0} Fix, line 67: #define empty_Stmt_m {BLOB_INITIALIZER,NULL, NULL, NULL, 0, 0} ./src/search.c:1077:21: C++ style comment or typo ? zDisable1 = ""; // au

[fossil-dev] Unused variables in stat.c

2017-12-12 Thread Johan Kuuse
Hi, Patch removes 3 lines. BR, Johan Index: src/stat.c == --- src/stat.c +++ src/stat.c @@ -62,11 +62,10 @@ void stat_page(void){ i64 t, fsize; int n, m; int szMax, szAvg; int brief; - char zBuf[100]; const char

Re: [fossil-dev] Typo

2017-12-05 Thread Johan Kuuse
On Tue, Dec 5, 2017 at 4:58 PM, Richard Hipp wrote: > On 12/5/17, Warren Young wrote: > > On Dec 4, 2017, at 3:07 AM, Johan Kuuse wrote: > >> > >> src/file.c:65 > >> > >> > >> #define RepoFILE 1/* Follow symlinks if*f* allow-symli

[fossil-dev] Unused variable zBuiltin in skins.c: Was: Typo

2017-12-04 Thread Johan Kuuse
Hi again, src/skins.c:771:9: variable ‘zBuiltin’ set but not used [-Werror=unused-but-set-variable] char *zBuiltin;/* SQL description of a built-in skin */ BR, /J On Mon, Dec 4, 2017 at 11:07 AM, Johan Kuuse wrote: > src/file.c:65 > > > #define RepoFILE 1/* Follow s

Re: [fossil-dev] Typo

2017-12-04 Thread Johan Kuuse
src/file.c:65 #define RepoFILE 1/* Follow symlinks if*f* allow-symlinks is OFF */ Should be: #define RepoFILE 1/* Follow symlinks if allow-symlinks is OFF */ On Mon, Dec 4, 2017 at 10:56 AM, Johan Kuuse wrote: > Hi, > > src/configure.c:343 > > ** Update: Supp

[fossil-dev] Typo

2017-12-04 Thread Johan Kuuse
Hi, src/configure.c:343 ** Update: Support for the old format was remoed on 2017-09-20. Should be: ** Update: Support for the old format was remo*v*ed on 2017-09-20. BR, Johan ___ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://maili

[fossil-dev] finfo.c cleanup (unused variables)

2017-11-30 Thread Johan Kuuse
Hi, Patch removing unused variables in finfo.c. BR, Johan ___ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

[fossil-dev] timeline.c cleanup patch

2017-11-27 Thread Johan Kuuse
Hi, If the timeline_submenu() function is planned to not be used any longer, here is a patch to remover the function (and a couple of commented lines). If its removal is only temporary, ignore this patch. BR, Johan ___ fossil-dev mailing list fossil-dev

[fossil-dev] Patch for www/style.wiki

2017-11-22 Thread Johan Kuuse
Hi, A minor patch for the enumeration in www/style.wiki. Included a proposal for a few comments about ANSI C-89. Best regards, Johan Index: www/style.wiki == --- www/style.wiki +++ www/style.wiki @@ -1,63 +1,89 @@ Coding Style F

Re: [fossil-dev] Time for a 2.4 release?

2017-10-29 Thread Johan Kuuse
On Mon, Oct 30, 2017 at 1:44 AM, Richard Hipp wrote: > Version 2.3 has been out for a while. The change log for 2.4 looks > like it is about the right length. I propose to do an official > release soon. Objections? None. I have been using 2.4 since it came into trunk on several machines, no is

Re: [fossil-dev] [fossil-users] Possible Markdown memleak

2017-10-27 Thread Johan Kuuse
On Fri, Oct 27, 2017 at 5:19 PM, Richard Hipp wrote: > On 10/27/17, Richard Hipp wrote: >> >> (2) Memory leaks do not usually matter in Fossil, since each command >> runs to completion and the process dies, leaving the OS to clean up >> any memory. Only memory leaks inside of a loop make a diffe

[fossil-dev] Possible Markdown memleak

2017-10-27 Thread Johan Kuuse
Hi, I think the two blobs used for markdown input and output (rendered HTML) aren't free()'d properly. This patch only applies to test_markdown_render(), but the same behaviour may occur at other places where markdown_to_html() is called. BR, Johan Index: src/wiki.c ===

[fossil-dev] Patch: tech_overview.wiki

2017-10-27 Thread Johan Kuuse
Hi, There are a few broken links in the Technical Overview Wiki page: Index: www/tech_overview.wiki == --- www/tech_overview.wiki +++ www/tech_overview.wiki @@ -53,11 +53,11 @@ checkout for a project and contains state information

Re: [fossil-dev] Backout the --no-dir-symlinks option. Was strange problem with graphical diff

2017-08-24 Thread Johan Kuuse
Hi, Minimal fix: remove unused variable in Check-in [92ea6183] Index: src/file.c == --- src/file.c +++ src/file.c @@ -626,11 +626,11 @@ ** ** On success, return zero. On error, return errorReturn if positive, otherwise ** print

[fossil-dev] sqlite3_module initializing warnings with -Wmissing-field-initializers

2017-07-12 Thread Johan Kuuse
Hi, In sqlite3.c, I see that most of the times, but not always, all members of the sqlite3_module struct are initialized: static const sqlite3_module fts5Vocab = ... static const sqlite3_module fts3Module = ... static const sqlite3_module pragmaVtabModule = ... ... 0,

Re: [fossil-dev] New "References" section on the /info page

2017-07-06 Thread Johan Kuuse
El 6 jul. 2017 16:42, "Warren Young" escribió: On Jul 6, 2017, at 8:22 AM, Richard Hipp wrote: > > Question 1: "References" seems like the wrong section label. But I > cannot come up with anything better. I also tried "Referenced By", > but that seems even worse. Suggestions? “Cited by”?

Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-04 Thread Johan Kuuse
, g.httpOut); +} } } } fflush(g.httpOut); CGIDEBUG(("DONE\n")); On Tue, Jul 4, 2017 at 2:35 PM, Stephan Beal wrote: > On Tue, Jul 4, 2017 at 8:39 AM, Johan Kuuse wrote: > >> + if (fossil_strcmp((char*)P("REQUEST_METHOD")

Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-03 Thread Johan Kuuse
;)!=0) + { +if( total_size>0 && iReplyStatus != 304 ){ + int i, size; + for(i=0; i<2; i++){ +size = blob_size(&cgiContent[i]); +if( size>0 ){ + fwrite(blob_buffer(&cgiContent[i]), 1, size, g.httpOut); +} } } } fflush(

[fossil-dev] Patch for HTTP HEAD Method

2017-07-03 Thread Johan Kuuse
Hi, I see that the upcoming fossil 2.3 release coming up soon, so there may be other (higher) priorities and interests right now, but I post this patch here and now anyway, for the record. Playing around with the "fossil http" command, I found a bug in the behavior for the HTTP HEAD method. htt