Re: [fossil-dev] Fixed segfault in th_lang.c

2015-11-22 Thread Stephan Beal
On Sun, Nov 22, 2015 at 6:01 AM, Andy Bradford wrote: > Thus said "Joe Mistachkin" on Sat, 21 Nov 2015 10:38:46 -0800: > > > Apparently, a fix was done on a branch, but never made it to trunk? > > That would explain why I didn't see the previous fix. I actually did > look through annotations

Re: [fossil-dev] Fixed segfault in th_lang.c

2015-11-21 Thread Andy Bradford
Thus said "Joe Mistachkin" on Sat, 21 Nov 2015 10:38:46 -0800: > Apparently, a fix was done on a branch, but never made it to trunk? That would explain why I didn't see the previous fix. I actually did look through annotations to see how it slipped by since 2008, but didn't notice that it was

Re: [fossil-dev] Fixed segfault in th_lang.c

2015-11-21 Thread Stephan Beal
On Sat, Nov 21, 2015 at 7:38 PM, Joe Mistachkin wrote: > > Apparently, a fix was done on a branch, but never made it to trunk? > > https://www.fossil-scm.org/fossil/info/f2d87242503d7a7d So THAT's why the problem sounded so familiar! Thanks, Joe! -- - stephan beal http://wanderin

Re: [fossil-dev] Fixed segfault in th_lang.c

2015-11-21 Thread Joe Mistachkin
Apparently, a fix was done on a branch, but never made it to trunk? https://www.fossil-scm.org/fossil/info/f2d87242503d7a7d Revised trunk to match it (with a minor style tweak): https://www.fossil-scm.org/fossil/vinfo/c66083eded992cc -- Joe Mistachkin

Re: [fossil-dev] Fixed segfault in th_lang.c

2015-11-21 Thread Stephan Beal
On Sat, Nov 21, 2015 at 6:51 PM, Andy Bradford wrote: > http://www.fossil-scm.org/index.html/info/7c3cb470e65bf792 fwiw, it _used_ to have exactly that check. i forked th1 into a standalone library 3 summers ago and my forked copy has that same check in an outer if: http://fossil.wanderinghors

[fossil-dev] Fixed segfault in th_lang.c

2015-11-21 Thread Andy Bradford
Hello, I ran into a segfault: (gdb) bt #0 0x1a710bd7 in proc_command (interp=0x83592c20, ctx=0x0, argc=4, argv=0x802ba400, argl=0x802ba410) at ./src/th_lang.c:500 #1 0x1a70f295 in thEvalLocal (interp=0x83592c20, zProgram=Variable "zProgram" is not available. ) at ./src/th.c:917 #2 0x1a70