Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-04 Thread Richard Hipp
Much simpler patch checked in at https://www.fossil-scm.org/fossil/info/5826ba37acff82bb -- D. Richard Hipp d...@sqlite.org ___ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-04 Thread Stephan Beal
On Tue, Jul 4, 2017 at 3:44 PM, Johan Kuuse wrote: > Thanks for pointing that out. > On the other hand (being pedantic), maybe the second argument "HEAD", > being of type char [5], and thus passed as type (char *) to > fossil_strcmp(), should be casted to (const char*), right? > > > - if (fossil

Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-04 Thread Johan Kuuse
Thanks for pointing that out. On the other hand (being pedantic), maybe the second argument "HEAD", being of type char [5], and thus passed as type (char *) to fossil_strcmp(), should be casted to (const char*), right? > - if (fossil_strcmp((char*)P("REQUEST_METHOD"),"HEAD")!=0) > + if (fossil_

Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-04 Thread Stephan Beal
On Tue, Jul 4, 2017 at 8:39 AM, Johan Kuuse wrote: > + if (fossil_strcmp((char*)P("REQUEST_METHOD"),"HEAD")!=0) > One minor nitpick: fossil_strcmp() takes a const char *, which is the return type of P(), so no cast is needed there. -- - stephan beal http://wanderinghorse.net/home/stephan

Re: [fossil-dev] Patch for HTTP HEAD Method

2017-07-03 Thread Johan Kuuse
Hi again, A question: Are attachments scrubbed on the fossil-dev mailing lists? I see in the two links below that the patch I attached yesterday isn't included in the message: https://marc.info/?l=fossil-dev&m=149909778525770&w=2 http://mailinglists.sqlite.org/cgi-bin/mailman/private/fossil-dev/2

[fossil-dev] Patch for HTTP HEAD Method

2017-07-03 Thread Johan Kuuse
Hi, I see that the upcoming fossil 2.3 release coming up soon, so there may be other (higher) priorities and interests right now, but I post this patch here and now anyway, for the record. Playing around with the "fossil http" command, I found a bug in the behavior for the HTTP HEAD method. htt