Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Ross Berteig
Fixed on trunk. On 2/6/2016 2:34 PM, Ross Berteig wrote: Well that will teach me to go to bed after checking something in! I'll get that fixed ASAP. -- Ross Berteig [email protected] Cheshire Engineering Corp. http://www.CheshireEng.com/ +1 626 3

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Ross Berteig
Well that will teach me to go to bed after checking something in! On 2/6/2016 12:40 PM, Andy Bradford wrote: Thus said Stephan Beal on Sat, 06 Feb 2016 20:12:04 +0100: But this did the trick: tclsh $PWD/../fossil/test/tester.tcl $PWD/../fossil/fossil And now you shouldn't even need that tri

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Stephan Beal
On Sat, Feb 6, 2016 at 9:40 PM, Andy Bradford wrote: > By the way, I no longer seem to be able to run the full set of tests > without running into a failure with json: > > $ tclsh ../fossil-src/test/tester.tcl ../fossil-src/fossil > ... > * json ** > /tmp/fossil-src/fossil help -a > /

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said Stephan Beal on Sat, 06 Feb 2016 20:12:04 +0100: > But this did the trick: > > tclsh $PWD/../fossil/test/tester.tcl $PWD/../fossil/fossil And now you shouldn't even need that trick: http://www.fossil-scm.org/index.html/info/25f7d3c1030fa4aa By the way, I no longer seem to be able

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said Stephan Beal on Sat, 06 Feb 2016 20:12:04 +0100: > > couldn't open "../fossil-src/test/fossil_prompt_answer": no such > > file or directory > > > > where did 'fossil-src' come from? That's just the name of my test repository for running tests. In your case it was just ../fossil, bu

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Stephan Beal
On Sat, Feb 6, 2016 at 8:09 PM, Andy Bradford wrote: > Thus said Stephan Beal on Sat, 06 Feb 2016 18:46:04 +0100: > > > [stephan@host:~/cvs/fossil/ftest]$ tclsh ../fossil/test/tester.tcl > > ../fossil/fossil > > That's the ticket! Apparently calling it with a relative path doesn't > work very

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said Stephan Beal on Sat, 06 Feb 2016 18:46:04 +0100: > [stephan@host:~/cvs/fossil/ftest]$ tclsh ../fossil/test/tester.tcl > ../fossil/fossil That's the ticket! Apparently calling it with a relative path doesn't work very well and I now see: ... couldn't open "../fossil-src/test/fossil_

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Stephan Beal
On Sat, Feb 6, 2016 at 6:26 PM, Andy Bradford wrote: > Thus said "Andy Bradford" on 06 Feb 2016 10:06:58 -0700: > > How did you launch the tester.tcl? > [stephan@host:~/cvs/fossil/ftest]$ tclsh ../fossil/test/tester.tcl ../fossil/fossil # echo 'puts stdout $tcl_version' | tclsh 8.6 Your test

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said Stephan Beal on Sat, 06 Feb 2016 18:25:03 +0100: > [stephan@host:~/cvs/fossil/ftest]$ tclsh --version > % [stephan@host:~/cvs/fossil/ftest]$ tclsh -? > % [stephan@host:~/cvs/fossil/ftest]$ tclsh --help > % [stephan@host:~/cvs/fossil/ftest]$ > > i give up... I don't think it's actually r

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said "Andy Bradford" on 06 Feb 2016 10:06:58 -0700: > > couldn't open "../fossil/test/fossil_prompt_answer": no such file or > > directory while executing > > Seems that something changed the behavior of how fossil_prompt_answer > is found. fossil_prompt_answer is a Tcl proc, but this er

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Stephan Beal
On Sat, Feb 6, 2016 at 6:13 PM, Andy Bradford wrote: > Thus said Stephan Beal on Sat, 06 Feb 2016 14:38:05 +0100: > > > couldn't open "../fossil/test/fossil_prompt_answer": no such file or > > directory > > while executing > > By the way, I'm unable to reproduce this error. It works fine with

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said Stephan Beal on Sat, 06 Feb 2016 14:38:05 +0100: > couldn't open "../fossil/test/fossil_prompt_answer": no such file or > directory > while executing By the way, I'm unable to reproduce this error. It works fine with: $ /tmp/fossil-src/fossil ver This is fossil version 1.35 [626276

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Andy Bradford
Thus said Stephan Beal on Sat, 06 Feb 2016 14:38:05 +0100: > couldn't open "../fossil/test/fossil_prompt_answer": no such file or > directory > while executing Seems that something changed the behavior of how fossil_prompt_answer is found. fossil_prompt_answer is a Tcl proc, but this error w

Re: [fossil-dev] Code coverage experiment

2016-02-06 Thread Stephan Beal
On Sat, Feb 6, 2016 at 12:37 AM, Ross Berteig wrote: > This effort produced another mystery which I just figured out. > > On 2/4/2016 5:45 PM, Ross Berteig wrote: > >> >> For the record, what I actually typed looked like this, at a bash prompt >> provided by MingW32 and MSYS, in a folder par

Re: [fossil-dev] Code coverage experiment

2016-02-05 Thread Joe Mistachkin
Ross Berteig wrote: > > So it seems like a good point to suggest integrating the > rberteig-json-test branch into trunk. Does anyone want to review that > further or should I just boldly do the merge myself? > I've reviewed the changes and they look fine to me. I say go ahead and merge them

Re: [fossil-dev] Code coverage experiment

2016-02-05 Thread Ross Berteig
On 2/5/2016 3:48 PM, Joe Mistachkin wrote: Ross Berteig wrote: The simple answer is to always name the fossil to test as fossil.exe on Windows when running tester.tcl. A slightly more robust answer would be include some code in tester.tcl that makes sure the ".exe" got put there if appropriate.

Re: [fossil-dev] Code coverage experiment

2016-02-05 Thread Joe Mistachkin
Ross Berteig wrote: > > The simple answer is to always name the fossil to test as fossil.exe on > Windows when running tester.tcl. A slightly more robust answer would be > include some code in tester.tcl that makes sure the ".exe" got put there > if appropriate. > Thanks for the report. Fixe

Re: [fossil-dev] Code coverage experiment

2016-02-05 Thread Ross Berteig
This effort produced another mystery which I just figured out. On 2/4/2016 5:45 PM, Ross Berteig wrote: For the record, what I actually typed looked like this, at a bash prompt provided by MingW32 and MSYS, in a folder parallel to my open checkout: $ tclsh ../fossil4/test/tester.tcl ./

Re: [fossil-dev] Code coverage experiment

2016-02-04 Thread Ross Berteig
On 2/4/2016 12:33 PM, Ross Berteig wrote: As an experiment, I decided to see how hard it would be to build fossil instrumented for code coverage and run the full test suite. Turns out it wasn't that hard to do, although it did require both configure and make to be invoked with special conditions.