Re: [fossil-users] State of tkt-hook-change branch

2013-12-20 Thread Jan Nijtmans
2013/12/16 Jan Nijtmans : > @Joe/Richard: Any reason to hold back merging this to trunk? > > If not, I'm happy to do the merge. No-one objected, so merged to trunk now. Happy Christmas days to all! Jan Nijtmans ___ fossil-users mailing list foss

Re: [fossil-users] State of tkt-hook-change branch

2013-12-16 Thread Jan Nijtmans
2013/12/13 Mark Janssen : > Thanks for the quick fixes :) Everything works great now. @Joe/Richard: Any reason to hold back merging this to trunk? If not, I'm happy to do the merge. Regards, Jan Nijtmans ___ fossil-users mailing list fossil-users@

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Mark Janssen
On Fri, Dec 13, 2013 at 4:18 PM, Jan Nijtmans wrote: > 2013/12/13 Mark Janssen : > > One final piece of feedback, concerning the next step in the trigger > > process. Fossil seems to encode the trigger request as Content-Type: > > text/plain even in the case of a GET. > > Unfortunately this will l

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Jan Nijtmans
2013/12/13 Mark Janssen : > One final piece of feedback, concerning the next step in the trigger > process. Fossil seems to encode the trigger request as Content-Type: > text/plain even in the case of a GET. > Unfortunately this will lead to an error when trying to parse the request > using tcllib'

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Mark Janssen
On Fri, Dec 13, 2013 at 3:19 PM, Jan Nijtmans wrote: > > Thanks for your feedback! > > > One final piece of feedback, concerning the next step in the trigger process. Fossil seems to encode the trigger request as Content-Type: text/plain even in the case of a GET. Unfortunately this will lead to a

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Jan Nijtmans
2013/12/13 Mark Janssen : > 1) I am fairly sure that: > memset(&urlData, '0', sizeof(urlData)); > Should be > memset(&urlData, 0, sizeof(urlData)); Right ;-) I always use '\0', but forgot the slash. > 2) I think url_parse_local should be fixed to properly fill all the urlData > fields i

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Mark Janssen
On Fri, Dec 13, 2013 at 2:15 PM, Jan Nijtmans wrote: > 2013/12/13 Mark Janssen : > > With the updated version [85528ef507] I still get the same error. > > xfer_run_script still fails with error: > > > > url must be http:// or https:// > > > > At xfer.c line 869 > > > > Maybe there is something els

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Jan Nijtmans
2013/12/13 Mark Janssen : > With the updated version [85528ef507] I still get the same error. > xfer_run_script still fails with error: > > url must be http:// or https:// > > At xfer.c line 869 > > Maybe there is something else I am doing wrong? More likely that I did something wrong, like an inc

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Mark Janssen
On Fri, Dec 13, 2013 at 12:29 PM, Jan Nijtmans wrote: > 2013/12/13 Mark Janssen : > > What is the state of the tkt-hool-change branch? I tried using it for my > own > > local repo and I can't get the http ticket hook to trigger. > > Looks like an uninitialized variable. Should be fixed now. > > I

Re: [fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Jan Nijtmans
2013/12/13 Mark Janssen : > What is the state of the tkt-hool-change branch? I tried using it for my own > local repo and I can't get the http ticket hook to trigger. Looks like an uninitialized variable. Should be fixed now. I think it's ready to be merged to trunk. Thanks! Regards, Jan

[fossil-users] State of tkt-hook-change branch

2013-12-13 Thread Mark Janssen
What is the state of the tkt-hool-change branch? I tried using it for my own local repo and I can't get the http ticket hook to trigger. th1-uri-regexp: .* hook command is: http -asynchronous -- http://mpcjanssen.nl/cgi-bin/tkt-hook?uuid=$uuid After adding some debugging statements the hook comma