[fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-01 Thread The Tick
Here's a prototype patch for getpass() in src/user.c This was very frustrating because, while I thought I entered a password, I actually was not when I did "f user password username". The issue is entering a password when using mintty on MSYS2. From some prior research, mintty does not use th

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-03 Thread Florian Balmer
Just because I have done some research about this topic recently, and find it interesting, please allow me to ask why you can make any assumptions regarding STDIN, after only testing STDERR? Couldn't each of the standard handles be redirected individually, as in "COMMAND nul 2>errors.log"? To dist

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-03 Thread The Tick
On 5/3/2017 4:26 AM, Florian Balmer wrote: Just because I have done some research about this topic recently, and find it interesting, please allow me to ask why you can make any assumptions regarding STDIN, after only testing STDERR? Couldn't each of the standard handles be redirected individuall

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-03 Thread Richard Hipp
On 5/3/17, The Tick wrote: > > the current code > does not work when using mintty. Have you tried the latest trunk version of Fossil? -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossi

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-03 Thread The Tick
On 5/3/2017 12:41 PM, Richard Hipp wrote: On 5/3/17, The Tick wrote: the current code does not work when using mintty. Have you tried the latest trunk version of Fossil? I used fossil-src-2.2.tar.gz that I downloaded in the morning on 4/29 ___ f

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-03 Thread Richard Hipp
On 5/3/17, The Tick wrote: > On 5/3/2017 12:41 PM, Richard Hipp wrote: >> On 5/3/17, The Tick wrote: >>> >>> the current code >>> does not work when using mintty. >> >> Have you tried the latest trunk version of Fossil? >> > > I used fossil-src-2.2.tar.gz that I downloaded in the morning on 4/29

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-03 Thread The Tick
On 5/3/2017 1:05 PM, Richard Hipp wrote: On 5/3/17, The Tick wrote: On 5/3/2017 12:41 PM, Richard Hipp wrote: On 5/3/17, The Tick wrote: the current code does not work when using mintty. Have you tried the latest trunk version of Fossil? I used fossil-src-2.2.tar.gz that I downloaded i

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-04 Thread Florian Balmer
I get the following results for the new `fossil test-prompt-password' command, run in the standard CMD.EXE console on Windows, typing "INPUT[ENTER]" on the keyboard if possible: > echo PASSWORD | fossil test-prompt-password PROMPT: 0 PROMPT:* [INPUT] 1. The default case. > echo P

Re: [fossil-users] Suggested patch for src/user.c (password prompt)

2017-05-04 Thread Florian Balmer
Two other interesting cases, run from the standard console: > fossil test-prompt-password PROMPT: 0 2>&1 | more INPUT PROMPT:[INPUT] 4. Password is visible while typing. > echo PASSWORD | fossil test-prompt-password PROMPT: 0 2>&1 | more PROMPT:[PASSWORD ] 5. As expected, _isatty()