[fpc-devel] TFieldDef.Size vs TField.Size

2011-02-23 Thread LacaK
Hi, I am writting here to discuss bug http://bugs.freepascal.org/view.php?id=17268 (I do not want reopen bug and writte there because I am not sure about my arguments) IMHO root of problem is in different definition of TFieldDef.Size and TField.Size Documentation says, that 1. TFieldDef.Size

[fpc-devel] RFC: Procedure TParam.AssignFieldValue

2011-02-23 Thread LacaK
Hi, can anybody look into dsparams.inc at above mentioned method. There are using 5 assigments : DataType := ... 1. because DataType is property it uses SetDataType method 2. SetDataType method try convert existing FValue into new FieldType 3. but later in AssignFieldValue is FValue rewritten by V

Re: [fpc-devel] RFC: TParam.AsBCD vs. AsFMTBCD

2011-02-23 Thread LacaK
Ok, here is patch for AsFMTBCD: TBCD ... http://bugs.freepascal.org/view.php?id=18809 Please review. It seems, that methods TParam.GetData and SetData are not used at all ... strange ;-) Laco. Well, the Delphi compatible way is usually preferred. It makes no sense to have both .asBCD and as

Re: [fpc-devel] RFC: TParam.AsBCD vs. AsFMTBCD

2011-02-23 Thread michael . vancanneyt
On Wed, 23 Feb 2011, LacaK wrote: Hi, we have in fcl-db TField.AsBCD: TBCD; but we do not have TParam.AsBCD, nor TParam.AsFMTBCD Delphi defines: TParam.AsBCD: Currency ... http://docwiki.embarcadero.com/VCL/XE/en/DB.TParam.AsBCD TParam.AsFMTBCD: TBCD ... http://docwiki.embarcadero.com/VCL/

[fpc-devel] RFC: TParam.AsBCD vs. AsFMTBCD

2011-02-23 Thread LacaK
Hi, we have in fcl-db TField.AsBCD: TBCD; but we do not have TParam.AsBCD, nor TParam.AsFMTBCD Delphi defines: TParam.AsBCD: Currency ... http://docwiki.embarcadero.com/VCL/XE/en/DB.TParam.AsBCD TParam.AsFMTBCD: TBCD ... http://docwiki.embarcadero.com/VCL/XE/en/DB.TParam.AsFMTBCD But for me