[fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Martin Schreiber
Hi, Changing TDataset.Bookmark from TBookmarkStr to TBookmark in fixes_2_6 breaks FPC 2.6.0 compatible code. Is this intended? TBookmark is defined as Pointer which has no automatic memory management so probably TDataset.FreeBookmark() must be called in a try finally block for every assignment

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Marcos Douglas
On Tue, Apr 24, 2012 at 3:56 PM, Martin Schreiber mse00...@gmail.com wrote: Hi, Changing TDataset.Bookmark from TBookmarkStr to TBookmark in fixes_2_6 breaks FPC 2.6.0 compatible code. Is this intended? TBookmark is defined as Pointer which has no automatic memory management so probably

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Vincent Snijders
Op 24 april 2012 21:16 heeft Marcos Douglas m...@delfire.net het volgende geschreven: On Tue, Apr 24, 2012 at 3:56 PM, Martin Schreiber mse00...@gmail.com wrote: Hi, Changing TDataset.Bookmark from TBookmarkStr to TBookmark in fixes_2_6 breaks FPC 2.6.0 compatible code. Is this intended?

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Marco van de Voort
In our previous episode, Martin Schreiber said: Changing TDataset.Bookmark from TBookmarkStr to TBookmark in fixes_2_6 breaks FPC 2.6.0 compatible code. Is this intended? Yes. It should not break proper code (since that would already treat it as abstract type and call freebookmark).

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Marco van de Voort
In our previous episode, Marcos Douglas said: every assignment of TDataset.Bookmark to a variable. As intended too? This broke the ZEOS 6.6.6-stable and 7.0.0-alpha too (patch to zeos 7 in attachment for somebody want). zeoslib_testing (7 trunk) has a have_tbookmark define to handle it,

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Marco van de Voort
In our previous episode, Vincent Snijders said: FPC 2.6.0 compatible code. Is this intended? TBookmark is defined as Pointer which has no automatic memory management so probably TDataset.FreeBookmark() must be called in a try finally block for every assignment of TDataset.Bookmark to a

[fpc-devel] Strange Problem!

2012-04-24 Thread Amir
Hi, I have encountered a strange problem. I developed the following function as a faster implementation for IntToStr: function MyIntToStr (n: Int64): AnsiString; const MaxLength= 16; var CurDigit: PChar; Sign: Boolean; begin Result:= ''; CurDigit:= @(Result

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Marcos Douglas
On Tue, Apr 24, 2012 at 6:18 PM, Marco van de Voort mar...@stack.nl wrote: In our previous episode, Marcos Douglas said: every assignment of TDataset.Bookmark to a variable. As intended too? This broke the ZEOS 6.6.6-stable and 7.0.0-alpha too (patch to zeos 7 in attachment for somebody

Re: [fpc-devel] Breaking change in FPC 2.6.1

2012-04-24 Thread Martin Schreiber
On Tuesday 24 April 2012 23:13:26 Marco van de Voort wrote: In our previous episode, Martin Schreiber said: Changing TDataset.Bookmark from TBookmarkStr to TBookmark in fixes_2_6 breaks FPC 2.6.0 compatible code. Is this intended? Yes. It should not break proper code (since that would