Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Juha Manninen
On Fri, Jul 15, 2016 at 2:22 PM, Maciej Izak wrote: > Change for the AForm's type to IDesignedForm is impossible in mentioned > context. IDesignedForm means not only "TForm" but is used also to handle > forms for TFrame and TDataModule. IDesignedForm is way to unify usage of >

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Maciej Izak
2016-07-15 12:18 GMT+02:00 Michael Van Canneyt : > > If the change is needed, the right approach is to fix the bug that this > change causes. > Fixed in Lazarus trunk r52691. That was long standing Lazarus bug in JITForms (vmtIntfTable slot was equal 0). It was correct

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Maciej Izak
2016-07-15 13:10 GMT+02:00 Juha Manninen : > Code design is another issue which should not be mixed here, although > I still think there is something fishy in that specific use case. It > could be implemented differently. > Change for the AForm's type to IDesignedForm

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Dimitrios Chr. Ioannidis
On 15/7/2016 12:51 μμ, Maciej Izak wrote: Hi, change in mentioned FPC trunk r34087 totally breaks sparta dockedformeditor package (and probably many other things) see: http://forum.lazarus.freepascal.org/index.php/topic,27211.msg216064.html#msg216064

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Juha Manninen
On Fri, Jul 15, 2016 at 2:01 PM, Dimitrios Chr. Ioannidis wrote: > AFAIU, unless the AForm ( a TCustomForm descendant which explicitly list > IDesignedForm ) doesn't has the IDesignedForm in it's list of supported > interfaces, then it's a bug in the compiler, because,

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Dimitrios Chr. Ioannidis
On 15/7/2016 1:31 μμ, Juha Manninen wrote: On Fri, Jul 15, 2016 at 12:51 PM, Maciej Izak wrote: constructor TDesignFormData.Create(AForm: TCustomForm); begin FForm := AForm as IDesignedForm; // won't work anymore. FForm is an interface I have not studied the context of

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Juha Manninen
On Fri, Jul 15, 2016 at 12:51 PM, Maciej Izak wrote: > constructor TDesignFormData.Create(AForm: TCustomForm); > begin > FForm := AForm as IDesignedForm; // won't work anymore. FForm is an > interface I have not studied the context of this code but to me it looks

Re: [fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Michael Van Canneyt
On Fri, 15 Jul 2016, Maciej Izak wrote: Hi, change in mentioned FPC trunk r34087 totally breaks sparta dockedformeditor package (and probably many other things) see: http://forum.lazarus.freepascal.org/index.php/topic,27211.msg216064.html#msg216064

[fpc-devel] Sven commit (r34087) breaks casting an object to an interface

2016-07-15 Thread Maciej Izak
Hi, change in mentioned FPC trunk r34087 totally breaks sparta dockedformeditor package (and probably many other things) see: http://forum.lazarus.freepascal.org/index.php/topic,27211.msg216064.html#msg216064 http://bugs.freepascal.org/view.php?id=30377 please revert mentioned commit (what is