[fpc-devel] "inline" issue

2019-04-22 Thread J. Gareth Moreton
Hi everyone, Jonas and I were talking today through e-mail and he mentioned on #35346 the following interesting point: "An inline directive in the implementation but not in the interface should be rejected by the compiler, because it changes the interface crc. I know it does not do that current

Re: [fpc-devel] Competing patches

2019-04-22 Thread J. Gareth Moreton
Aah, fair enough.  Thanks. On Mon 22/04/19 12:57 , "Jonas Maebe" jo...@freepascal.org sent: On 22/04/2019 12:52, J. Gareth Moreton wrote: >> [ https://bugs.freepascal.org/view.php?id=34772 [1] ] > who is the maintainer in this instance? Sergei Gorelkin (the author of the other patch)

Re: [fpc-devel] Competing patches

2019-04-22 Thread Jonas Maebe
On 22/04/2019 12:52, J. Gareth Moreton wrote: >> [ https://bugs.freepascal.org/view.php?id=34772 ] who is the maintainer in this instance? Sergei Gorelkin (the author of the other patch) is the maintainer of the SEH functionality. Jonas ___ fpc-d

Re: [fpc-devel] Competing patches

2019-04-22 Thread J. Gareth Moreton
Sorry for sounding dumb... who is the maintainer in this instance? Is it Martin Friebe, the person who raised the original issue?  The person who commissioned me was someone else entirely, and I think I got their attention because I bumped the priority level up back in December.  They are perfectl

Re: [fpc-devel] Competing patches

2019-04-22 Thread Jonas Maebe
On 22/04/2019 08:10, J. Gareth Moreton wrote: The question is this... what's the policy when there are two vastly different patches on offer that fix the same bug (and which cannot really be merged together)?  The bounty has already been resolved separately, so it's just a matter of what gets m

Re: [fpc-devel] Competing patches

2019-04-22 Thread J. Gareth Moreton
Heh, it was clear in my head at the time, but not on paper! The question is this... what's the policy when there are two vastly different patches on offer that fix the same bug (and which cannot really be merged together)?  The bounty has already been resolved separately, so it's just a matter of